Address comments

Author: samuelWilliams99

src/BotPlutusInterface/Contract.hs

@@ -135,7 +135,7 @@ handlePABReq contractEnv req = do
     ChainIndexQueryReq query ->
       ChainIndexQueryResp <$> queryChainIndex @w query
     BalanceTxReq unbalancedTx ->
-      BalanceTxResp <$> balanceTxStep @w contractEnv unbalancedTx
+      BalanceTxResp <$> balanceTx @w contractEnv unbalancedTx
     WriteBalancedTxReq tx ->
       WriteBalancedTxResp <$> writeBalancedTx @w contractEnv tx
     AwaitSlotReq s -> AwaitSlotResp <$> awaitSlot @w contractEnv s
@@ -162,14 +162,14 @@ handlePABReq contractEnv req = do
   printLog @w Debug $ show resp
   pure resp
 
--- | This is not identical to the real balancing, we only do a pre-balance at this stage
-balanceTxStep ::
+-- | This will FULLY balance a transaction
+balanceTx ::
   forall (w :: Type) (effs :: [Type -> Type]).
   Member (PABEffect w) effs =>
   ContractEnvironment w ->
   UnbalancedTx ->
   Eff effs BalanceTxResponse
-balanceTxStep contractEnv unbalancedTx = do
+balanceTx contractEnv unbalancedTx = do
   eitherPreBalancedTx <-
     PreBalance.balanceTxIO @w
       contractEnv.cePABConfig

test/Spec/BotPlutusInterface/Contract.hs

@@ -8,6 +8,7 @@ import Cardano.Api (NetworkId (Mainnet))
 import Control.Lens (ix, (&), (.~), (^.), (^?))
 import Data.Aeson (ToJSON)
 import Data.Aeson.Extras (encodeByteString)
+import Data.Char (isSpace)
 import Data.Default (def)
 import Data.Function (on)
 import Data.Kind (Type)
@@ -892,7 +893,7 @@ assertCommandHistory state =
     ( \(idx, expectedCmd) ->
         assertCommandEqual
           ("command at index " ++ show idx ++ " was incorrect:")
-          (Text.replace "\n" " " expectedCmd)
+          expectedCmd
           (fromMaybe "" $ state ^? commandHistory . ix idx)
     )
 
@@ -908,8 +909,8 @@ commandEqual _ "" = False
 commandEqual expected actual = maybe False (on commandEqual dropToSpace postExp) mPostAct
   where
     (preExp, postExp) = Text.breakOn "?" expected
-    mPostAct = Text.stripPrefix preExp actual
-    dropToSpace = Text.dropWhile (/= ' ')
+    mPostAct = Text.stripPrefix (Text.replace "\n" " " preExp) actual
+    dropToSpace = Text.dropWhile (not . isSpace)
 
 assertCommandCalled :: forall (w :: Type). MockContractState w -> Text -> Assertion
 assertCommandCalled state expectedCmd =