resolvong review comments

Author: mikekeke

bot-plutus-interface.cabal

@@ -82,7 +82,7 @@ library
     BotPlutusInterface.ChainIndex
     BotPlutusInterface.Contract
     BotPlutusInterface.Effects
-    BotPlutusInterface.Estimate
+    BotPlutusInterface.ExBudget
     BotPlutusInterface.Files
     BotPlutusInterface.Helpers
     BotPlutusInterface.QueryNode

src/BotPlutusInterface/Balance.hs

@@ -136,7 +136,7 @@ balanceTxIO pabConf ownPkh unbalancedTx =
       txWithoutFees <-
         hoistEither $ balanceTxStep minUtxos utxoIndex changeAddr $ tx `withFee` 0
 
-      exBudget <- newEitherT $ BodyBuilder.buildRaw @w pabConf privKeys txWithoutFees
+      exBudget <- newEitherT $ BodyBuilder.buildAndEstimateBudget @w pabConf privKeys txWithoutFees
 
       nonBudgettedFees <- newEitherT $ CardanoCLI.calculateMinFee @w pabConf txWithoutFees
 

src/BotPlutusInterface/BodyBuilder.hs

@@ -3,7 +3,7 @@
 {- | Module provides the way of building ".raw" transactions with execution budget
  estimated with `Cardano.Api` tools.
 -}
-module BotPlutusInterface.BodyBuilder (buildRaw) where
+module BotPlutusInterface.BodyBuilder (buildAndEstimateBudget) where
 
 import BotPlutusInterface.CardanoCLI qualified as CardanoCLI
 import BotPlutusInterface.Effects (PABEffect, estimateBudget)
@@ -28,14 +28,14 @@ import Prelude
  then uses body of this transaction to estimate execution budget
  and build final body with budget set.
 -}
-buildRaw ::
+buildAndEstimateBudget ::
   forall (w :: Type) (effs :: [Type -> Type]).
   Member (PABEffect w) effs =>
   PABConfig ->
   Map PubKeyHash DummyPrivKey ->
   Tx ->
   Eff effs (Either Text ExBudget)
-buildRaw pabConf privKeys tx = runEitherT $ do
+buildAndEstimateBudget pabConf privKeys tx = runEitherT $ do
   buildDraftTxBody
     >> estimateBudgetByDraftBody (Text.unpack $ txFilePath pabConf "raw" (txId tx))
     >>= buildBodyUsingEstimatedBudget

src/BotPlutusInterface/Contract.hs

@@ -249,7 +249,7 @@ writeBalancedTx contractEnv (Right tx) = do
         skeys = Map.filter (\case FromSKey _ -> True; FromVKey _ -> False) privKeys
         signable = all ((`Map.member` skeys) . Ledger.pubKeyHash) requiredSigners
 
-    void $ newEitherT $ BodyBuilder.buildRaw @w pabConf privKeys tx
+    void $ newEitherT $ BodyBuilder.buildAndEstimateBudget @w pabConf privKeys tx
 
     -- TODO: This whole part is hacky and we should remove it.
     let path = Text.unpack $ Files.txFilePath pabConf "raw" (Tx.txId tx)

src/BotPlutusInterface/Effects.hs

@@ -23,7 +23,7 @@ module BotPlutusInterface.Effects (
 ) where
 
 import BotPlutusInterface.ChainIndex (handleChainIndexReq)
-import BotPlutusInterface.Estimate qualified as Estimate
+import BotPlutusInterface.ExBudget qualified as ExBudget
 import BotPlutusInterface.Types (
   BudgetEstimationError,
   CLILocation (..),
@@ -131,7 +131,7 @@ handlePABEffect contractEnv =
         QueryChainIndex query ->
           handleChainIndexReq contractEnv.cePABConfig query
         EstimateBudget txPath ->
-          Estimate.estimateBudget contractEnv.cePABConfig txPath
+          ExBudget.estimateBudget contractEnv.cePABConfig txPath
     )
 
 printLog' :: LogLevel -> LogLevel -> String -> IO ()

src/BotPlutusInterface/Estimate.hs renamed to src/BotPlutusInterface/ExBudget.hs

@@ -1,5 +1,5 @@
 -- | Module contains implementation for `estimateBudget` effect
-module BotPlutusInterface.Estimate (
+module BotPlutusInterface.ExBudget (
   estimateBudget,
 ) where