Skip to content

Commit df0400e

Browse files
committed
refactor(param): decouple hsts & to-https cli param deserialization and normalization
1 parent f926867 commit df0400e

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

src/param/cli.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -392,16 +392,10 @@ func ParseCli() (params []*Param, printVersion, printHelp bool, errs []error) {
392392
param.ListensTLS, _ = result.GetStrings("listenstls")
393393

394394
// hsts & https
395-
if len(param.ListensTLS) > 0 {
396-
if result.HasKey("globalhsts") {
397-
param.GlobalHsts = validateHstsPort(param.ListensPlain, param.ListensTLS)
398-
}
395+
param.GlobalHsts = result.HasKey("globalhsts")
399396

400-
if result.HasKey("globalhttps") {
401-
httpsPort, _ := result.GetString("globalhttps")
402-
param.HttpsPort, param.GlobalHttps = normalizeHttpsPort(httpsPort, param.ListensTLS)
403-
}
404-
}
397+
param.GlobalHttps = result.HasKey("globalhttps")
398+
param.HttpsPort, _ = result.GetString("globalhttps")
405399

406400
// shows/hides
407401
param.Shows, _ = result.GetStrings("shows")

src/param/main.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,5 +158,14 @@ func (param *Param) normalize() (errs []error) {
158158
param.AuthUrls = normalizeUrlPaths(param.AuthUrls)
159159
param.AuthDirs = normalizeFsPaths(param.AuthDirs)
160160

161+
// hsts & https
162+
if param.GlobalHsts {
163+
param.GlobalHsts = validateHstsPort(param.ListensPlain, param.ListensTLS)
164+
}
165+
166+
if param.GlobalHttps {
167+
param.HttpsPort, param.GlobalHttps = normalizeHttpsPort(param.HttpsPort, param.ListensTLS)
168+
}
169+
161170
return
162171
}

0 commit comments

Comments
 (0)