perf(serverHandler): use slice struct for url alias

Slice is about more than 15x faster than map.

Author: marjune163

src/serverHandler/alias.go

@@ -0,0 +1,17 @@
+package serverHandler
+
+type alias struct {
+	urlPath string
+	fsPath  string
+}
+
+type aliases []*alias
+
+func (aliases aliases) byUrlPath(urlPath string) (alias *alias, ok bool) {
+	for _, alias := range aliases {
+		if urlPath == alias.urlPath {
+			return alias, true
+		}
+	}
+	return nil, false
+}

src/serverHandler/archive.go

@@ -17,11 +17,11 @@ func (h *handler) visitFs(
 	filterCallback filterCallback,
 	archiveCallback archiveCallback,
 ) {
-	aliasedFsPath, hasAlias := h.aliases[rawRequestPath]
+	alias, hasAlias := h.aliases.byUrlPath(rawRequestPath)
 
 	var fsPath string
 	if hasAlias {
-		fsPath = aliasedFsPath
+		fsPath = alias.fsPath
 	} else {
 		fsPath = initFsPath
 	}
@@ -70,7 +70,10 @@ func (h *handler) visitFs(
 
 	if fInfo.IsDir() {
 		childAliases := map[string]string{}
-		for aliasUrlPath, aliasFsPath := range h.aliases {
+		for _, alias := range h.aliases {
+			aliasUrlPath := alias.urlPath
+			aliasFsPath := alias.fsPath
+
 			if aliasUrlPath != rawRequestPath && path.Dir(aliasUrlPath) == rawRequestPath {
 				childAliases[aliasUrlPath] = aliasFsPath
 				continue

src/serverHandler/auth.go

@@ -7,7 +7,7 @@ func (h *handler) auth(w http.ResponseWriter, r *http.Request) (success bool) {
 	header.Set("WWW-Authenticate", "Basic realm=\""+r.URL.Path+"\"")
 
 	username, password, hasAuthReq := r.BasicAuth()
-	if (hasAuthReq) {
+	if hasAuthReq {
 		success = h.users.Auth(username, password)
 	}
 

src/serverHandler/main.go

@@ -16,7 +16,7 @@ type handler struct {
 
 	fallbackProxies map[string]http.Handler
 	alwaysProxies   map[string]http.Handler
-	aliases         map[string]string
+	aliases         aliases
 
 	globalUpload bool
 	uploadUrls   []string
@@ -140,13 +140,18 @@ func NewHandler(
 	logger *serverLog.Logger,
 	errHandler *serverErrHandler.ErrHandler,
 ) *handler {
+	aliases := aliases{}
+	for urlPath, fsPath := range p.Aliases {
+		aliases = append(aliases, &alias{urlPath, fsPath})
+	}
+
 	h := &handler{
 		root:      root,
 		urlPrefix: urlPrefix,
 
 		fallbackProxies: fallbackProxies,
 		alwaysProxies:   alwaysProxies,
-		aliases:         p.Aliases,
+		aliases:         aliases,
 
 		globalUpload: p.GlobalUpload,
 		uploadUrls:   p.UploadUrls,

src/serverHandler/responseData.go

@@ -110,7 +110,10 @@ func readdir(file *os.File, item os.FileInfo) (subItems []os.FileInfo, errs []er
 func (h *handler) mergeAlias(rawRequestPath string, subItems *[]os.FileInfo) []error {
 	errs := []error{}
 
-	for aliasUrlPath, aliasFsPath := range h.aliases {
+	for _, alias := range h.aliases {
+		aliasUrlPath := alias.urlPath
+		aliasFsPath := alias.fsPath
+
 		if len(aliasUrlPath) <= len(rawRequestPath) {
 			continue
 		}