Skip to content

Commit 9384ef6

Browse files
committed
perf(serverHandler): allocate errors slice only if needed
1 parent 25c8491 commit 9384ef6

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

src/serverHandler/delete.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
)
99

1010
func (h *handler) deleteItems(authUserName, fsPrefix string, files []string, aliasSubItems []os.FileInfo, r *http.Request) bool {
11-
errs := []error{}
11+
var errs []error
1212

1313
for _, inputFilename := range files {
1414
if len(inputFilename) == 0 {

src/serverHandler/mkdir.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
)
1010

1111
func (h *handler) mkdirs(authUserName, fsPrefix string, files []string, aliasSubItems []os.FileInfo, r *http.Request) bool {
12-
errs := []error{}
12+
var errs []error
1313

1414
for _, inputFilename := range files {
1515
if len(inputFilename) == 0 {

src/serverHandler/responseData.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ func (h *handler) mergeAlias(
137137
subItems []os.FileInfo,
138138
doMerge bool,
139139
) (mergedSubItems, aliasSubItems []os.FileInfo, errs []error) {
140-
errs = []error{}
141-
142140
if !doMerge || (item != nil && !item.IsDir()) || len(h.aliases) == 0 {
143141
return subItems, nil, errs
144142
}

src/serverHandler/upload.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func getPartFilePath(part *multipart.Part) string {
5454
}
5555

5656
func (h *handler) saveUploadFiles(authUserName, fsPrefix string, createDir, overwriteExists bool, aliasSubItems []os.FileInfo, r *http.Request) bool {
57-
errs := []error{}
57+
var errs []error
5858

5959
reader, err := r.MultipartReader()
6060
if err != nil {

0 commit comments

Comments
 (0)