Skip to content

Commit 8cc67b2

Browse files
committed
refactor(tpl): simplify enableNonRefreshDelete()
1 parent b93eb27 commit 8cc67b2

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

src/tpl/asset/main.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -775,18 +775,12 @@
775775
}
776776

777777
itemList.addEventListener('click', function (e) {
778-
if (e.defaultPrevented || !e.target || e.target.className.indexOf('delete') < 0) {
778+
if (e.defaultPrevented || !e.target || !e.target.href || e.target.className.indexOf('delete') < 0) {
779779
return;
780780
}
781781

782-
var elLink = e.target;
783-
784-
function onComplete() {
785-
elLink = null;
786-
}
787-
788782
function onLoad() {
789-
var elItem = elLink;
783+
var elItem = e.target;
790784
while (elItem && elItem.nodeName !== 'LI') {
791785
elItem = elItem.parentNode;
792786
}
@@ -798,11 +792,8 @@
798792
}
799793

800794
var xhr = new XMLHttpRequest();
801-
xhr.open('POST', elLink.href); // will retrieve deleted result into bfcache
795+
xhr.open('POST', e.target.href); // will retrieve deleted result into bfcache
802796
xhr.addEventListener('load', onLoad);
803-
xhr.addEventListener('load', onComplete);
804-
xhr.addEventListener('error', onComplete);
805-
xhr.addEventListener('abort', onComplete);
806797
xhr.send();
807798
e.preventDefault();
808799
return false;

src/tpl/asset/main.js.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -685,15 +685,11 @@ return;
685685
return;
686686
}
687687
itemList.addEventListener('click', function (e) {
688-
if (e.defaultPrevented || !e.target || e.target.className.indexOf('delete') < 0) {
688+
if (e.defaultPrevented || !e.target || !e.target.href || e.target.className.indexOf('delete') < 0) {
689689
return;
690690
}
691-
var elLink = e.target;
692-
function onComplete() {
693-
elLink = null;
694-
}
695691
function onLoad() {
696-
var elItem = elLink;
692+
var elItem = e.target;
697693
while (elItem && elItem.nodeName !== 'LI') {
698694
elItem = elItem.parentNode;
699695
}
@@ -704,11 +700,8 @@ var elItemParent = elItem.parentNode;
704700
elItemParent && elItemParent.removeChild(elItem);
705701
}
706702
var xhr = new XMLHttpRequest();
707-
xhr.open('POST', elLink.href); // will retrieve deleted result into bfcache
703+
xhr.open('POST', e.target.href); // will retrieve deleted result into bfcache
708704
xhr.addEventListener('load', onLoad);
709-
xhr.addEventListener('load', onComplete);
710-
xhr.addEventListener('error', onComplete);
711-
xhr.addEventListener('abort', onComplete);
712705
xhr.send();
713706
e.preventDefault();
714707
return false;

0 commit comments

Comments
 (0)