feat(serverHandler/responseData): add auth error to log

Author: marjune163

src/serverHandler/auth.go

@@ -1,17 +1,25 @@
 package serverHandler
 
-import "net/http"
+import (
+	"errors"
+	"net/http"
+)
 
 func (h *handler) needAuth(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("WWW-Authenticate", "Basic realm=\""+r.URL.Path+"\"")
 }
 
-func (h *handler) verifyAuth(r *http.Request) (username string, success bool) {
+func (h *handler) verifyAuth(r *http.Request) (username string, success bool, err error) {
 	var password string
 	var hasAuthReq bool
 	username, password, hasAuthReq = r.BasicAuth()
 	if hasAuthReq {
 		success = h.users.Auth(username, password)
+		if !success {
+			err = errors.New(r.RemoteAddr + " auth failed")
+		}
+	} else {
+		err = errors.New(r.RemoteAddr + " missing auth info")
 	}
 
 	return

src/serverHandler/responseData.go

@@ -263,6 +263,8 @@ func (h *handler) stateIndexFile(rawReqPath, baseDir string, baseItem os.FileInf
 }
 
 func (h *handler) getResponseData(r *http.Request) *responseData {
+	var errs []error
+
 	requestUri := r.URL.Path
 	if len(requestUri) == 0 {
 		requestUri = "/"
@@ -277,7 +279,11 @@ func (h *handler) getResponseData(r *http.Request) *responseData {
 	authUserName := ""
 	authSuccess := true
 	if needAuth {
-		authUserName, authSuccess = h.verifyAuth(r)
+		var _authErr error
+		authUserName, authSuccess, _authErr = h.verifyAuth(r)
+		if _authErr != nil {
+			errs = append(errs, _authErr)
+		}
 	}
 
 	rawQuery := r.URL.RawQuery
@@ -301,7 +307,6 @@ func (h *handler) getResponseData(r *http.Request) *responseData {
 	}
 	wantJson := strings.HasPrefix(rawQuery, "json") || strings.Contains(rawQuery, "&json")
 
-	errs := []error{}
 	status := http.StatusOK
 	isRoot := rawReqPath == "/"
 

test/case/007.auth.bash

@@ -2,7 +2,7 @@
 
 source "$root"/lib.bash
 
-"$ghfs" -l 3003 -r "$fs"/vhost1 --auth /hello --user alice:AliceSecret &
+"$ghfs" -l 3003 -r "$fs"/vhost1 --auth /hello --user alice:AliceSecret -E '' &
 sleep 0.05 # wait server ready
 
 yesstatus=$(curl_get_status http://127.0.0.1:3003/yes/)