refactor(main): extract start logic

Author: marjune163

src/main.go

@@ -29,19 +29,29 @@ func Main() (ok bool) {
 	// settings
 	settings := setting.ParseFromEnv()
 
+	// start
+	errs = Start(settings, params)
+	if serverError.CheckError(errs...) {
+		return
+	}
+
+	return true
+}
+
+func Start(settings *setting.Setting, params param.Params) (errs []error) {
 	// CPU profile
 	if len(settings.CPUProfileFile) > 0 {
-		cpuProfileFile, err := StartCPUProfile(settings.CPUProfileFile)
-		if serverError.CheckError(err) {
-			return
+		cpuProfileFile, err := startCPUProfile(settings.CPUProfileFile)
+		if err != nil {
+			return []error{err}
 		}
-		defer StopCPUProfile(cpuProfileFile)
+		defer stopCPUProfile(cpuProfileFile)
 	}
 
 	// pid file
 	if len(settings.PidFile) > 0 {
 		errs = writePidFile(settings.PidFile)
-		if serverError.CheckError(errs...) {
+		if len(errs) > 0 {
 			return
 		}
 	}
@@ -56,11 +66,11 @@ func Main() (ok bool) {
 
 	// app
 	appInst, errs := app.NewApp(params)
-	if serverError.CheckError(errs...) {
+	if len(errs) > 0 {
 		return
 	}
 	if appInst == nil {
-		serverError.CheckError(errors.New("failed to create application instance"))
+		errs = []error{errors.New("failed to create application instance")}
 		return
 	}
 
@@ -70,9 +80,5 @@ func Main() (ok bool) {
 		printAccessibleURLs(appInst.GetAccessibleUrls(false))
 	}
 	errs = appInst.Open()
-	if serverError.CheckError(errs...) {
-		return
-	}
-
-	return true
+	return
 }

src/profile.go

@@ -5,7 +5,7 @@ import (
 	"runtime/pprof"
 )
 
-func StartCPUProfile(profileFilePath string) (*os.File, error) {
+func startCPUProfile(profileFilePath string) (*os.File, error) {
 	profileFile, err := os.OpenFile(profileFilePath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0644)
 	if err != nil {
 		return nil, err
@@ -20,7 +20,7 @@ func StartCPUProfile(profileFilePath string) (*os.File, error) {
 	return profileFile, nil
 }
 
-func StopCPUProfile(profileFile *os.File) error {
+func stopCPUProfile(profileFile *os.File) error {
 	pprof.StopCPUProfile()
 	return profileFile.Close()
 }