feat(serverHandler): prevent output error information to end user

Author: marjune163

src/serverHandler/main.go

@@ -61,9 +61,9 @@ func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	// data
 	data := h.getResponseData(r)
-	if len(data.Errors) > 0 {
+	if len(data.errors) > 0 {
 		go func() {
-			for _, err := range data.Errors {
+			for _, err := range data.errors {
 				h.errHandler.LogError(err)
 			}
 		}()

src/serverHandler/responseData.go

@@ -42,6 +42,7 @@ type responseData struct {
 
 	hasNotFoundError bool
 	hasInternalError bool
+	errors           []error
 
 	IsRoot        bool
 	Path          string
@@ -57,7 +58,6 @@ type responseData struct {
 	CanArchive bool
 	CanCors    bool
 	NeedAuth   bool
-	Errors     []error
 }
 
 func isSlash(c rune) bool {
@@ -265,9 +265,9 @@ func (h *handler) getResponseData(r *http.Request) (data *responseData) {
 
 	rawReqPath := util.CleanUrlPath(requestUri)
 	reqPath := util.CleanUrlPath(rawReqPath[len(h.urlPrefix):]) // strip url prefix path
-	errs := []error{}
 	notFound := false
 	internalError := false
+	errs := []error{}
 
 	isRoot := rawReqPath == "/"
 
@@ -323,6 +323,7 @@ func (h *handler) getResponseData(r *http.Request) (data *responseData) {
 
 		hasNotFoundError: notFound,
 		hasInternalError: internalError,
+		errors:           errs,
 
 		IsRoot:        isRoot,
 		Path:          rawReqPath,
@@ -338,8 +339,6 @@ func (h *handler) getResponseData(r *http.Request) (data *responseData) {
 		CanArchive: canArchive,
 		CanCors:    canCors,
 		NeedAuth:   needAuth,
-
-		Errors: errs,
 	}
 
 	return

src/tpl/assert/main.css

@@ -213,12 +213,6 @@ em {
 	float: right;
 }
 
-.error {
-	margin: 1em;
-	padding: 1em;
-	background: #ffc;
-}
-
 @media only screen and (max-width: 350px) {
 	.item-list .time {
 		display: none;

src/tpl/assert/main.css.go

@@ -184,11 +184,6 @@ white-space: nowrap;
 overflow: hidden;
 float: right;
 }
-.error {
-margin: 1em;
-padding: 1em;
-background: #ffc;
-}
 @media only screen and (max-width: 350px) {
 .item-list .time {
 display: none;

src/tpl/page.html

@@ -56,10 +56,6 @@
 	{{end}}{{end}}
 </ul>
 
-{{range .Errors}}
-	<div class="error">{{.}}</div>
-{{end}}
-
 <script type="text/javascript" src="{{.RootRelPath}}/../assert/main.js"></script>
 </body>
 </html>

src/tpl/page.html.go

@@ -60,9 +60,6 @@ const pageTplStr = `
 </li>
 {{end}}{{end}}
 </ul>
-{{range .Errors}}
-<div class="error">{{.}}</div>
-{{end}}
 <script type="text/javascript" src="{{.RootRelPath}}?assert=main.js"></script>
 </body>
 </html>