refactor: move pid file logic out of app

Author: marjune163

src/app/main.go

@@ -54,13 +54,6 @@ func (app *App) GetAccessibleOrigins(includeLoopback bool) [][]string {
 }
 
 func NewApp(params param.Params, settings *setting.Setting) (*App, []error) {
-	if len(settings.PidFile) > 0 {
-		errs := writePidFile(settings.PidFile)
-		if len(errs) > 0 {
-			return nil, errs
-		}
-	}
-
 	vhSvc := goVirtualHost.NewService()
 	logMan := serverLog.NewMan()
 	themePool := make(map[string]theme.Theme)

src/main.go

@@ -71,6 +71,14 @@ func Main() (ok bool) {
 		defer StopCPUProfile(cpuProfileFile)
 	}
 
+	// pid file
+	if len(settings.PidFile) > 0 {
+		errs = writePidFile(settings.PidFile)
+		if serverError.CheckError(errs...) {
+			return
+		}
+	}
+
 	// log queue size
 	if len(settings.LogQueueSize) > 0 {
 		logQueueSize, err := strconv.Atoi(settings.LogQueueSize)

src/app/pidFile.go renamed to src/pidFile.go

@@ -1,4 +1,4 @@
-package app
+package src
 
 import (
 	"mjpclab.dev/ghfs/src/serverError"
@@ -7,12 +7,12 @@ import (
 )
 
 func writePidFile(pidFilePath string) (errs []error) {
-	pidContent := strconv.Itoa(os.Getpid())
 	pidFile, err := os.OpenFile(pidFilePath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0644)
 	if err != nil {
 		return []error{err}
 	}
 
+	pidContent := strconv.Itoa(os.Getpid())
 	_, err = pidFile.WriteString(pidContent)
 	errs = serverError.AppendError(errs, err)