Skip to content

Commit 0454fdd

Browse files
committed
fix(serverHandler): ensure not mutating aliased item
- prevent doing mkdir if it is an alias - prevent doing delete if it is an alias
1 parent 2d3c24b commit 0454fdd

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/serverHandler/delete.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ func (h *handler) deleteItems(fsPrefix string, files []string, aliasSubItems []o
1818
if filename, ok = getCleanFilePath(inputFilename); !ok {
1919
errs = append(errs, errors.New("delete: illegal item name "+inputFilename))
2020
continue
21-
} else if containsItem(aliasSubItems, filename) {
21+
}
22+
if containsItem(aliasSubItems, filename) {
2223
continue
2324
}
2425
err := os.RemoveAll(fsPrefix + "/" + filename)

src/serverHandler/mkdir.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ func (h *handler) mkdirs(fsPrefix string, files []string, aliasSubItems []os.Fil
1818
if filename, ok = getCleanFilePath(inputFilename); !ok {
1919
errs = append(errs, errors.New("mkdir: illegal directory name "+inputFilename))
2020
continue
21-
} else if containsItem(aliasSubItems, filename) {
21+
}
22+
if containsItem(aliasSubItems, filename) {
2223
continue
2324
}
2425
err := os.Mkdir(fsPrefix+"/"+filename, 0755)

0 commit comments

Comments
 (0)