Skip to content

Commit 618d245

Browse files
committed
fix CI
1 parent 488edd8 commit 618d245

File tree

1 file changed

+17
-12
lines changed

1 file changed

+17
-12
lines changed

MixpanelDemo/MixpanelDemoTests/MixpanelDemoTests.swift

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -969,25 +969,28 @@ class MixpanelDemoTests: MixpanelBaseTests {
969969

970970
func testMultipleInstancesWithSameTokenButDifferentInstanceName() {
971971
let testToken = randomId()
972-
let instance1 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: "instance1")
973-
let instance2 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: "instance2")
972+
let instanceName1 = randomId()
973+
let instanceName2 = randomId()
974+
let instance1 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: instanceName1)
975+
let instance2 = Mixpanel.initialize(token: testToken, trackAutomaticEvents: true, flushInterval: 60, instanceName: instanceName2)
974976

975977
XCTAssertNotEqual(instance1.distinctId, instance2.distinctId)
976978
instance1.identify(distinctId: "user1")
977979
instance1.track(event: "test")
978980
waitForTrackingQueue(instance1)
981+
waitForTrackingQueue(instance2)
982+
979983
XCTAssertEqual(instance1.distinctId, "user1")
980984
XCTAssertEqual(instance1.userId, "user1")
981-
let events = eventQueue(token: "instance1")
985+
let events = eventQueue(token: instanceName1)
982986
let properties = events.last?["properties"] as? InternalProperties
983-
// TODO: Need to figure out why this test is flaky
984-
// event property should have the current distinct id
985-
//XCTAssertEqual(properties?["distinct_id"] as? String, "user1")
987+
XCTAssertEqual(properties?["distinct_id"] as? String, "user1")
986988

987989
instance1.people.set(property: "p1", to: "a")
988990
waitForTrackingQueue(instance1)
989-
990-
let peopleQueue_value = peopleQueue(token: "instance1")
991+
waitForTrackingQueue(instance2)
992+
993+
let peopleQueue_value = peopleQueue(token: instanceName1)
991994
let setValue = peopleQueue_value.last!["$set"] as! InternalProperties
992995
XCTAssertEqual(setValue["p1"] as? String, "a", "custom people property not queued")
993996

@@ -996,26 +999,28 @@ class MixpanelDemoTests: MixpanelBaseTests {
996999

9971000
instance2.identify(distinctId: "user2")
9981001
instance2.track(event: "test2")
1002+
waitForTrackingQueue(instance1)
9991003
waitForTrackingQueue(instance2)
10001004
XCTAssertEqual(instance2.distinctId, "user2")
10011005
XCTAssertEqual(instance2.userId, "user2")
1002-
let events2 = eventQueue(token: "instance2")
1006+
let events2 = eventQueue(token: instanceName2)
10031007
let properties2 = events2.last?["properties"] as? InternalProperties
10041008
// event property should have the current distinct id
10051009
XCTAssertEqual(properties2?["distinct_id"] as? String, "user2")
10061010

10071011
instance2.people.set(property: "p2", to: "b")
1012+
waitForTrackingQueue(instance1)
10081013
waitForTrackingQueue(instance2)
10091014

1010-
let peopleQueue2_value = peopleQueue(token: "instance2")
1015+
let peopleQueue2_value = peopleQueue(token: instanceName2)
10111016
XCTAssertEqual(peopleQueue2_value.last?["$distinct_id"] as? String,
10121017
"user2", "distinct id not set properly on the people record")
10131018

10141019
let setValue2 = peopleQueue2_value.last!["$set"] as! InternalProperties
10151020
XCTAssertEqual(setValue2["p2"] as? String, "b", "custom people property not queued")
10161021

1017-
removeDBfile("instance1")
1018-
removeDBfile("instance2")
1022+
removeDBfile(instanceName1)
1023+
removeDBfile(instanceName2)
10191024
}
10201025

10211026
func testReadWriteMultiThreadShouldNotCrash() {

0 commit comments

Comments
 (0)