Handling few invalid inputs

DanielAbalde · DanielAbalde · commit a8ef6be6716f · 2021-04-16T11:18:18.000+01:00
diff --git a/GHUI/BuildHtmlUiComponent.cs b/GHUI/BuildHtmlUiComponent.cs
@@ -56,6 +56,12 @@ protected override void SolveInstance(IGH_DataAccess da)
             List<string> jsScripts = new List<string>();
 
             if (!da.GetData(0, ref path)) return;
+            if(!System.IO.File.Exists(path))
+            { 
+                AddRuntimeMessage(GH_RuntimeMessageLevel.Error, $"File path: \"{path}\" not found on this computer");
+                da.SetData(0, false);
+                return;
+            }
             if (!da.GetData(1, ref htmlString)) return;
             da.GetData(2, ref title);
             da.GetDataList(3, stylesheets);
diff --git a/GHUI/Classes/WebView2Wrapper.cs b/GHUI/Classes/WebView2Wrapper.cs
@@ -248,6 +248,8 @@ private void OnDocumentUpdated(object sender, DOM.DocumentUpdatedEventArgs args)
         /// </summary>
         public void SubscribeToHtmlChanged()
         {
+            if (!System.IO.Directory.Exists(Directory))
+                throw new System.IO.DirectoryNotFoundException($"Can not find: \"{Directory}\" on this computer");
             _watcher = new FileSystemWatcher(Directory)
             {
                 NotifyFilter = NotifyFilters.LastAccess
diff --git a/GHUI/HtmlUiComponent.cs b/GHUI/HtmlUiComponent.cs
@@ -63,6 +63,11 @@ protected override void SolveInstance(IGH_DataAccess da)
 
             // get input
             if (!da.GetData(0, ref path)) return;
+            if (!System.IO.File.Exists(path))
+            {
+                AddRuntimeMessage(GH_RuntimeMessageLevel.Error, $"File path: \"{path}\" not found on this computer");
+                return;
+            }
             if (!da.GetData<bool>(1, ref show)) return;
             da.GetData(2, ref title);
             da.GetData(3, ref _height);
diff --git a/GHUI/SettersDefineComponent.cs b/GHUI/SettersDefineComponent.cs
@@ -39,6 +39,12 @@ protected override void SolveInstance(IGH_DataAccess da)
             if (!da.GetDataList(0, ids)) return;
             if (!da.GetDataList(1, vals)) return;
 
+            if(ids.Count != vals.Count)
+            {
+                AddRuntimeMessage(GH_RuntimeMessageLevel.Error, "Amount of IDs and Values must be equal");
+                return;
+            }
+
             //List<DomSetValueModelGoo> setValueModels =
             //    ids.Select((t, i) => new DomSetValueModelGoo() {id = t, value = vals[i]}).ToList();
 
diff --git a/GHUI/Web UI/createdInput.html b/GHUI/Web UI/createdInput.html
@@ -1 +1 @@
-<div style=''><input type='range' id='mySlider' name='mySlider' value='50' min='0' max='100'></div><div style='width:100%; height:200px; background:lightgray;'><input type='range' id='mySlider2' name='mySlider2' value='50' min='0' max='100'></div>
+<!DOCTYPE html><html lang=en><meta charset=utf-8><title>UI</title><!DOCTYPE html><html lang=en><meta charset=utf-8><title>UI</title><!DOCTYPE html><html lang=en xmlns=http://www.w3.org/1999/xhtml><div id=app><h1>HELLO THERE</h1></div>

Original file line number	Diff line number	Diff line change
`@@ -248,6 +248,8 @@ private void OnDocumentUpdated(object sender, DOM.DocumentUpdatedEventArgs args)`
`248`	`248`	`/// </summary>`
`249`	`249`	`public void SubscribeToHtmlChanged()`
`250`	`250`	`{`
	`251`	`+ if (!System.IO.Directory.Exists(Directory))`
	`252`	`+ throw new System.IO.DirectoryNotFoundException($"Can not find: \"{Directory}\" on this computer");`
`251`	`253`	`_watcher = new FileSystemWatcher(Directory)`
`252`	`254`	`{`
`253`	`255`	`NotifyFilter = NotifyFilters.LastAccess`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-<div style=''><input type='range' id='mySlider' name='mySlider' value='50' min='0' max='100'></div><div style='width:100%; height:200px; background:lightgray;'><input type='range' id='mySlider2' name='mySlider2' value='50' min='0' max='100'></div>`
	`1`	`+<!DOCTYPE html><html lang=en><meta charset=utf-8><title>UI</title><!DOCTYPE html><html lang=en><meta charset=utf-8><title>UI</title><!DOCTYPE html><html lang=en xmlns=http://www.w3.org/1999/xhtml><div id=app><h1>HELLO THERE</h1></div>`