Address comments + remove Prism.css since it's now unnecessary

ricardonunez-io · ricardonunez-io · commit 1e760305c694 · 2025-06-10T10:25:39.000-07:00
diff --git a/examples/app-router/app/layout.tsx b/examples/app-router/app/layout.tsx
@@ -1,4 +1,3 @@
-import '@mintlify/mdx/dist/styles.css';
 import type { Metadata } from 'next';
 
 import '@/app/globals.css';
diff --git a/examples/app-router/readme.md b/examples/app-router/readme.md
@@ -30,23 +30,3 @@ You can check out the demo of [this page](https://github.com/mintlify/mdx/blob/m
      );
    }
    ```
-
-2. Import `@mintlify/mdx/dist/styles.css` inside your `layout.tsx` file. This file contains the styles for the code syntax highlighting.
-
-   ```tsx
-   import '@mintlify/mdx/dist/styles.css';
-   import type { Metadata } from 'next';
-
-   export const metadata: Metadata = {
-     title: 'Create Next App',
-     description: 'Generated by create next app',
-   };
-
-   export default function RootLayout({ children }: { children: React.ReactNode }) {
-     return (
-       <html lang="en">
-         <body>{children}</body>
-       </html>
-     );
-   }
-   ```
diff --git a/examples/pages-router/pages/_app.tsx b/examples/pages-router/pages/_app.tsx
@@ -1,4 +1,3 @@
-import '@mintlify/mdx/dist/styles.css';
 import { AppProps } from 'next/app';
 
 import '@/styles/globals.css';
diff --git a/examples/pages-router/readme.md b/examples/pages-router/readme.md
@@ -19,7 +19,7 @@ You can check out the demo of [this page](https://github.com/mintlify/mdx/blob/m
      });
 
      if ('error' in mdxSource) {
-      // handle error case
+       // handle error case
      }
 
      return { props: { mdxSource } };
@@ -35,14 +35,3 @@ You can check out the demo of [this page](https://github.com/mintlify/mdx/blob/m
      return <MDXClient {...mdxSource} />;
    }
    ```
-
-3. Import `@mintlify/mdx/dist/styles.css` inside your `_app.tsx` file. This file contains the styles for the code syntax highlighting.
-
-   ```tsx
-   import '@mintlify/mdx/dist/styles.css';
-   import { AppProps } from 'next/app';
-
-   export default function App({ Component, pageProps }: AppProps) {
-     return <Component {...pageProps} />;
-   }
-   ```
diff --git a/packages/mdx/package.json b/packages/mdx/package.json
@@ -5,9 +5,7 @@
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "sideEffects": false,
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "exports": {
     ".": {
       "import": "./dist/index.js",
@@ -29,15 +27,14 @@
   },
   "scripts": {
     "prepare": "npm run build",
-    "build": "tsc --project tsconfig.build.json && yarn copy:css",
+    "build": "tsc --project tsconfig.build.json",
     "clean:build": "rimraf dist",
     "clean:all": "rimraf node_modules .eslintcache && yarn clean:build",
     "watch": "tsc --watch",
     "type": "tsc --noEmit",
     "lint": "eslint . --cache",
     "format": "prettier . --write",
-    "format:check": "prettier . --check",
-    "copy:css": "cp -r ./src/styles/prism.css ./dist/styles.css"
+    "format:check": "prettier . --check"
   },
   "author": "Mintlify, Inc.",
   "license": "MIT",
diff --git a/packages/mdx/src/plugins/rehype/rehypeSyntaxHighlighting.ts b/packages/mdx/src/plugins/rehype/rehypeSyntaxHighlighting.ts
@@ -8,6 +8,7 @@ import {
   DEFAULT_LANG_ALIASES,
   SHIKI_THEMES,
   UNIQUE_LANGS,
+  DEFAULT_LANG,
   type ShikiLang,
   type ShikiTheme,
 } from './shiki-constants.js';
@@ -92,15 +93,15 @@ export const rehypeSyntaxHighlighting: Plugin<[RehypeSyntaxHighlightingOptions?]
       let lang =
         getLanguage(node, DEFAULT_LANG_ALIASES) ??
         getLanguage(child, DEFAULT_LANG_ALIASES) ??
-        'text';
+        DEFAULT_LANG;
 
       try {
         const code = toString(node);
         const lines = code.split('\n');
         let linesToHighlight = getLinesToHighlight(node, lines.length);
 
         const hast = highlighter.codeToHast(code, {
-          lang: lang ?? 'text',
+          lang: lang ?? DEFAULT_LANG,
           themes: {
             light:
               options.themes?.light ??
diff --git a/packages/mdx/src/plugins/rehype/shiki-constants.ts b/packages/mdx/src/plugins/rehype/shiki-constants.ts
@@ -2,6 +2,8 @@ import type { BundledLanguage } from 'shiki';
 
 export type ShikiLang = BundledLanguage | 'text';
 
+export const DEFAULT_LANG = 'text' as const;
+
 export const DEFAULT_LANG_ALIASES: Record<string, ShikiLang> = {
   abap: 'abap',
   'actionscript-3': 'actionscript-3',
diff --git a/packages/mdx/src/styles/prism.css b/packages/mdx/src/styles/prism.css
diff --git a/readme.md b/readme.md

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import '@mintlify/mdx/dist/styles.css';`
`2`	`1`	`import type { Metadata } from 'next';`
`3`	`2`
`4`	`3`	`import '@/app/globals.css';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import '@mintlify/mdx/dist/styles.css';`
`2`	`1`	`import { AppProps } from 'next/app';`
`3`	`2`
`4`	`3`	`import '@/styles/globals.css';`