Skip to content

Commit e8a4d54

Browse files
committed
Merge branch 'dev' into 2018.3 and fix compile
2 parents 98c4560 + 8b0faec commit e8a4d54

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

build.gradle.kts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,27 @@ dependencies {
8282
compile(files(Jvm.current().toolsJar))
8383

8484
compile(files(gradleToolingExtensionJar))
85-
"gradle-tooling-extension"("com.jetbrains.intellij.gradle:gradle-tooling-extension:$ideaVersion")
8685

8786
"jflex"("org.jetbrains.idea:jflex:1.7.0-b7f882a")
8887
"jflex-skeleton"("org.jetbrains.idea:jflex:1.7.0-c1fdf11:idea@skeleton")
8988
"grammar-kit"("org.jetbrains.idea:grammar-kit:1.5.1")
9089

9190
"testLibs"("org.jetbrains.idea:mockJDK:1.7-4d76c50")
9291
"testLibs"("org.spongepowered:mixin:0.7-SNAPSHOT:thin")
92+
93+
// Better way to do this?
94+
if (!ideaVersion.endsWith("SNAPSHOT")) {
95+
afterEvaluate {
96+
// This needs to happen after build number is resolved
97+
// intellij.ideaDependency.buildNumber == intellij.type-<buildnumber>
98+
// gradle-tooling-extension isn't released with major intellij versions like intellij is
99+
// intellij.type is typically IC
100+
// build number is IC-number, so + 1 is needed to remove the -
101+
"gradle-tooling-extension"("com.jetbrains.intellij.gradle:gradle-tooling-extension:${intellij.ideaDependency.buildNumber.substring(intellij.type.length + 1)}")
102+
}
103+
} else {
104+
"gradle-tooling-extension"("com.jetbrains.intellij.gradle:gradle-tooling-extension:$ideaVersion")
105+
}
93106
}
94107

95108
intellij {

src/main/kotlin/com/demonwav/mcdev/nbt/lang/format/NbttLanguageCodeStyleSettingsProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*
44
* https://minecraftdev.org
55
*
6-
* Copyright (c) 2017 minecraft-dev
6+
* Copyright (c) 2018 minecraft-dev
77
*
88
* MIT License
99
*/

src/main/kotlin/com/demonwav/mcdev/platform/mixin/action/FindMixinsAction.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ class FindMixinsAction : AnAction() {
3939
private const val TOOL_WINDOW_ID = "Find Mixins"
4040
}
4141

42-
override fun actionPerformed(e: AnActionEvent?) {
43-
val project = e!!.getData(PROJECT) ?: return
42+
override fun actionPerformed(e: AnActionEvent) {
43+
val project = e.getData(PROJECT) ?: return
4444
val file = e.getData(PSI_FILE) ?: return
4545
val caret = e.getData(CARET) ?: return
4646
val editor = e.getData(EDITOR) ?: return

0 commit comments

Comments
 (0)