Fix some stuff, hopefully fixes #330

Author: DenWav

src/main/kotlin/com/demonwav/mcdev/facet/MinecraftFacet.kt

@@ -184,10 +184,10 @@ class MinecraftFacet(module: Module, name: String, configuration: MinecraftFacet
 
     val icon: Icon?
         get() {
-            val iconCount = moduleMap.keys.count { it.hasIcon() }
+            val iconCount = moduleMap.keys.count { it.hasIcon }
             return when {
                 iconCount == 0 -> null
-                iconCount == 1 -> moduleMap.keys.firstOrNull { it.hasIcon() }?.icon
+                iconCount == 1 -> moduleMap.keys.firstOrNull { it.hasIcon }?.icon
                 iconCount == 2 && moduleMap.containsAllKeys(SpongeModuleType, ForgeModuleType) -> PlatformAssets.SPONGE_FORGE_ICON
                 moduleMap.size > 0 -> PlatformAssets.MINECRAFT_ICON
                 else -> null

src/main/kotlin/com/demonwav/mcdev/platform/AbstractModuleType.kt

@@ -30,25 +30,18 @@ abstract class AbstractModuleType<out T : AbstractModule>(val groupId: String, v
 
     val colorMap = LinkedHashMap<String, Color>()
 
-    @get:Contract(pure = true)
     abstract val platformType: PlatformType
 
-    @get:Contract(pure = true)
     abstract val icon: Icon?
 
-    @Contract(pure = true)
-    open fun hasIcon() = true
+    open val hasIcon = true
 
-    @get:Contract(pure = true)
     abstract val id: String
 
-    @get:Contract(pure = true)
     abstract val ignoredAnnotations: List<String>
 
-    @get:Contract(pure = true)
     abstract val listenerAnnotations: List<String>
 
-    @get:Contract(pure = true)
     val classToColorMappings: Map<String, Color>
         get() = this.colorMap
 

src/main/kotlin/com/demonwav/mcdev/platform/BaseTemplate.kt

@@ -22,6 +22,8 @@ import java.util.Properties
 
 object BaseTemplate {
 
+    private val NEW_LINE = "\\n+".toRegex()
+
     fun applyBuildGradleTemplate(project: Project,
                                  file: VirtualFile,
                                  groupId: String,
@@ -112,7 +114,7 @@ object BaseTemplate {
 
         var text = template.getText(allProperties)
         if (trimNewlines) {
-            text = text.replace("\\n+".toRegex(), "\n")
+            text = text.replace(NEW_LINE, "\n")
         }
         VfsUtil.saveText(file, text)
 

src/main/kotlin/com/demonwav/mcdev/platform/forge/ForgeTemplate.kt

@@ -104,12 +104,12 @@ object ForgeTemplate {
         properties.setProperty("URL", url)
         properties.setProperty("UPDATE_URL", updateUrl)
 
-        if (authorList != null) {
+        if (!authorList.isNullOrBlank()) {
             properties.setProperty("HAS_AUTHOR_LIST", "true")
             properties.setProperty("AUTHOR_LIST", authorList)
         }
 
-        if (dependenciesList != null) {
+        if (!dependenciesList.isNullOrBlank()) {
             properties.setProperty("HAS_DEPENDENCIES_LIST", "true")
             properties.setProperty("DEPENDENCIES_LIST", dependenciesList)
         }

src/main/kotlin/com/demonwav/mcdev/platform/mcp/McpModuleType.kt

@@ -29,7 +29,7 @@ object McpModuleType : AbstractModuleType<McpModule>("", "") {
     override val id = ID
     override val ignoredAnnotations = emptyList<String>()
     override val listenerAnnotations = emptyList<String>()
+    override val hasIcon = false
 
     override fun generateModule(facet: MinecraftFacet) = McpModule(facet)
-    override fun hasIcon() = false
 }

src/main/kotlin/com/demonwav/mcdev/platform/mixin/MixinModuleType.kt

@@ -23,7 +23,7 @@ object MixinModuleType : AbstractModuleType<MixinModule>("org.spongepowered", "m
     override val id = ID
     override val ignoredAnnotations = emptyList<String>()
     override val listenerAnnotations = emptyList<String>()
+    override val hasIcon = false
 
-    override fun hasIcon() = false
     override fun generateModule(facet: MinecraftFacet) = MixinModule(facet)
 }