Make usesSrgMemberNames return Boolean?

Author: RedNesto

src/main/kotlin/platform/mcp/actions/CopyNeoForgeAtAction.kt

@@ -49,7 +49,7 @@ class CopyNeoForgeAtAction : AnAction() {
 
     private fun isAvailable(e: AnActionEvent): Boolean {
         val data = getDataFromActionEvent(e) ?: return false
-        return !data.instance.usesSrgMemberNames()
+        return data.instance.usesSrgMemberNames() == false
     }
 
     override fun actionPerformed(e: AnActionEvent) {

src/main/kotlin/platform/mcp/at/AtReferenceContributor.kt

@@ -175,7 +175,7 @@ abstract class AtClassMemberReference<E : AtElement>(element: E, range: TextRang
 
         val module = element.findModule() ?: return ArrayUtil.EMPTY_OBJECT_ARRAY
         val instance = MinecraftFacet.getInstance(module) ?: return ArrayUtil.EMPTY_OBJECT_ARRAY
-        val useSrg = instance.usesSrgMemberNames()
+        val useSrg = instance.usesSrgMemberNames() == true
         val (mapField, mapMethod) = if (!useSrg) {
             { it: PsiField -> it.memberReference } to { it: PsiMethod -> it.memberReference }
         } else {
@@ -234,7 +234,7 @@ class AtFieldNameReference(element: AtFieldName) :
         val instance = MinecraftFacet.getInstance(module) ?: return null
         val mcpModule = instance.getModuleOfType(McpModuleType) ?: return null
 
-        return if (!instance.usesSrgMemberNames()) {
+        return if (instance.usesSrgMemberNames() != true) {
             entryClass.findFieldByName(element.text, false)
         } else {
             val srgMap = mcpModule.mappingsManager?.mappingsNow ?: return null
@@ -272,7 +272,7 @@ class AtFuncNameReference(element: AtFunction) :
         val instance = MinecraftFacet.getInstance(module) ?: return null
         val mcpModule = instance.getModuleOfType(McpModuleType) ?: return null
 
-        return if (!instance.usesSrgMemberNames()) {
+        return if (instance.usesSrgMemberNames() != true) {
             val memberReference = MemberReference.parse(element.text) ?: return null
             entryClass.findMethods(memberReference).firstOrNull()
         } else {

src/main/kotlin/platform/mcp/at/at-utils.kt

@@ -21,17 +21,18 @@
 package com.demonwav.mcdev.platform.mcp.at
 
 import com.demonwav.mcdev.facet.MinecraftFacet
+import com.demonwav.mcdev.platform.forge.ForgeModuleType
 import com.demonwav.mcdev.platform.mcp.McpModuleType
 import com.demonwav.mcdev.platform.neoforge.NeoForgeModuleType
 import com.demonwav.mcdev.util.MinecraftVersions
 import com.demonwav.mcdev.util.SemanticVersion
 
-fun MinecraftFacet.usesSrgMemberNames(): Boolean {
+fun MinecraftFacet.usesSrgMemberNames(): Boolean? {
     if (!this.isOfType(NeoForgeModuleType)) {
-        return true
+        return this.isOfType(ForgeModuleType)
     }
 
-    val mcpModule = this.getModuleOfType(McpModuleType) ?: return true
-    val mcVersion = mcpModule.getSettings().minecraftVersion?.let(SemanticVersion::tryParse) ?: return true
+    val mcpModule = this.getModuleOfType(McpModuleType) ?: return null
+    val mcVersion = mcpModule.getSettings().minecraftVersion?.let(SemanticVersion::tryParse) ?: return null
     return mcVersion < MinecraftVersions.MC1_20_2
 }