Implement duplicate issue detection

Author: DenWav

build.gradle.kts

@@ -91,7 +91,7 @@ java {
     }
 }
 
-val gradleToolingExtension = java().sourceSets["gradle-tooling-extension"]
+val gradleToolingExtension = java().sourceSets["gradle-tooling-extension"]!!
 val gradleToolingExtensionJar = task<Jar>(gradleToolingExtension.jarTaskName) {
     from(gradleToolingExtension.output)
     classifier = "gradle-tooling-extension"

src/main/kotlin/com/demonwav/mcdev/buildsystem/gradle/GradleBuildSystem.kt

@@ -220,15 +220,15 @@ class GradleBuildSystem : BuildSystem() {
     }
 
     private fun createRepositoriesOrDependencies(project: Project, file: GroovyFile, name: String, expressions: List<String>) {
-        // Ge the block so we can start working with it
+        // Get the block so we can start working with it
         val block = getClosableBlockByName(file, name) ?: return
 
         // Create a super expression with all the expressions tied together
         val expressionText = expressions.joinToString("\n")
 
         // We can't create each expression and add them to the file...that won't work. Groovy requires a new line
         // from one method call expression to another, and there's no way to (easily) put whitespace in Psi because Psi is
-        // stupid. So instead we make hte whole thing as one big clump and insert it into the block.
+        // stupid. So instead we make the whole thing as one big clump and insert it into the block.
         val fakeFile = GroovyPsiElementFactory.getInstance(project).createGroovyFile(expressionText, false, null)
         val last = block.children.last()
         block.addBefore(fakeFile, last)

src/main/kotlin/com/demonwav/mcdev/error/AnonymousFeedback.kt

@@ -92,7 +92,7 @@ object AnonymousFeedback {
         }
 
         val json = Gson().fromJson<Map<*, *>>(body)
-        return json["html_url"] as String to (json["id"] as Double).toInt()
+        return json["html_url"] as String to (json["number"] as Double).toInt()
     }
 
     private fun connect(factory: HttpConnectionFactory, url: String): HttpURLConnection {
@@ -103,20 +103,25 @@ object AnonymousFeedback {
     }
 
     private fun findDuplicateIssue(envDetails: LinkedHashMap<String, String?>): Int? {
-        val stack = envDetails["error.stacktrace"] ?: return null
+        val stack = envDetails["error.stacktrace"]?.replace("\\d+".toRegex(), "") ?: return null
 
-        val text = URL("https://api.github.com/repos/minecraft-dev/MinecraftDev/issues").readText()
+        val text = URL("https://api.github.com/repos/minecraft-dev/MinecraftDev/issues?state=all&creator=minecraft-dev-autoreporter").readText()
         val list = Gson().fromJson<List<Map<*, *>>>(text)
         val block = list.firstOrNull {
             val body = it["body"] as? String ?: return@firstOrNull false
 
+            // We can't comment on locked issues
+            if (it["locked"] as Boolean) {
+                return@firstOrNull false
+            }
+
             val first = body.indexOf("\n```\n", startIndex = 0) + 5
             val second = body.indexOf("\n```\n", startIndex = first)
             val stackText = body.substring(first, second)
 
-            stackText == stack
+            stackText.replace("\\d+".toRegex(), "") == stack
         } ?: return null
-        return (block["id"] as Double).toInt()
+        return (block["number"] as Double).toInt()
     }
 
     private fun sendCommentOnDuplicateIssue(id: Int, factory: HttpConnectionFactory, payload: ByteArray): String {
@@ -160,8 +165,6 @@ object AnonymousFeedback {
     }
 
     open class HttpConnectionFactory {
-        open fun openHttpConnection(url: String): HttpURLConnection {
-            return URL(url).openConnection() as HttpURLConnection
-        }
+        open fun openHttpConnection(url: String) = URL(url).openConnection() as HttpURLConnection
     }
 }

src/main/kotlin/com/demonwav/mcdev/error/AnonymousFeedbackTask.kt

@@ -14,7 +14,6 @@ import com.intellij.openapi.progress.ProgressIndicator
 import com.intellij.openapi.progress.Task
 import com.intellij.openapi.project.Project
 import com.intellij.util.net.HttpConfigurable
-import java.net.HttpURLConnection
 
 class AnonymousFeedbackTask(
     project: Project?,
@@ -37,8 +36,6 @@ class AnonymousFeedbackTask(
     }
 
     private inner class ProxyHttpConnectionFactory : AnonymousFeedback.HttpConnectionFactory() {
-        override fun openHttpConnection(url: String): HttpURLConnection {
-            return HttpConfigurable.getInstance().openHttpConnection(url)
-        }
+        override fun openHttpConnection(url: String) = HttpConfigurable.getInstance().openHttpConnection(url)
     }
 }

src/main/kotlin/com/demonwav/mcdev/error/ErrorReporter.kt

@@ -31,7 +31,7 @@ import com.intellij.util.Consumer
 import java.awt.Component
 
 class ErrorReporter : ErrorReportSubmitter() {
-    val baseUrl = "https://github.com/minecraft-dev/MinecraftDev/issues"
+    private val baseUrl = "https://github.com/minecraft-dev/MinecraftDev/issues"
     override fun getReportActionText() = "Report to Minecraft Dev GitHub Issue Tracker"
 
     override fun submit(events: Array<out IdeaLoggingEvent>,
@@ -73,11 +73,11 @@ class ErrorReporter : ErrorReportSubmitter() {
             consumer.consume(reportInfo)
 
             val message = if (!isDuplicate) {
-                "<html>Created Issue #$token successfully.<br>" +
+                "<html>Created Issue #$token successfully. " +
                     "<a href=\"$htmlUrl\">View issue.</a></html>"
             } else {
-                "<html>Commented on existing Issue #$token successfully.<br>" +
-                    "<a href=\"$htmlUrl\" View issue.</a></html>"
+                "<html>Commented on existing Issue #$token successfully. " +
+                    "<a href=\"$htmlUrl\">View comment.</a></html>"
             }
 
             ReportMessages.GROUP.createNotification(

src/main/kotlin/com/demonwav/mcdev/facet/MinecraftFacet.kt

@@ -133,9 +133,8 @@ class MinecraftFacet(module: Module, name: String, configuration: MinecraftFacet
     }
 
     @Contract(value = "null -> false", pure = true)
-    fun isEventClassValidForModule(eventClass: PsiClass?): Boolean {
-        return eventClass != null && modules.values.any { it.isEventClassValid(eventClass, null) }
-    }
+    fun isEventClassValidForModule(eventClass: PsiClass?) =
+        eventClass != null && modules.values.any { it.isEventClassValid(eventClass, null) }
 
     @Contract(pure = true)
     fun isEventClassValid(eventClass: PsiClass, method: PsiMethod): Boolean {