Skip to content

Commit 22b4726

Browse files
committed
Fix Mixin breakpoints no longer working
Gradle run configs like FG3 mods ones do not execute the extension's #attachToProcess method, thus preventing MixinPositionManagerFactory from creating the PositionManager for the debugged process The easiest solution is to simply remove the need for the extension and always return a MixinPositionManager. I do not think this can cause any issue, and the Groovy plugin does that for instance
1 parent c39e343 commit 22b4726

File tree

4 files changed

+1
-53
lines changed

4 files changed

+1
-53
lines changed

src/main/kotlin/com/demonwav/mcdev/platform/mixin/debug/MixinDebug.kt

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/main/kotlin/com/demonwav/mcdev/platform/mixin/debug/MixinPositionManagerFactory.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,5 @@ import com.intellij.debugger.engine.DebugProcess
1616

1717
class MixinPositionManagerFactory : PositionManagerFactory() {
1818

19-
override fun createPositionManager(process: DebugProcess): PositionManager? {
20-
return if (process.processHandler.hasMixinDebugKey()) {
21-
MixinPositionManager(process)
22-
} else {
23-
null
24-
}
25-
}
19+
override fun createPositionManager(process: DebugProcess): PositionManager? = MixinPositionManager(process)
2620
}

src/main/kotlin/com/demonwav/mcdev/platform/mixin/debug/MixinRunConfigurationExtension.kt

Lines changed: 0 additions & 27 deletions
This file was deleted.

src/main/resources/META-INF/plugin.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@
268268

269269
<customJavadocTagProvider implementation="com.demonwav.mcdev.platform.mixin.MixinCustomJavaDocTagProvider"/>
270270

271-
<runConfigurationExtension implementation="com.demonwav.mcdev.platform.mixin.debug.MixinRunConfigurationExtension"/>
272271
<debugger.positionManagerFactory implementation="com.demonwav.mcdev.platform.mixin.debug.MixinPositionManagerFactory"/>
273272
<debuggerClassFilterProvider implementation="com.demonwav.mcdev.platform.mixin.debug.MixinDebuggerClassFilterProvider"/>
274273

0 commit comments

Comments
 (0)