Add description to sql skill

Author: tmichaeldb

mindsdb_sdk/skills.py

@@ -51,18 +51,19 @@ def __repr__(self):
     @classmethod
     def from_json(cls, json: dict):
         if json['type'] == 'sql':
-            return SQLSkill(json['name'], json['params']['tables'], json['params']['database'])
+            return SQLSkill(json['name'], json['params']['tables'], json['params']['database'], json['params']['description'])
         if json['type'] == 'retrieval':
             return RetrievalSkill(json['name'], json['params']['source'], json['params']['description'])
         return Skill(json['name'], json['type'], json['params'])
 
 
 class SQLSkill(Skill):
     """Represents a MindsDB skill for agents to interact with MindsDB databases"""
-    def __init__(self, name: str, tables: List[str], database: str):
+    def __init__(self, name: str, tables: List[str], database: str, description: str):
         params = {
             'database': database,
             'tables': tables,
+            'description': description
         }
         super().__init__(name, 'sql', params)
 
@@ -114,7 +115,7 @@ def create(self, name: str, type: str, params: dict = None) -> Skill:
         """
         _ = self.api.create_skill(self.project, name, type, params)
         if type == 'sql':
-            return SQLSkill(name, params['tables'], params['database'])
+            return SQLSkill(name, params['tables'], params['database'], params['description'])
         return Skill(name, type, params)
 
     def update(self, name: str, updated_skill: Skill) -> Skill:

tests/test_sdk.py

@@ -1277,7 +1277,7 @@ def test_create(self, mock_post):
         new_agent = server.agents.create(
             name='test_agent',
             model=Model(None, {'name':'m1'}),
-            skills=[SQLSkill('test_skill', ['test_table'], 'test_database')],
+            skills=[SQLSkill('test_skill', ['test_table'], 'test_database'), 'test_description'],
             params={'k1': 'v1'}
         )
         # Check API call.
@@ -1302,7 +1302,7 @@ def test_create(self, mock_post):
             }
         }
 
-        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database')
+        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database', 'test_descrition')
         expected_agent = Agent(
             'test_agent',
             'test_model',
@@ -1354,7 +1354,7 @@ def test_update(self, mock_get, mock_put, _):
         expected_agent = Agent(
             'test_agent',
             'updated_model',
-            [SQLSkill('updated_skill', ['updated_table'], 'updated_database')],
+            [SQLSkill('updated_skill', ['updated_table'], 'updated_database', 'test_description')],
             {'k2': 'v2'},
             created_at,
             updated_at
@@ -1429,7 +1429,7 @@ def test_list(self, mock_get):
         all_skills = server.skills.list()
         assert len(all_skills) == 1
 
-        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database')
+        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database', 'test_description')
         assert all_skills[0] == expected_skill
 
     @patch('requests.Session.get')
@@ -1447,7 +1447,7 @@ def test_get(self, mock_get):
         skill = server.skills.get('test_skill')
         # Check API call.
         assert mock_get.call_args[0][0] == f'{DEFAULT_LOCAL_API_URL}/api/projects/mindsdb/skills/test_skill'
-        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database')
+        expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database', 'test_description')
         assert skill == expected_skill
 
     @patch('requests.Session.post')
@@ -1493,7 +1493,7 @@ def test_update(self, mock_put):
         response_mock(mock_put, data)
 
         server = mindsdb_sdk.connect()
-        expected_skill = SQLSkill('test_skill', ['updated_table'], 'updated_database')
+        expected_skill = SQLSkill('test_skill', ['updated_table'], 'updated_database', 'test_description')
 
         updated_skill = server.skills.update('test_skill', expected_skill)
         # Check API call.