Skip to content

Commit 9a2cc5a

Browse files
committed
remove 'Database is not defined' on 'create model'
1 parent 1ca5c89 commit 9a2cc5a

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

mindsdb_sdk/models.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,6 @@ def create(
463463
targets = [Identifier(predict)]
464464
else:
465465
targets = None
466-
if database is None:
467-
raise RuntimeError('Database is not defined')
468466

469467
ast_query = CreatePredictor(
470468
name=Identifier(name),

tests/test_sdk.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,19 @@ def check_project_models(self, project, database, mock_post):
844844
f'CREATE PREDICTOR m2 FROM {database.name} (select * from t2) PREDICT price'
845845
)
846846

847+
# create without database
848+
model = project.models.create(
849+
'm2',
850+
predict='response',
851+
engine='openai',
852+
options={'prompt': 'make up response'},
853+
)
854+
855+
check_sql_call(
856+
mock_post,
857+
f'CREATE PREDICTOR m2 PREDICT response USING prompt="make up response", `engine`="openai"'
858+
)
859+
847860
assert model.name == 'm2'
848861
self.check_model(model, database)
849862

0 commit comments

Comments
 (0)