Skip to content

Commit 14ca3cc

Browse files
authored
Merge pull request #94 from mindsdb/staging
Release 2.1.1
2 parents df9a9f1 + a961d90 commit 14ca3cc

File tree

6 files changed

+17
-7
lines changed

6 files changed

+17
-7
lines changed

docs/source/server.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,3 @@ Server
55
:members:
66
:undoc-members:
77
:show-inheritance:
8-
9-
10-
:ref:`jobs<Jobs>`

mindsdb_sdk/__about__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
__title__ = 'mindsdb_sdk'
22
__package_name__ = 'mindsdb_sdk'
3-
__version__ = '2.1.0'
3+
__version__ = '2.1.1'
44
__description__ = "MindsDB Python SDK, provides an SDK to use a remote mindsdb instance"
55
__email__ = "jorge@mindsdb.com"
66
__author__ = 'MindsDB Inc'

mindsdb_sdk/ml_engines.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ class MLEngines(CollectionBase):
4545
4646
>>> con.ml_engines.drop('openai1')
4747
48-
Upload BYOM model. After uploading a new ml engin will be availbe to create new model from it.
48+
Upload BYOM model.
49+
After uploading a new ml engin will be availbe to create new model from it.
4950
5051
>>> model_code = open('/path/to/model/code').read()
5152
>>> model_requirements = open('/path/to/model/requirements').read()

mindsdb_sdk/models.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,6 @@ def create(
463463
targets = [Identifier(predict)]
464464
else:
465465
targets = None
466-
if database is None:
467-
raise RuntimeError('Database is not defined')
468466

469467
ast_query = CreatePredictor(
470468
name=Identifier(name),

mindsdb_sdk/server.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def status(self) -> dict:
5252
"""
5353
Get server information. It could content version
5454
Example of getting version for local:
55+
5556
>>> print(server.status()['mindsdb_version'])
5657
5758
:return: server status info

tests/test_sdk.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,19 @@ def check_project_models(self, project, database, mock_post):
844844
f'CREATE PREDICTOR m2 FROM {database.name} (select * from t2) PREDICT price'
845845
)
846846

847+
# create without database
848+
model = project.models.create(
849+
'm2',
850+
predict='response',
851+
engine='openai',
852+
options={'prompt': 'make up response'},
853+
)
854+
855+
check_sql_call(
856+
mock_post,
857+
f'CREATE PREDICTOR m2 PREDICT response USING prompt="make up response", `engine`="openai"'
858+
)
859+
847860
assert model.name == 'm2'
848861
self.check_model(model, database)
849862

0 commit comments

Comments
 (0)