Skip to content

Commit 0eaec59

Browse files
committed
pr fixes
1 parent fc4f59c commit 0eaec59

File tree

2 files changed

+32
-8
lines changed

2 files changed

+32
-8
lines changed

mindsdb_sdk/jobs.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ def __repr__(self):
3838

3939
def __enter__(self):
4040
if self._create_callback is None:
41-
raise RuntimeError('It can not be used to create context')
41+
raise ValueError("The job is already created and can't be used to create context."
42+
" To be able to use context: create job without 'query_str' parameter: "
43+
"\n>>> with con.jobs.create('j1') as job:"
44+
"\n>>> job.add_query(...)")
4245
set_saving(f'job-{self.name}')
4346

4447
return self
@@ -47,7 +50,7 @@ def __exit__(self, type, value, traceback):
4750
set_saving(None)
4851
if type is None:
4952
if len(self._queries) == 0:
50-
raise RuntimeError('No queries were added to job')
53+
raise ValueError('No queries were added to job')
5154

5255
query_str = '; '.join(self._queries)
5356

@@ -79,7 +82,7 @@ def add_query(self, query: Union[Query, str]):
7982

8083
query = query.sql
8184
elif not isinstance(query, str):
82-
raise RuntimeError(f'Unable to use add this object as a query: {query}. Try to use sql string instead')
85+
raise ValueError(f'Unable to use add this object as a query: {query}. Try to use sql string instead')
8386
self._queries.append(query)
8487

8588
def get_history(self) -> pd.DataFrame:
@@ -164,7 +167,7 @@ def create(
164167
Usage options:
165168
166169
Option 1: to use string query
167-
All job tasks could be passed as string with sql queries. Job is created emmideiately
170+
All job tasks could be passed as string with sql queries. Job is created immediately
168171
169172
>>> job = con.jobs.create('j1', query_str='retrain m1; show models', repeat_min=1):
170173

mindsdb_sdk/utils/context.py

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,44 @@
33
context_storage = ContextVar('create_context')
44

55

6-
def set_context(name, value):
6+
def set_context(name: str, value: str):
7+
"""
8+
Set context value to variable
9+
10+
:param name: variable name
11+
:param value: variable value
12+
"""
713
data = context_storage.get({})
814
data[name] = value
915

1016
context_storage.set(data)
1117

1218

13-
def get_context(name):
19+
def get_context(name: str) -> str:
20+
"""
21+
Get context value fom variable
22+
23+
:param name: variable name
24+
:return: variable value
25+
"""
1426

1527
data = context_storage.get({})
1628
return data.get(name)
1729

1830

19-
def set_saving(name):
31+
def set_saving(name: str):
32+
"""
33+
Set name of saving object to context
34+
35+
:param name: namve of the object
36+
"""
2037
set_context('saving', name)
2138

2239

23-
def is_saving():
40+
def is_saving() -> bool:
41+
"""
42+
Returns true if object is saved at the moment
43+
"""
44+
2445
return get_context('saving') is not None
2546

0 commit comments

Comments
 (0)