Skip to content

Commit 0deccd3

Browse files
committed
improve test coverage
1 parent c051c47 commit 0deccd3

File tree

2 files changed

+24
-7
lines changed

2 files changed

+24
-7
lines changed

mindsdb_sdk/server.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ class Server(Project):
2323
2424
"""
2525

26-
def a(self):
27-
...
28-
2926
def __init__(self, api):
3027
# server is also mindsdb project
3128
super().__init__(api, 'mindsdb')

tests/test_sdk.py

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,16 +126,16 @@ def check_model(self, model, database, mock_post):
126126
f'Finetune {model.project.name}.{model_name} FROM d1 (select a from t1)'
127127
)
128128

129-
model.retrain(query, options={ 'x': 2 })
129+
model.retrain(query, options={'x': 2})
130130
check_sql_call(
131131
mock_post,
132132
f'RETRAIN {model.project.name}.{model_name} FROM {query.database} ({query.sql}) USING x=2'
133133
)
134134

135-
model.retrain('select a from t1', database='d1')
135+
model.retrain('select a from t1', database='d1', engine='openai')
136136
check_sql_call(
137137
mock_post,
138-
f'RETRAIN {model.project.name}.{model_name} FROM d1 (select a from t1)'
138+
f'RETRAIN {model.project.name}.{model_name} FROM d1 (select a from t1) USING engine=\'openai\''
139139
)
140140

141141
# describe
@@ -183,6 +183,7 @@ class Test(BaseFlow):
183183
def test_flow(self, mock_post, mock_put):
184184
# check local
185185
server = mindsdb_sdk.connect()
186+
str(server)
186187

187188
assert server.api.url == 'http://127.0.0.1:47334'
188189

@@ -606,6 +607,7 @@ def test_flow(self, mock_post, mock_put):
606607
self.check_project(project, database)
607608

608609
project = con.projects.create('proj1')
610+
str(project)
609611
check_sql_call(
610612
mock_post, 'CREATE DATABASE proj1 WITH ENGINE = "mindsdb", PARAMETERS = {}')
611613
self.check_project(project, database)
@@ -762,6 +764,7 @@ def check_project_models(self, project, database, mock_post):
762764

763765
models = project.models.list()
764766
model = models[0] # Model object
767+
str(model)
765768

766769
assert model.name == 'm1'
767770
assert model.get_status() == 'complete'
@@ -791,7 +794,7 @@ def check_project_models(self, project, database, mock_post):
791794
'window': 10,
792795
'horizon': 2
793796
},
794-
module = 'LightGBM', # has to be in options
797+
module='LightGBM', # has to be in options
795798
)
796799
check_sql_call(
797800
mock_post,
@@ -911,6 +914,11 @@ def check_database(self, database, mock_post):
911914
table2 = database.tables.create('t2', query)
912915
check_sql_call(mock_post, f'create table {database.name}.t2 (select * from tbl1)')
913916

917+
# create with replace
918+
database.tables.create('t2', query, replace=True)
919+
check_sql_call(mock_post, f'create or replace table {database.name}.t2 (select * from tbl1)')
920+
921+
914922
assert table2.name == 't2'
915923
self.check_table(table2)
916924

@@ -969,6 +977,7 @@ def check_project_jobs(self, project, mock_post):
969977
assert job.name == 'job1'
970978
assert job.query_str == 'select 1'
971979

980+
dir(project.jobs)
972981
job = project.jobs.job1
973982
str(job)
974983
assert job.name == 'job1'
@@ -1001,6 +1010,17 @@ def check_project_jobs(self, project, mock_post):
10011010
call_stack_num=-2
10021011
)
10031012

1013+
project.jobs.create(
1014+
name='job2',
1015+
query_str='retrain m1'
1016+
)
1017+
1018+
check_sql_call(
1019+
mock_post,
1020+
f"CREATE JOB job2 (retrain m1)",
1021+
call_stack_num=-2
1022+
)
1023+
10041024
project.jobs.drop('job2')
10051025

10061026
check_sql_call(

0 commit comments

Comments
 (0)