Create timestamped subdirectories for logs #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
mikemccand
reviewed
Nov 18, 2025
src/python/benchUtil.py
Outdated
|
|
||
| # Create timestamped log subdirectory to avoid conflicts between runs | ||
| now = datetime.datetime.now() | ||
| timeStamp = "%04d.%02d.%02d.%02d.%02d.%02d" % (now.year, now.month, now.day, now.hour, now.minute, now.second) |
Owner
There was a problem hiding this comment.
I asked Claude to change this fragment to use strftime instead:
now = datetime.datetime.now()
timeStamp = now.strftime("%Y.%m.%d.%H.%M.%S")
https://claude.ai/share/a8042a55-733f-4c9e-91f3-b8c2d71c3bad
A bit more compact maybe :)
Contributor
Author
There was a problem hiding this comment.
Sure let me update this change.
Contributor
Author
There was a problem hiding this comment.
Updated in my latest commit, please check.
mikemccand
approved these changes
Nov 18, 2025
Owner
mikemccand
left a comment
mikemccand
left a comment
There was a problem hiding this comment.
Looks like a good first step -- we can baby-step any other log files? Need not be draft?
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
jainankitk
approved these changes
Nov 18, 2025
Collaborator
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Thanks @prudhvigodithi for fixing this annoying issue!
Collaborator
|
@prudhvigodithi - You might need to run |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Contributor
Author
Thanks just pushed with the formats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve #381
(Initially coming from apache/lucene#15383)