WIP - increase coverage

Author: mikebronner

src/Builder.php

@@ -20,15 +20,10 @@ protected function cache(array $tags = [])
         return $cache;
     }
 
-    protected function getCacheKey(array $columns = ['*'], $ids = null) : string
+    protected function getCacheKey(array $columns = ['*'], $idColumn = null) : string
     {
         $key = str_slug(get_class($this->model));
-
-        if ($ids) {
-            $key .= '_' . (is_array($ids)
-                ? implode('_', $ids)
-                : $ids);
-        }
+        $key .= $idColumn ? "_{$idColumn}" : '';
 
         if ($columns !== ['*']) {
             $key .= '_' . implode('_', $columns);

tests/Unit/CachedBuilderTest.php

@@ -351,8 +351,8 @@ public function testMinModelResultsCreatesCache()
     public function testPluckModelResultsCreatesCache()
     {
         $authors = (new Author)->with('books', 'profile')
-            ->pluck('id');
-        $key = 'genealabslaravelmodelcachingtestsfixturesauthor_id-books-profile-pluck_id';
+            ->pluck('name', 'id');
+        $key = 'genealabslaravelmodelcachingtestsfixturesauthor_name-books-profile-pluck_name_id';
         $tags = [
             'genealabslaravelmodelcachingtestsfixturesauthor',
             'genealabslaravelmodelcachingtestsfixturesbook',
@@ -362,7 +362,7 @@ public function testPluckModelResultsCreatesCache()
         $cachedResults = cache()->tags($tags)
             ->get($key);
         $liveResults = (new UncachedAuthor)->with('books', 'profile')
-            ->pluck('id');
+            ->pluck('name', 'id');
 
         $this->assertEmpty($authors->diffAssoc($cachedResults));
         $this->assertEmpty($liveResults->diffAssoc($cachedResults));