Fix tests to use relationship to create record

Author: mikebronner

src/CacheKey.php

@@ -39,7 +39,7 @@ public function make(
         $key .= $this->getOffsetClause();
         $key .= $this->getLimitClause();
         $key .= $keyDifferentiator;
-dump("key", $key);
+
         return $key;
     }
 

src/Traits/ModelCaching.php

@@ -37,9 +37,10 @@ public static function bootCachable()
             $instance->checkCooldownAndFlushAfterPersiting($instance);
         });
 
-        static::restored(function ($instance) {
-            $instance->checkCooldownAndFlushAfterPersiting($instance);
-        });
+        // TODO: figure out how to add this listener
+        // static::restored(function ($instance) {
+        //     $instance->checkCooldownAndFlushAfterPersiting($instance);
+        // });
 
         static::pivotAttached(function ($instance) {
             $instance->checkCooldownAndFlushAfterPersiting($instance);

tests/Integration/CachedBuilder/WithCountTest.php

@@ -42,21 +42,16 @@ public function testWithCountUpdatesAfterRecordIsAdded()
         $this->assertEquals($author1->books_count + 1, $author2->books_count);
     }
 
-    /** @group test */
     public function testWithCountOnMorphManyRelationshipUpdatesAfterRecordIsAdded()
     {
         $book1 = (new Book)
             ->withCount("comments")
             ->first();
-        dump("start");
-        factory(Comment::class, 1)
-            ->make()
-            ->each(function ($comment) use ($book1) {
-                $comment->commentable_id = $book1->id;
-                $comment->commentable_type = $book1->getTable();
-                $comment->save();
-            });
-        dump("end");
+        $comment = factory(Comment::class, 1)
+            ->create()
+            ->first();
+
+        $book1->comments()->save($comment);
 
         $book2 = (new Book)
             ->withCount("comments")

tests/database/migrations/2018_06_03_202000_create_comments.php

@@ -11,8 +11,8 @@ public function up()
             $table->increments('id');
             $table->timestamps();
 
-            $table->unsignedInteger("commentable_id");
-            $table->string("commentable_type");
+            $table->unsignedInteger("commentable_id")->nullable();
+            $table->string("commentable_type")->nullable();
             $table->text("description");
             $table->string("subject");
         });