Add error examples

Author: Mike Bridge

Liquid.NET.Tests/Examples/ExampleTests.cs

@@ -18,9 +18,9 @@ public void Test_Simple_Template()
 
             ctx.DefineLocalVariable("myvariable", LiquidString.Create("Hello World"));
 
-            var templateResult = LiquidTemplate.Create("<div>{{myvariable}}</div>");
+            var parsingResult = LiquidTemplate.Create("<div>{{myvariable}}</div>");
 
-            Assert.That(templateResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("<div>Hello World</div>"));
+            Assert.That(parsingResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("<div>Hello World</div>"));
 
         }
 
@@ -36,9 +36,9 @@ public void Test_Simple_Collection()
                 LiquidNumeric.Create(6)
             });
 
-            var templateResult = LiquidTemplate.Create("<ul>{% for item in items %}<li>{{item}}</li>{% endfor %}</ul>");
+            var parsingResult = LiquidTemplate.Create("<ul>{% for item in items %}<li>{{item}}</li>{% endfor %}</ul>");
 
-            Assert.That(templateResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("<ul><li>2</li><li>4</li><li>6</li></ul>"));
+            Assert.That(parsingResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("<ul><li>2</li><li>4</li><li>6</li></ul>"));
 
         }
 
@@ -58,9 +58,9 @@ public void Test_Simple_Hash()
                 {"name", nameHash}
             });
 
-            var templateResult = LiquidTemplate.Create("You said '{{ greeting.address }} {{ greeting.name.first }} {{ greeting.name.last }}'");
+            var parsingResult = LiquidTemplate.Create("You said '{{ greeting.address }} {{ greeting.name.first }} {{ greeting.name.last }}'");
 
-            Assert.That(templateResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("You said 'Hello Tobias Lütke'"));
+            Assert.That(parsingResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("You said 'Hello Tobias Lütke'"));
 
         }
 
@@ -72,23 +72,31 @@ public void Test_Filter()
                 .DefineLocalVariable("resultcount", LiquidNumeric.Create(42))
                 .DefineLocalVariable("searchterm", LiquidString.Create("MiXeDcAsE"));
 
-            var templateResult = LiquidTemplate.Create("{{ resultcount }} {{ resultcount | pluralize: 'item', 'items' }} were found for '{{searchterm | downcase}}'.");
+            var parsingResult = LiquidTemplate.Create("{{ resultcount }} {{ resultcount | pluralize: 'item', 'items' }} were found for '{{searchterm | downcase}}'.");
 
-            Assert.That(templateResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("42 items were found for 'mixedcase'."));
+            Assert.That(parsingResult.LiquidTemplate.Render(ctx).Result, Is.EqualTo("42 items were found for 'mixedcase'."));
 
         }
 
         [Test]
         public void Test_Parsing_Error()
         {
-            ITemplateContext ctx = new TemplateContext();
-            var templateResult = LiquidTemplate.Create("This tag delimiter is not terminated: {% .");
-            String error = String.Join(",", templateResult.ParsingErrors.Select(x => x.Message));
-            Console.WriteLine(error);
-            Assert.That(error, Is.StringContaining("no viable alternative at input"));
-            
+            var parsingResult = LiquidTemplate.Create("This filter delimiter is not terminated: {{ myfilter");            
+            String error = String.Join(",", parsingResult.ParsingErrors.Select(x => x.ToString()));
+            Assert.That(error, Is.StringContaining("line 1:52 at <EOF>: Missing '}}'"));            
         }
 
 
+        [Test]
+        public void Test_Rendering_Error()
+        {
+            ITemplateContext ctx = new TemplateContext().WithAllFilters();
+            var parsingResult = LiquidTemplate.Create("Divide by zero result in: {{ 1 | divided_by: 0}}");
+            var renderingResult = parsingResult.LiquidTemplate.Render(ctx);
+            String error = String.Join(",", renderingResult.RenderingErrors.Select(x => x.Message));
+            //Console.WriteLine("The ERROR was : " + error);
+            //Console.WriteLine("The RESULT was : " + renderingResult.Result);
+            Assert.That(error, Is.StringContaining("Liquid error: divided by 0"));
+        }
     }
 }

Liquid.NET/src/LiquidTemplate.cs

@@ -11,7 +11,6 @@ public class LiquidTemplate
 
         public static LiquidParsingResult Create(String template)
         {
-            LiquidTemplate result = null;
             IList<LiquidError> errors = new List<LiquidError>();
             var liquidAst = new LiquidASTGenerator().Generate(template, errors.Add);
             //if (errors.Any())
@@ -20,7 +19,7 @@ public static LiquidParsingResult Create(String template)
             //}
             //else
             //{
-                result = new LiquidTemplate(liquidAst);
+                var result = new LiquidTemplate(liquidAst);
             //}
             return LiquidParsingResult.Create(result, errors);
         }