More descriptive error when joining a room on a bad namespace (Fixes #650)

Author: miguelgrinberg

socketio/base_manager.py

@@ -103,6 +103,8 @@ def disconnect(self, sid, namespace):
 
     def enter_room(self, sid, namespace, room, eio_sid=None):
         """Add a client to a room."""
+        if eio_sid is None and namespace not in self.rooms:
+            raise ValueError('sid is not connected to requested namespace')
         if namespace not in self.rooms:
             self.rooms[namespace] = {}
         if room not in self.rooms[namespace]:

tests/common/test_base_manager.py

@@ -1,6 +1,8 @@
 import unittest
 from unittest import mock
 
+import pytest
+
 from socketio import base_manager
 
 
@@ -119,6 +121,11 @@ def test_disconnect_bad_namespace(self):
         self.bm.connect('123', '/foo')
         self.bm.disconnect('123', '/bar')  # should not assert
 
+    def test_enter_room_bad_namespace(self):
+        sid = self.bm.connect('123', '/')
+        with pytest.raises(ValueError):
+            self.bm.enter_room(sid, '/foo', 'bar')
+
     def test_trigger_callback(self):
         sid1 = self.bm.connect('123', '/')
         sid2 = self.bm.connect('123', '/foo')