correct handling of disconnects

fixes #227

Author: miguelgrinberg

socketio/asyncio_client.py

@@ -197,6 +197,7 @@ async def disconnect(self):
         await self._trigger_event('disconnect', namespace='/')
         await self._send_packet(packet.Packet(
             packet.DISCONNECT, namespace='/'))
+        await self.eio.disconnect(abort=True)
 
     def start_background_task(self, target, *args, **kwargs):
         """Start a background task using the appropriate async model.

socketio/client.py

@@ -293,6 +293,7 @@ def disconnect(self):
         self._trigger_event('disconnect', namespace='/')
         self._send_packet(packet.Packet(
             packet.DISCONNECT, namespace='/'))
+        self.eio.disconnect(abort=True)
 
     def transport(self):
         """Return the name of the transport used by the client.

tests/test_asyncio_client.py

@@ -262,13 +262,16 @@ def test_disconnect(self):
         c = asyncio_client.AsyncClient()
         c._trigger_event = AsyncMock()
         c._send_packet = AsyncMock()
+        c.eio = mock.MagicMock()
+        c.eio.disconnect = AsyncMock()
         _run(c.disconnect())
         c._trigger_event.mock.assert_called_once_with(
             'disconnect', namespace='/')
         self.assertEqual(c._send_packet.mock.call_count, 1)
         expected_packet = packet.Packet(packet.DISCONNECT, namespace='/')
         self.assertEqual(c._send_packet.mock.call_args_list[0][0][0].encode(),
                          expected_packet.encode())
+        c.eio.disconnect.mock.assert_called_once_with(abort=True)
 
     def test_disconnect_namespaces(self):
         c = asyncio_client.AsyncClient()

tests/test_client.py

@@ -336,12 +336,14 @@ def test_disconnect(self):
         c = client.Client()
         c._trigger_event = mock.MagicMock()
         c._send_packet = mock.MagicMock()
+        c.eio = mock.MagicMock()
         c.disconnect()
         c._trigger_event.assert_called_once_with('disconnect', namespace='/')
         self.assertEqual(c._send_packet.call_count, 1)
         expected_packet = packet.Packet(packet.DISCONNECT, namespace='/')
         self.assertEqual(c._send_packet.call_args_list[0][0][0].encode(),
                          expected_packet.encode())
+        c.eio.disconnect.assert_called_once_with(abort=True)
 
     def test_disconnect_namespaces(self):
         c = client.Client()