Merge branch 'dev' into release/3.0.5

Author: nikithauc

.github/workflows/ci_validation.yml

@@ -32,3 +32,10 @@ jobs:
 
     - name: Run unit tests
       run: npm test
+
+    - name: Verify ESM compatibility
+      if: matrix.node-version == '16.x'
+      working-directory: './test-esm'
+      run: |
+        npm ci
+        npm test

.gitignore

@@ -31,3 +31,5 @@ test/development/secrets.ts
 .idea/*
 
 testResult.xml
+
+test-esm/lib/*

.npmignore

@@ -2,4 +2,5 @@ src/
 scripts/
 design/
 changelogs/
-testResult.xml
+testResult.xml
+test-esm/

README.md

@@ -205,6 +205,11 @@ Please see the [contributing guidelines](CONTRIBUTING.md).
 -   [Microsoft Graph Toolkit: UI Components and Authentication Providers for Microsoft Graph](https://docs.microsoft.com/graph/toolkit/overview)
 -   [Office Dev Center](http://dev.office.com/)
 
+## Tips and Tricks
+
+- [Microsoft Graph SDK `n.call is not a function` by Lee Ford](https://www.lee-ford.co.uk/posts/graph-sdk-is-not-a-function/)
+- [Example of using the Graph JS library with ESM and `importmaps` ](https://github.com/waldekmastykarz/js-graph-101/blob/main/index_esm.html)
+
 ## Third Party Notices
 
 See [Third Party Notices](./THIRD%20PARTY%20NOTICES) for information on the packages that are included in the [package.json](./package.json)

docs/AuthCodeMSALBrowserAuthenticationProvider.md

@@ -34,19 +34,19 @@ Using npm:
     import { AuthCodeMSALBrowserAuthenticationProvider, AuthCodeMSALBrowserAuthenticationProviderOptions } from "@microsoft/microsoft-graph-client/authProviders/authCodeMsalBrowser";
     import { Client } from "@microsoft/microsoft-graph-client";
 
-    const options:AuthCodeMSALBrowserAuthenticationProviderOptions: {
+    const options: AuthCodeMSALBrowserAuthenticationProviderOptions = {
         account: account, // the AccountInfo instance to acquire the token for.
-        interactionType: InteractionType.PopUp , // msal-browser InteractionType
+        interactionType: InteractionType.Popup, // msal-browser InteractionType
         scopes: ["user.read", "mail.send"] // example of the scopes to be passed
-    }
+    };
 
     // Pass the PublicClientApplication instance from step 2 to create AuthCodeMSALBrowserAuthenticationProvider instance
-    const authProvider: new AuthCodeMSALBrowserAuthenticationProvider(publicClientApplication, options),
+    const authProvider = new AuthCodeMSALBrowserAuthenticationProvider(publicClientApplication, options);
 
 
     // Initialize the Graph client
     const graphClient = Client.initWithMiddleware({
-        authprovider
+        authProvider
     });
 
 ```

package-lock.json

@@ -48,11 +48,10 @@
         "prepack": "npm install && npm run build && npm run test",
         "pre-build": "npm run setVersion",
         "setVersion": "gulp setVersion",
-        "test": "npm run test:cjs && npm run test:esm",
+        "test": "npm run test:cjs && npm run karma",
         "test:cjs": "npm run build:sub_cjs && mocha",
         "test:coverage": "TS_NODE_PROJECT='./tsconfig-cjs.json' nyc mocha --require isomorphic-fetch -r ts-node/register test/common/**/*.ts && mocha --require isomorphic-fetch -r ts-node/register test/common/**/*.ts",
-        "test:development": "tsc --p test/tsconfig-test-development.json &&  mocha  'lib/test/development/**/*.js' --require  isomorphic-fetch",
-        "test:esm": "npm run build:sub_es  && mocha --require esm"
+        "test:development": "tsc --p test/tsconfig-test-development.json &&  mocha  'lib/test/development/**/*.js' --require  isomorphic-fetch"
     },
     "mocha": {
         "reporter": [
@@ -63,13 +62,10 @@
         },
         "spec": [
             "lib/test/common/**/*.js",
-            "lib/test/node/**/*.js",
-            "lib/es/test/common/**/*.js",
-            "lib/es/test/node/**/*.js"
+            "lib/test/node/**/*.js"
         ],
         "require": [
-            "isomorphic-fetch",
-            "esm"
+            "isomorphic-fetch"
         ]
     },
     "nyc": {
@@ -101,7 +97,7 @@
         "@rollup/plugin-node-resolve": "^15.0.0",
         "@rollup/plugin-terser": "^0.3.0",
         "@types/chai": "^4.2.14",
-        "@types/mocha": "^9.0.0",
+        "@types/mocha": "^10.0.1",
         "@types/node": "^18.0.0",
         "@types/sinon": "^10.0.8",
         "@typescript-eslint/eslint-plugin": "^5.12.1",
@@ -111,7 +107,6 @@
         "eslint-config-prettier": "^8.3.0",
         "eslint-plugin-prettier": "^4.0.0",
         "eslint-plugin-simple-import-sort": "^8.0.0",
-        "esm": "^3.2.25",
         "form-data": "^4.0.0",
         "gulp": "^4.0.2",
         "husky": "^8.0.0",
@@ -123,7 +118,7 @@
         "karma-mocha": "^2.0.1",
         "karma-typescript": "^5.2.0",
         "lint-staged": "^13.0.0",
-        "mocha": "^6.2.3",
+        "mocha": "^10.2.0",
         "mocha-junit-reporter": "^2.1.1",
         "nyc": "^15.1.0",
         "prettier": "^2.5.1",