Debt: code duplication in `src/vs/workbench/contrib/chat/browser/chatContentParts/chatConfirmationWidget.ts`

[bpasero]

I see some very weird code duplication from https://github.dev/microsoft/vscode/pull/260770. If I understand correctly, a chat confirmation widget was deprecated but mostly duplicated, specifically now that I want to tweak notifyConfirmationNeeded to fix #270619 I seem to be having to do this in 2 places.

This feels like a wasteful way of doing deprecation, at the very minimum I would have extracted a base class with the duplicated code and/or introduce helper methods. Now we need to maintain the same code multiple times.

[Tyriar]

Extracting a base class would have been a more difficult to work on and risk regressions in the original one which was my main concern, then needing to get rid of the base base class again once it's done.

@roblourens I think the only usage remaining is 'confirmation' kind, I tried to change chat-sample to use confirmation from vscode.proposed.chatParticipantAdditions.d.ts and couldn't get it to work. Any hints on how I can very this so I can remove the deprecated BaseSimpleChatConfirmationWidget and SimpleChatConfirmationWidget?

[roblourens]

It should show a confirmation if you just call confirmation on the chat response stream. It's used in several places in the chat extension but they are not very easy to trigger

[Tyriar]

@roblourens tried that using chat-sample but it failed with some mysterious error. I'll try again.