Fix copilot status icons in dev containers by using fallback colors (#7938)

* Initial plan

* Initial plan for fixing GHPR status icons in dev containers

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix GHPR status icons in dev containers by using fallback colors

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Simplify optional chaining logic in color getter functions

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Revert proposal changes

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/view/theme.ts

@@ -73,18 +73,18 @@ function getCurrentThemePaths(themeName: string): vscode.Uri | undefined {
 	}
 }
 
-export function getIconForeground(themeData: ThemeData, kind: 'light' | 'dark'): string {
-	return (themeData.colors ? themeData.colors['icon.foreground'] : undefined) ?? (kind === 'dark' ? '#C5C5C5' : '#424242');
+export function getIconForeground(themeData: ThemeData | undefined, kind: 'light' | 'dark'): string {
+	return themeData?.colors?.['icon.foreground'] ?? (kind === 'dark' ? '#C5C5C5' : '#424242');
 }
 
-export function getListWarningForeground(themeData: ThemeData, kind: 'light' | 'dark'): string {
-	return (themeData.colors ? themeData.colors['list.warningForeground'] : undefined) ?? (kind === 'dark' ? '#CCA700' : '#855F00');
+export function getListWarningForeground(themeData: ThemeData | undefined, kind: 'light' | 'dark'): string {
+	return themeData?.colors?.['list.warningForeground'] ?? (kind === 'dark' ? '#CCA700' : '#855F00');
 }
 
-export function getListErrorForeground(themeData: ThemeData, kind: 'light' | 'dark'): string {
-	return (themeData.colors ? themeData.colors['list.errorForeground'] : undefined) ?? (kind === 'dark' ? '#F88070' : '#B01011');
+export function getListErrorForeground(themeData: ThemeData | undefined, kind: 'light' | 'dark'): string {
+	return themeData?.colors?.['list.errorForeground'] ?? (kind === 'dark' ? '#F88070' : '#B01011');
 }
 
-export function getNotebookStatusSuccessIconForeground(themeData: ThemeData, kind: 'light' | 'dark'): string {
-	return (themeData.colors ? themeData.colors['notebookStatusSuccessIcon.foreground'] : undefined) ?? (kind === 'dark' ? '#89D185' : '#388A34');
+export function getNotebookStatusSuccessIconForeground(themeData: ThemeData | undefined, kind: 'light' | 'dark'): string {
+	return themeData?.colors?.['notebookStatusSuccessIcon.foreground'] ?? (kind === 'dark' ? '#89D185' : '#388A34');
 }

src/view/treeNodes/pullRequestNode.ts

@@ -270,7 +270,7 @@ export class PRNode extends TreeNode implements vscode.CommentingRangeProvider2
 	private async _getIcon(): Promise<vscode.Uri | vscode.ThemeIcon | { light: vscode.Uri; dark: vscode.Uri }> {
 		const copilotWorkingStatus = await this.pullRequestModel.copilotWorkingStatus(this.pullRequestModel);
 		const theme = this._folderReposManager.themeWatcher.themeData;
-		if (!theme || copilotWorkingStatus === CopilotWorkingStatus.NotCopilotIssue) {
+		if (copilotWorkingStatus === CopilotWorkingStatus.NotCopilotIssue) {
 			return (await DataUri.avatarCirclesAsImageDataUris(this._folderReposManager.context, [this.pullRequestModel.author], 16, 16))[0]
 				?? new vscode.ThemeIcon('github');
 		}