Adopt no-cast-to-any rule (#7956)

Author: alexr00

build/eslint-rules/index.js

@@ -9,4 +9,5 @@ exports.rules = {
 	'public-methods-well-defined-types': require('./public-methods-well-defined-types'),
 	'no-any-except-union-method-signature': require('./no-any-except-union-method-signature'),
 	'no-pr-in-user-strings': require('./no-pr-in-user-strings'),
+	'no-cast-to-any': require('./no-cast-to-any')
 };

build/eslint-rules/no-cast-to-any.js

@@ -0,0 +1,18 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+module.exports = {
+
+	create(context) {
+		return {
+			'TSTypeAssertion[typeAnnotation.type="TSAnyKeyword"], TSAsExpression[typeAnnotation.type="TSAnyKeyword"]': (node) => {
+				context.report({
+					node,
+					message: `Avoid casting to 'any' type. Consider using a more specific type or type guards for better type safety.`
+				});
+			}
+		};
+	}
+};

eslint.config.mjs

@@ -95,6 +95,7 @@ export default defineConfig([
 			'no-sequences': 'error',
 			'no-template-curly-in-string': 'warn',
 			'no-throw-literal': 'error',
+			'no-undef': 'off',
 			'no-unneeded-ternary': 'error',
 			'no-use-before-define': 'off',
 			'no-useless-call': 'error',
@@ -218,7 +219,8 @@ export default defineConfig([
 
 			// Custom rules
 			'rulesdir/no-any-except-union-method-signature': 'error',
-			'rulesdir/no-pr-in-user-strings': 'error'
+			'rulesdir/no-pr-in-user-strings': 'error',
+			'rulesdir/no-cast-to-any': 'error',
 		}
 	},
 

src/@types/vscode.proposed.chatParticipantAdditions.d.ts

@@ -103,6 +103,7 @@ declare module 'vscode' {
 		isConfirmed?: boolean;
 		isComplete?: boolean;
 		toolSpecificData?: ChatTerminalToolInvocationData;
+		fromSubAgent?: boolean;
 
 		constructor(toolName: string, toolCallId: string, isError?: boolean);
 	}
@@ -646,7 +647,13 @@ declare module 'vscode' {
 	}
 
 	export interface ChatRequest {
-		modeInstructions?: string;
-		modeInstructionsToolReferences?: readonly ChatLanguageModelToolReference[];
+		readonly modeInstructions?: string;
+		readonly modeInstructions2?: ChatRequestModeInstructions;
+	}
+
+	export interface ChatRequestModeInstructions {
+		readonly content: string;
+		readonly toolReferences?: readonly ChatLanguageModelToolReference[];
+		readonly metadata?: Record<string, boolean | string | number>;
 	}
 }

src/@types/vscode.proposed.chatParticipantPrivate.d.ts

@@ -187,6 +187,8 @@ declare module 'vscode' {
 
 		isQuotaExceeded?: boolean;
 
+		isRateLimited?: boolean;
+
 		level?: ChatErrorLevel;
 
 		code?: string;
@@ -219,6 +221,10 @@ declare module 'vscode' {
 		chatSessionId?: string;
 		chatInteractionId?: string;
 		terminalCommand?: string;
+		/**
+		 * Lets us add some nicer UI to toolcalls that came from a sub-agent, but in the long run, this should probably just be rendered in a similar way to thinking text + tool call groups
+		 */
+		fromSubAgent?: boolean;
 	}
 
 	export interface LanguageModelToolInvocationPrepareOptions<T> {
@@ -233,12 +239,13 @@ declare module 'vscode' {
 
 	export interface PreparedToolInvocation {
 		pastTenseMessage?: string | MarkdownString;
-		presentation?: 'hidden' | undefined;
+		presentation?: 'hidden' | 'hiddenAfterComplete' | undefined;
 	}
 
 	export class ExtendedLanguageModelToolResult extends LanguageModelToolResult {
 		toolResultMessage?: string | MarkdownString;
 		toolResultDetails?: Array<Uri | Location>;
+		toolMetadata?: unknown;
 	}
 
 	// #region Chat participant detection

src/common/diffHunk.ts

@@ -18,20 +18,16 @@ export enum DiffChangeType {
 }
 
 export class DiffLine {
-	public get raw(): string {
-		return this._raw;
-	}
-
 	public get text(): string {
-		return this._raw.substr(1);
+		return this.raw.substr(1);
 	}
 
 	constructor(
 		public type: DiffChangeType,
 		public oldLineNumber: number /* 1 based */,
 		public newLineNumber: number /* 1 based */,
 		public positionInHunk: number,
-		private _raw: string,
+		public readonly raw: string,
 		public endwithLineBreak: boolean = true,
 	) { }
 }

src/common/emoji.ts

@@ -23,7 +23,7 @@ export async function ensureEmojis(context: ExtensionContext) {
 }
 
 async function loadEmojiMap(context: ExtensionContext) {
-	const uri = (Uri as any).joinPath(context.extensionUri, 'resources', 'emojis.json');
+	const uri = Uri.joinPath(context.extensionUri, 'resources', 'emojis.json');
 	emojiMap = JSON.parse(new TextDecoder('utf8').decode(await workspace.fs.readFile(uri)));
 }
 

src/common/utils.ts

@@ -366,6 +366,10 @@ export interface Predicate<T> {
 	(input: T): boolean;
 }
 
+export interface AsyncPredicate<T> {
+	(input: T): Promise<boolean>;
+}
+
 export const enum CharCode {
 	Period = 46,
 	/**

src/gitProviders/builtinGit.ts

@@ -41,8 +41,8 @@ export class BuiltinGitProvider extends Disposable implements IGit {
 			throw e;
 		}
 
-		this._register(this._gitAPI.onDidCloseRepository(e => this._onDidCloseRepository.fire(e as any)));
-		this._register(this._gitAPI.onDidOpenRepository(e => this._onDidOpenRepository.fire(e as any)));
+		this._register(this._gitAPI.onDidCloseRepository(e => this._onDidCloseRepository.fire(e)));
+		this._register(this._gitAPI.onDidOpenRepository(e => this._onDidOpenRepository.fire(e)));
 		this._register(this._gitAPI.onDidChangeState(e => this._onDidChangeState.fire(e)));
 		this._register(this._gitAPI.onDidPublish(e => this._onDidPublish.fire(e)));
 	}

src/gitProviders/vslsguest.ts

@@ -115,7 +115,7 @@ export class VSLSGuest extends Disposable implements IGit {
 	}
 
 	public getRepository(folder: vscode.WorkspaceFolder): Repository {
-		return this._openRepositories.filter(repository => (repository as any).workspaceFolder === folder)[0];
+		return this._openRepositories.filter(repository => (repository as (Repository & { workspaceFolder: vscode.WorkspaceFolder })).workspaceFolder === folder)[0];
 	}
 }