Skip to content

Conversation

@aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

Fixes: #18492

Now:
image

Before:
image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@aasimkhan30 aasimkhan30 changed the title Aasim/fix/dynamic results grid length Dynamic results grid Height Nov 8, 2025
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 59.64% 59.62% ⚪ 0.00%
VSIX Size 5238 KB 5237 KB ⚪ -1 KB ( 0% )
Webview Bundle Size 5256 KB 5260 KB ⚪ 4 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.59%. Comparing base (609dc9a) to head (6910ff1).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #20503   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files         207      207           
  Lines       18798    18798           
  Branches     1175     1175           
=======================================
  Hits        10827    10827           
  Misses       7971     7971           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kburtram
kburtram previously approved these changes Nov 8, 2025
Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you confirm that this is accessible?

caohai
caohai previously approved these changes Nov 8, 2025
lewis-sanchez
lewis-sanchez previously approved these changes Nov 8, 2025
@aasimkhan30 aasimkhan30 dismissed stale reviews from lewis-sanchez, caohai, and kburtram via 6910ff1 November 11, 2025 04:23
@aasimkhan30 aasimkhan30 merged commit feed53e into main Nov 12, 2025
4 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/dynamicResultsGridLength branch November 12, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too much space between result sets in the QUERY RESULTS (PREVIEW) tab.

6 participants