Clarify toast message that appears on row delete (#20493)

* Clarify toast message that appears on row delete

* Generated loc's

Author: lewis-sanchez

localization/l10n/bundle.l10n.json

@@ -1931,7 +1931,7 @@
     "Unable to open Table Explorer: No target node provided.": "Unable to open Table Explorer: No target node provided.",
     "Changes saved successfully.": "Changes saved successfully.",
     "Row created.": "Row created.",
-    "Row removed.": "Row removed.",
+    "Row marked for removal.": "Row marked for removal.",
     "{0} (Preview)/{0} is the table name": {
         "message": "{0} (Preview)",
         "comment": ["{0} is the table name"]

localization/xliff/vscode-mssql.xlf

@@ -2889,8 +2889,8 @@
     <trans-unit id="++CODE++2f34dcbb175e7163055db4c74f8da053a82783ca89ca052d216bc867598b3ef3">
       <source xml:lang="en">Row created.</source>
     </trans-unit>
-    <trans-unit id="++CODE++d25169d1cd9a1ad455e2189423ab2b7341b1274e599218785aee69402ee977fc">
-      <source xml:lang="en">Row removed.</source>
+    <trans-unit id="++CODE++bec1d11423719e75365ab2e2d94e69229e18d8e25440ece25c0855deac353687">
+      <source xml:lang="en">Row marked for removal.</source>
     </trans-unit>
     <trans-unit id="++CODE++141b69f95916694982e525599db8205af7ecd6ced92d36c8aec6c5a9daa1e90e">
       <source xml:lang="en">Rows per page</source>

src/constants/locConstants.ts

@@ -2123,7 +2123,7 @@ export class TableExplorer {
     );
     public static changesSavedSuccessfully = l10n.t("Changes saved successfully.");
     public static rowCreatedSuccessfully = l10n.t("Row created.");
-    public static rowRemoved = l10n.t("Row removed.");
+    public static rowMarkedForRemoval = l10n.t("Row marked for removal.");
 
     public static title = (tableName: string) =>
         l10n.t({

src/tableExplorer/tableExplorerWebViewController.ts

@@ -478,7 +478,9 @@ export class TableExplorerWebViewController extends ReactWebviewPanelController<
 
             try {
                 await this._tableExplorerService.deleteRow(state.ownerUri, payload.rowId);
-                vscode.window.showInformationMessage(LocConstants.TableExplorer.rowRemoved);
+                vscode.window.showInformationMessage(
+                    LocConstants.TableExplorer.rowMarkedForRemoval,
+                );
 
                 // Remove from newRows tracking if it was a new row
                 state.newRows = state.newRows.filter((row) => row.id !== payload.rowId);

test/unit/tableExplorerWebViewController.test.ts

@@ -379,8 +379,11 @@ suite("TableExplorerWebViewController - Reducers", () => {
             // Assert
             expect(mockTableExplorerService.deleteRow.calledOnceWith("test-owner-uri", 0)).to.be
                 .true;
-            expect(showInformationMessageStub.calledOnceWith(LocConstants.TableExplorer.rowRemoved))
-                .to.be.true;
+            expect(
+                showInformationMessageStub.calledOnceWith(
+                    LocConstants.TableExplorer.rowMarkedForRemoval,
+                ),
+            ).to.be.true;
             expect(controller.state.resultSet?.rowCount).to.equal(1);
             expect(controller.state.resultSet?.subset.length).to.equal(1);
         });