track permissiveSessionAuth as context key and react to it in cloud-agent view (#1861) (#1865)

* track permissiveSessionAuth as context key and react to it in cloud-agent view

* do not block if run and then cancelled

* code review suggestion adding catch

Author: joshspicer

package.json

@@ -1714,6 +1714,11 @@
 				"when": "true",
 				"contents": "%github.copilot.viewsWelcome.agentsPlaceholder%"
 			},
+			{
+				"view": "workbench.view.chat.sessions.copilot-cloud-agent",
+				"when": "github.copilot.auth.missingPermissiveSession",
+				"contents": "%github.copilot.viewsWelcome.noPermissiveToken.contents%"
+			},
 			{
 				"view": "workbench.view.chat.sessions.copilot-cloud-agent",
 				"when": "workspaceFolderCount == 0",
@@ -1785,6 +1790,10 @@
 			}
 		],
 		"commands": [
+			{
+				"command": "github.copilot.chat.triggerPermissiveSignIn",
+				"title": "%github.copilot.command.triggerPermissiveSignIn%"
+			},
 			{
 				"command": "github.copilot.claude.sessions.refresh",
 				"title": "%github.copilot.command.refreshClaudeCodeSessions%",
@@ -3415,6 +3424,10 @@
 				}
 			],
 			"commandPalette": [
+				{
+					"command": "github.copilot.chat.triggerPermissiveSignIn",
+					"when": "false"
+				},
 				{
 					"command": "github.copilot.interactiveSession.feedback",
 					"when": "github.copilot-chat.activated && !github.copilot.interactiveSession.disabled"

package.nls.json

@@ -100,6 +100,13 @@
 			"{Locked='](command:workbench.action.chat.triggerSetupForceSignIn)'}"
 		]
 	},
+	"github.copilot.viewsWelcome.noPermissiveToken.contents": {
+		"message": "Additional GitHub permissions required to use GitHub Copilot Cloud Agent.\n\n[Sign in](command:github.copilot.chat.triggerPermissiveSignIn)",
+		"comment": [
+			"{Locked='['}",
+			"{Locked='](command:github.copilot.chat.triggerPermissiveSignIn)'}"
+		]
+	},
 	"github.copilot.viewsWelcome.noFolder.contents": {
 		"message": "You have not yet opened a folder.\n[Open Folder](command:workbench.action.files.openFolder)",
 		"comment": [
@@ -131,6 +138,7 @@
 	"github.copilot.command.applySuggestionWithCopilot": "Apply Suggestion",
 	"github.copilot.command.explainTerminalLastCommand": "Explain Last Terminal Command",
 	"github.copilot.command.collectWorkspaceIndexDiagnostics": "Collect Workspace Index Diagnostics",
+	"github.copilot.command.triggerPermissiveSignIn": "Login to GitHub with Full Permissions",
 	"github.copilot.git.generateCommitMessage": "Generate Commit Message",
 	"github.copilot.git.resolveMergeConflicts": "Resolve Conflicts with AI",
 	"github.copilot.devcontainer.generateDevContainerConfig": "Generate Dev Container Configuration",

src/extension/authentication/vscode-node/authentication.contribution.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { window } from 'vscode';
+import { commands, window } from 'vscode';
 import { IAuthenticationService } from '../../../platform/authentication/common/authentication';
 import { IAuthenticationChatUpgradeService } from '../../../platform/authentication/common/authenticationUpgrade';
 import { IVSCodeExtensionContext } from '../../../platform/extContext/common/extensionContext';
@@ -38,6 +38,9 @@ class AuthUpgradeAsk extends Disposable {
 		@IAuthenticationChatUpgradeService private readonly _authenticationChatUpgradeService: IAuthenticationChatUpgradeService,
 	) {
 		super();
+		this._register(commands.registerCommand('github.copilot.chat.triggerPermissiveSignIn', async () => {
+			await this._authenticationChatUpgradeService.showPermissiveSessionModal(true);
+		}));
 	}
 
 	async run() {

src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts

@@ -100,6 +100,9 @@ export class CopilotCloudSessionsProvider extends Disposable implements vscode.C
 			}
 		}, BACKGROUND_REFRESH_INTERVAL_MS);
 		this._register(toDisposable(() => clearInterval(interval)));
+		this._register(this._authenticationService.onDidAuthenticationChange(() => {
+			this.refresh();
+		}));
 	}
 
 	public refresh(): void {

src/extension/contextKeys/vscode-node/contextKeys.contribution.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import { commands, extensions, window } from 'vscode';
-import { IAuthenticationService } from '../../../platform/authentication/common/authentication';
+import { IAuthenticationService, MinimalModeError } from '../../../platform/authentication/common/authentication';
 import { ChatDisabledError, ContactSupportError, EnterpriseManagedError, NotSignedUpError, SubscriptionExpiredError } from '../../../platform/authentication/vscode-node/copilotTokenManager';
 import { SESSION_LOGIN_MESSAGE } from '../../../platform/authentication/vscode-node/session';
 import { ConfigKey, IConfigurationService } from '../../../platform/configuration/common/configurationService';
@@ -35,6 +35,8 @@ const previewFeaturesDisabledContextKey = 'github.copilot.previewFeaturesDisable
 
 const debugContextKey = 'github.copilot.chat.debug';
 
+const missingPermissiveSessionContextKey = 'github.copilot.auth.missingPermissiveSession';
+
 export const prExtensionInstalledContextKey = 'github.copilot.prExtensionInstalled';
 
 export class ContextKeysContribution extends Disposable {
@@ -54,6 +56,7 @@ export class ContextKeysContribution extends Disposable {
 		super();
 
 		void this._inspectContext().catch(console.error);
+		void this._updatePermissiveSessionContext().catch(console.error);
 		this._register(_authenticationService.onDidAuthenticationChange(async () => await this._onAuthenticationChange()));
 		this._register(commands.registerCommand('github.copilot.refreshToken', async () => await this._inspectContext()));
 		this._register(commands.registerCommand('github.copilot.debug.showChatLogView', async () => {
@@ -154,6 +157,8 @@ export class ContextKeysContribution extends Disposable {
 				commands.executeCommand('setContext', contextKey, false);
 			}
 		}
+
+		await this._updatePermissiveSessionContext();
 	}
 
 	private async _updateQuotaExceededContext() {
@@ -203,5 +208,23 @@ export class ContextKeysContribution extends Disposable {
 		this._updateQuotaExceededContext();
 		this._updatePreviewFeaturesDisabledContext();
 		this._updateShowLogViewContext();
+		this._updatePermissiveSessionContext();
+	}
+
+	private async _updatePermissiveSessionContext() {
+		let hasPermissiveSession = false;
+		let missingPermissiveSession = false;
+		if (!this._authenticationService.isMinimalMode) {
+			try {
+				hasPermissiveSession = !!(await this._authenticationService.getPermissiveGitHubSession({ silent: true }));
+			} catch (error) {
+				if (!(error instanceof MinimalModeError)) {
+					this._logService.trace(`[context keys] Failed to resolve permissive session: ${error instanceof Error ? error.message : String(error)}`);
+					hasPermissiveSession = !!this._authenticationService.permissiveGitHubSession;
+				}
+			}
+			missingPermissiveSession = !hasPermissiveSession;
+		}
+		commands.executeCommand('setContext', missingPermissiveSessionContextKey, missingPermissiveSession);
 	}
 }

src/platform/authentication/common/authenticationUpgrade.ts

@@ -25,7 +25,7 @@ export interface IAuthenticationChatUpgradeService {
 	 * Displays a modal dialog requesting the user to grant an upgrade to a more permissive session.
 	 * @returns A promise that resolves to a boolean indicating whether the user granted the upgrade.
 	 */
-	showPermissiveSessionModal(): Promise<boolean>;
+	showPermissiveSessionModal(skipRepeatCheck?: boolean): Promise<boolean>;
 
 	/**
 	 * Presents the upgrade prompt within the chat interface itself.

src/platform/authentication/common/authenticationUpgradeService.ts

@@ -83,8 +83,8 @@ export class AuthenticationChatUpgradeService extends Disposable implements IAut
 		}
 	}
 
-	async showPermissiveSessionModal(): Promise<boolean> {
-		if (this.hasRequestedPermissiveSessionUpgrade) {
+	async showPermissiveSessionModal(skipRepeatCheck = false): Promise<boolean> {
+		if (this.hasRequestedPermissiveSessionUpgrade && !skipRepeatCheck) {
 			this.logService.trace('Already requested permissive session upgrade');
 			return false;
 		}