Optimize resolution of single non-generic construct signatures (#1865)

Author: ahejlsberg

internal/checker/checker.go

@@ -7029,7 +7029,9 @@ func (c *Checker) getQuickTypeOfExpression(node *ast.Node) *Type {
 		if isCallChain(expr) {
 			return c.getReturnTypeOfSingleNonGenericSignatureOfCallChain(expr)
 		}
-		return c.getReturnTypeOfSingleNonGenericCallSignature(c.checkNonNullExpression(expr.Expression()))
+		return c.getReturnTypeOfSingleNonGenericSignature(c.checkNonNullExpression(expr.Expression()), SignatureKindCall)
+	case ast.IsNewExpression(expr):
+		return c.getReturnTypeOfSingleNonGenericSignature(c.checkNonNullExpression(expr.Expression()), SignatureKindConstruct)
 	case ast.IsAssertionExpression(expr) && !ast.IsConstTypeReference(expr.Type()):
 		return c.getTypeFromTypeNode(expr.Type())
 	case ast.IsLiteralExpression(node) || ast.IsBooleanLiteral(node):
@@ -7038,8 +7040,8 @@ func (c *Checker) getQuickTypeOfExpression(node *ast.Node) *Type {
 	return nil
 }
 
-func (c *Checker) getReturnTypeOfSingleNonGenericCallSignature(funcType *Type) *Type {
-	signature := c.getSingleCallSignature(funcType)
+func (c *Checker) getReturnTypeOfSingleNonGenericSignature(funcType *Type, kind SignatureKind) *Type {
+	signature := c.getSingleSignature(funcType, kind, true /*allowMembers*/)
 	if signature != nil && len(signature.typeParameters) == 0 {
 		return c.getReturnTypeOfSignature(signature)
 	}
@@ -7049,7 +7051,7 @@ func (c *Checker) getReturnTypeOfSingleNonGenericCallSignature(funcType *Type) *
 func (c *Checker) getReturnTypeOfSingleNonGenericSignatureOfCallChain(expr *ast.Node) *Type {
 	funcType := c.checkExpression(expr.Expression())
 	nonOptionalType := c.getOptionalExpressionType(funcType, expr.Expression())
-	returnType := c.getReturnTypeOfSingleNonGenericCallSignature(funcType)
+	returnType := c.getReturnTypeOfSingleNonGenericSignature(funcType, SignatureKindCall)
 	if returnType != nil {
 		return c.propagateOptionalTypeMarker(returnType, expr, nonOptionalType != funcType)
 	}

testdata/baselines/reference/submodule/compiler/abstractClassInLocalScopeIsAbstract.types

@@ -14,7 +14,7 @@
 >A : A
 
     new A();
->new A() : any
+>new A() : A
 >A : typeof A
 
     new B();

testdata/baselines/reference/submodule/compiler/abstractClassInLocalScopeIsAbstract.types.diff

@@ -0,0 +1,11 @@
+--- old.abstractClassInLocalScopeIsAbstract.types
++++ new.abstractClassInLocalScopeIsAbstract.types
+@@= skipped -13, +13 lines =@@
+ >A : A
+
+     new A();
+->new A() : any
++>new A() : A
+ >A : typeof A
+
+     new B();

testdata/baselines/reference/submodule/compiler/newAbstractInstance2.types

@@ -9,6 +9,6 @@ import A from "./a";
 >A : typeof A
 
 new A();
->new A() : any
+>new A() : A
 >A : typeof A
 

testdata/baselines/reference/submodule/compiler/newAbstractInstance2.types.diff

@@ -0,0 +1,9 @@
+--- old.newAbstractInstance2.types
++++ new.newAbstractInstance2.types
+@@= skipped -8, +8 lines =@@
+ >A : typeof A
+
+ new A();
+->new A() : any
++>new A() : A
+ >A : typeof A

testdata/baselines/reference/submodule/compiler/noCrashOnMixin.types

@@ -42,7 +42,7 @@ class CrashTrigger extends Mixin(Empty) {
 >trigger : () => void
 
         new Concrete();
->new Concrete() : any
+>new Concrete() : Concrete
 >Concrete : typeof Concrete
     }
 }

testdata/baselines/reference/submodule/compiler/noCrashOnMixin.types.diff

@@ -24,4 +24,12 @@
 +>Mixin : <TBase extends Constructor<{}>>(Base: TBase) => { new (...args: any[]): (Anonymous class); prototype: Mixin.(Anonymous class); } & TBase
  >Empty : typeof Empty
 
-     public trigger() {
+     public trigger() {
+ >trigger : () => void
+
+         new Concrete();
+->new Concrete() : any
++>new Concrete() : Concrete
+ >Concrete : typeof Concrete
+     }
+ }

testdata/baselines/reference/submodule/conformance/classAbstractConstructorAssignability.types

@@ -32,7 +32,7 @@ new AA;
 >AA : typeof A
 
 new BB;
->new BB : any
+>new BB : B
 >BB : typeof B
 
 new CC;

testdata/baselines/reference/submodule/conformance/classAbstractConstructorAssignability.types.diff

@@ -0,0 +1,11 @@
+--- old.classAbstractConstructorAssignability.types
++++ new.classAbstractConstructorAssignability.types
+@@= skipped -31, +31 lines =@@
+ >AA : typeof A
+
+ new BB;
+->new BB : any
++>new BB : B
+ >BB : typeof B
+
+ new CC;

testdata/baselines/reference/submodule/conformance/classAbstractFactoryFunction.types

@@ -24,7 +24,7 @@ function NewB(Factory: typeof B) {
 >B : typeof B
 
     return new B;
->new B : any
+>new B : B
 >B : typeof B
 }