Commit 713a72e
committed
Fix ReactWindows-Desktop build break
`//vnect/Shared/Shared.vcxitems` is included by two project:
1. `//vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj`
2. `//vnext/Desktop/React.Windows.Desktop.vcxproj`
(2) is a static library that breaks due to compiler errors due to
`ReactNativeHost.cpp` including `XamlApplication.h` which in turn
includes `Xaml.XamlApplication.g.*` which requires
`XamlApplication.idl` to be generating them. This won’t happen due to
the project type of (2). Wrap `XamlApplication`-related code in a
macro and define it only for (1).1 parent af97183 commit 713a72e
File tree
2 files changed
+5
-0
lines changed- vnext/Microsoft.ReactNative
2 files changed
+5
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
103 | 105 | | |
104 | 106 | | |
105 | 107 | | |
| 108 | + | |
106 | 109 | | |
107 | 110 | | |
108 | 111 | | |
| 112 | + | |
109 | 113 | | |
110 | 114 | | |
111 | 115 | | |
| |||
0 commit comments