[0.81] Fix NPM tagging and stop releasing Debug Nugets (#15409)

* Attempt to fix the tgz file grouping

* Stop creating Nuget packages for Debug code (#15374)

Author: vmoroz

.ado/publish.yml

@@ -479,12 +479,6 @@ extends:
                   configuration: Release
                 - platform: ARM64
                   configuration: Release
-                - platform: x64
-                  configuration: Debug
-                - platform: x86
-                  configuration: Debug
-                - platform: ARM64
-                  configuration: Debug
 
           - template: .ado/templates/prep-and-pack-nuget.yml@self
             parameters:

.ado/scripts/npmGroupByTag.js

@@ -117,7 +117,15 @@ function setPipelineVariable(name, value) {
 (function main() {
   const {packRootArg, customRootArg, latestRootArg} = ensureArgs();
 
-  const repoRoot = process.env.BUILD_SOURCESDIRECTORY || process.cwd();
+  const repoRoot = path.resolve(__dirname, '..', '..');
+  const vnextPackageJsonPath = path.join(repoRoot, 'vnext', 'package.json');
+
+  if (!fs.existsSync(vnextPackageJsonPath)) {
+    console.error(`[npmGroupByTag] vnext package.json not found at ${vnextPackageJsonPath}`);
+    process.exit(1);
+  }
+
+  console.log(`[npmGroupByTag] Using repo root ${repoRoot}`);
   const packRoot = path.resolve(packRootArg);
   const customRoot = path.resolve(customRootArg);
   const latestRoot = path.resolve(latestRootArg);
@@ -128,15 +136,19 @@ function setPipelineVariable(name, value) {
   /** @type {string | null} */
   let customTag = null;
   try {
-    const vnextPackageJson = /** @type {PackageJson} */ (
-      readJson(path.join(repoRoot, 'vnext', 'package.json'))
-    );
+    const vnextPackageJson = /** @type {PackageJson} */ (readJson(vnextPackageJsonPath));
     const tagFromVnext = vnextPackageJson?.beachball?.defaultNpmTag;
     if (tagFromVnext && tagFromVnext !== 'latest') {
       customTag = tagFromVnext;
     }
+    console.log(
+      `[npmGroupByTag] vnext defaultNpmTag is ${tagFromVnext || 'latest'}${
+        customTag ? ` (custom tag '${customTag}' will be used)` : ' (no custom tag)'
+      }`,
+    );
   } catch (e) {
-    console.warn('Unable to read vnext/package.json to determine custom tag.');
+    console.error(`[npmGroupByTag] Failed to read ${vnextPackageJsonPath}: ${e}`);
+    process.exit(1);
   }
 
   /** @type {string[]} */
@@ -153,28 +165,31 @@ function setPipelineVariable(name, value) {
     return;
   }
 
-  /** @type {Set<string>} */
-  const customTarballs = new Set();
+  /** @type {Map<string, {packageJsonPath: string, name: string, version: string, tag: string, isPrivate: boolean}>} */
+  const packageMetadata = new Map();
+  for (const packageJsonPath of findPackageJsons(repoRoot)) {
+    /** @type {PackageJson | undefined} */
+    let pkg;
+    try {
+      pkg = /** @type {PackageJson} */ (readJson(packageJsonPath));
+    } catch (e) {
+      console.warn(`[npmGroupByTag] Skipping unreadable package.json ${packageJsonPath}: ${e}`);
+      continue;
+    }
 
-  if (customTag) {
-    for (const packageJsonPath of findPackageJsons(repoRoot)) {
-      /** @type {PackageJson | undefined} */
-      let pkg;
-      try {
-        pkg = /** @type {PackageJson} */ (readJson(packageJsonPath));
-      } catch (e) {
-        continue;
-      }
+    if (!pkg?.name || !pkg?.version) {
+      continue;
+    }
 
-      if (!pkg?.name || !pkg?.version) {
-        continue;
-      }
+    const metadata = {
+      packageJsonPath,
+      name: pkg.name,
+      version: pkg.version,
+      tag: pkg?.beachball?.defaultNpmTag || 'latest',
+      isPrivate: pkg.private === true,
+    };
 
-      const pkgTag = pkg?.beachball?.defaultNpmTag;
-      if (pkgTag === customTag && pkg.private !== true) {
-        customTarballs.add(sanitizedTarballName(pkg.name, pkg.version));
-      }
-    }
+    packageMetadata.set(sanitizedTarballName(pkg.name, pkg.version), metadata);
   }
 
   let customCount = 0;
@@ -183,10 +198,22 @@ function setPipelineVariable(name, value) {
   for (const tarball of tarballs) {
     const sourcePath = path.join(packRoot, tarball);
     const normalizedName = normalizePackedTarballName(tarball);
-    const destinationRoot = customTag && customTarballs.has(normalizedName) ? customRoot : latestRoot;
+    const metadata = packageMetadata.get(normalizedName);
+    const destinationRoot = customTag && metadata && !metadata.isPrivate && metadata.tag === customTag ? customRoot : latestRoot;
     const destinationPath = path.join(destinationRoot, tarball);
     fs.mkdirSync(path.dirname(destinationPath), {recursive: true});
     fs.renameSync(sourcePath, destinationPath);
+
+    if (metadata) {
+      const destinationLabel = destinationRoot === customRoot ? 'custom' : 'latest';
+      console.log(
+        `[npmGroupByTag] ${tarball}: ${metadata.name}@${metadata.version} (${metadata.packageJsonPath}) tag=${metadata.tag} ` +
+          `private=${metadata.isPrivate} -> ${destinationLabel}`,
+      );
+    } else {
+      console.warn(`[npmGroupByTag] ${tarball}: no package.json metadata found. Defaulting to latest.`);
+    }
+
     if (destinationRoot === customRoot) {
       customCount++;
     } else {

.ado/templates/prep-and-pack-nuget.yml

@@ -42,19 +42,15 @@ parameters:
 steps:
   - pwsh: |
       $slices = ConvertFrom-Json -NoEnumerate '${{ convertToJson(parameters.slices) }}'
-      $debugSlices = @($slices.where{$_.configuration -match 'Debug'});
       $releaseSlices = @($slices.where{$_.configuration -match 'Release'});
   
       $sliceTags = $slices | % {$_.platform + "." + $_.configuration} | ConvertTo-Json -AsArray -Compress
-      $debugSliceTags = $debugSlices | % {$_.platform + "." + $_.configuration} | ConvertTo-Json -AsArray -Compress
       $releaseSliceTags = $releaseSlices | % {$_.platform + "." + $_.configuration} | ConvertTo-Json -AsArray -Compress
 
       Write-Host "##vso[task.setvariable variable=allSlices]$sliceTags"
-      Write-Host "##vso[task.setvariable variable=debugSlices]$debugSliceTags"
       Write-Host "##vso[task.setvariable variable=releaseSlices]$releaseSliceTags"
 
       Write-Host "##vso[task.setvariable variable=basePlatform]$($slices[0].platform)"
-      Write-Host "##vso[task.setvariable variable=debugBasePlatform]$($debugSlices[0].platform)"
       Write-Host "##vso[task.setvariable variable=releaseBasePlatform]$($releaseSlices[0].platform)"
 
       Write-Host "##vso[task.setvariable variable=baseConfiguration]$($slices[0].configuration)"
@@ -100,16 +96,6 @@ steps:
         buildProperties: 'CommitId=${{parameters.publishCommitId}};nugetroot=${{parameters.nugetroot}}'
 
   - ${{ if eq(parameters.packMicrosoftReactNative, true) }}:
-    - ${{ if containsValue(parameters.slices.*.configuration, 'Debug') }}:
-      - template: prep-and-pack-single.yml
-        parameters:
-          outputPackage: Microsoft.ReactNative.Debug
-          nuspec: Microsoft.ReactNative
-          slices: $(debugSlices)
-          packageVersion: ${{parameters.npmVersion}}
-          codesignBinaries: ${{ parameters.signMicrosoft }}
-          codesignNuget: ${{ parameters.signMicrosoft }}
-          buildProperties: CommitId=${{parameters.publishCommitId}};nugetroot=${{parameters.nugetroot}};baseconfiguration=Debug;baseplatform=$(debugBasePlatform)
     - ${{ if containsValue(parameters.slices.*.configuration, 'Release') }}:
       - template: prep-and-pack-single.yml
         parameters:
@@ -130,16 +116,6 @@ steps:
         codesignNuget: ${{ parameters.signMicrosoft }}
 
   - ${{ if eq(parameters.packMicrosoftReactNativeManaged, true) }}:
-    - ${{ if containsValue(parameters.slices.*.configuration, 'Debug') }}:
-      - template: prep-and-pack-single.yml
-        parameters:
-          outputPackage: Microsoft.ReactNative.Managed.Debug
-          nuspec: Microsoft.ReactNative.Managed
-          slices: $(debugSlices)
-          packageVersion: ${{parameters.npmVersion}}
-          codesignBinaries: ${{ parameters.signMicrosoft }}
-          codesignNuget: ${{ parameters.signMicrosoft }}
-          buildProperties: CommitId=${{parameters.publishCommitId}};nugetroot=${{parameters.nugetroot}};baseconfiguration=Debug;baseplatform=$(debugBasePlatform)
     - ${{ if containsValue(parameters.slices.*.configuration, 'Release') }}:
       - template: prep-and-pack-single.yml
         parameters: