Skip to content

[macOS] Fix Fabric TextInput border rendering #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[macOS] Fix Fabric TextInput border rendering #2739

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ad271a9
Initial plan
Copilot Oct 24, 2025
2199b77
Attempt fix for TextInput border rendering by setting masksToBounds
Copilot Oct 24, 2025
09bb94a
Force Core Animation border rendering for TextInput on macOS by enabl…
Copilot Oct 24, 2025
a8b4c19
Address code review feedback: reset clipsToBounds when no borders and…
Copilot Oct 24, 2025
4a62aa3
Remove unrelated build artifacts and package.json changes
Copilot Oct 24, 2025
c8712e8
Remove formatting-only changes, keep only functional border rendering…
Copilot Oct 24, 2025
3968a53
Simplify fix to just set clipsToBounds in initWithFrame on macOS
Copilot Nov 1, 2025
40cc07d
Remove .gitignore change
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ - (instancetype)initWithFrame:(CGRect)frame
_didMoveToWindow = NO;
_originalTypingAttributes = [_backedTextInputView.typingAttributes copy];

#if TARGET_OS_OSX // [macOS
[self setClipsToBounds:YES];
#endif // macOS]

[self addSubview:_backedTextInputView];
#if TARGET_OS_IOS // [macOS] [visionOS]
[self initializeReturnKeyType];
Expand Down
Loading