feat(roll): roll Playwright 1.14.0-next-1628399336000 (#839)

Author: mxschmitt

playwright/_impl/_frame.py

@@ -522,6 +522,8 @@ async def drag_and_drop(
         self,
         source: str,
         target: str,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         noWaitAfter: bool = None,
         strict: bool = None,

playwright/_impl/_page.py

@@ -699,6 +699,8 @@ async def drag_and_drop(
         self,
         source: str,
         target: str,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         noWaitAfter: bool = None,
         timeout: float = None,

playwright/_impl/_tracing.py

@@ -37,7 +37,6 @@ async def start(
         await self._channel.send("tracingStart", params)
 
     async def stop(self, path: Union[pathlib.Path, str] = None) -> None:
-        await self._channel.send("tracingStop")
         if path:
             artifact = cast(
                 Artifact, from_channel(await self._channel.send("tracingExport"))
@@ -46,3 +45,4 @@ async def stop(self, path: Union[pathlib.Path, str] = None) -> None:
                 artifact._is_remote = self._context._browser._is_remote
             await artifact.save_as(path)
             await artifact.delete()
+        await self._channel.send("tracingStop")

playwright/async_api/_generated.py

@@ -1905,7 +1905,7 @@ async def select_text(
     async def input_value(self, *, timeout: float = None) -> str:
         """ElementHandle.input_value
 
-        Returns `input.value` for `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -4245,6 +4245,8 @@ async def drag_and_drop(
         source: str,
         target: str,
         *,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         no_wait_after: bool = None,
         strict: bool = None,
@@ -4257,6 +4259,12 @@ async def drag_and_drop(
         ----------
         source : str
         target : str
+        source_position : Union[{x: float, y: float}, NoneType]
+            Clicks on the source element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
+        target_position : Union[{x: float, y: float}, NoneType]
+            Drops on the target element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
         force : Union[bool, NoneType]
             Whether to bypass the [actionability](./actionability.md) checks. Defaults to `false`.
         no_wait_after : Union[bool, NoneType]
@@ -4280,6 +4288,8 @@ async def drag_and_drop(
                 self._impl_obj.drag_and_drop(
                     source=source,
                     target=target,
+                    source_position=source_position,
+                    target_position=target_position,
                     force=force,
                     noWaitAfter=no_wait_after,
                     strict=strict,
@@ -4378,7 +4388,7 @@ async def input_value(
     ) -> str:
         """Frame.input_value
 
-        Returns `input.value` for the selected `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for the selected `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -7586,6 +7596,8 @@ async def drag_and_drop(
         source: str,
         target: str,
         *,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         no_wait_after: bool = None,
         timeout: float = None,
@@ -7598,6 +7610,12 @@ async def drag_and_drop(
         ----------
         source : str
         target : str
+        source_position : Union[{x: float, y: float}, NoneType]
+            Clicks on the source element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
+        target_position : Union[{x: float, y: float}, NoneType]
+            Drops on the target element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
         force : Union[bool, NoneType]
             Whether to bypass the [actionability](./actionability.md) checks. Defaults to `false`.
         no_wait_after : Union[bool, NoneType]
@@ -7621,6 +7639,8 @@ async def drag_and_drop(
                 self._impl_obj.drag_and_drop(
                     source=source,
                     target=target,
+                    source_position=source_position,
+                    target_position=target_position,
                     force=force,
                     noWaitAfter=no_wait_after,
                     timeout=timeout,
@@ -7722,7 +7742,7 @@ async def input_value(
     ) -> str:
         """Page.input_value
 
-        Returns `input.value` for the selected `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for the selected `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -11370,7 +11390,7 @@ async def inner_text(self, *, timeout: float = None) -> str:
     async def input_value(self, *, timeout: float = None) -> str:
         """Locator.input_value
 
-        Returns `input.value` for `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------

playwright/sync_api/_generated.py

@@ -1890,7 +1890,7 @@ def select_text(self, *, force: bool = None, timeout: float = None) -> NoneType:
     def input_value(self, *, timeout: float = None) -> str:
         """ElementHandle.input_value
 
-        Returns `input.value` for `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -4223,6 +4223,8 @@ def drag_and_drop(
         source: str,
         target: str,
         *,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         no_wait_after: bool = None,
         strict: bool = None,
@@ -4235,6 +4237,12 @@ def drag_and_drop(
         ----------
         source : str
         target : str
+        source_position : Union[{x: float, y: float}, NoneType]
+            Clicks on the source element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
+        target_position : Union[{x: float, y: float}, NoneType]
+            Drops on the target element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
         force : Union[bool, NoneType]
             Whether to bypass the [actionability](./actionability.md) checks. Defaults to `false`.
         no_wait_after : Union[bool, NoneType]
@@ -4258,6 +4266,8 @@ def drag_and_drop(
                 self._impl_obj.drag_and_drop(
                     source=source,
                     target=target,
+                    source_position=source_position,
+                    target_position=target_position,
                     force=force,
                     noWaitAfter=no_wait_after,
                     strict=strict,
@@ -4356,7 +4366,7 @@ def input_value(
     ) -> str:
         """Frame.input_value
 
-        Returns `input.value` for the selected `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for the selected `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -7541,6 +7551,8 @@ def drag_and_drop(
         source: str,
         target: str,
         *,
+        source_position: Position = None,
+        target_position: Position = None,
         force: bool = None,
         no_wait_after: bool = None,
         timeout: float = None,
@@ -7553,6 +7565,12 @@ def drag_and_drop(
         ----------
         source : str
         target : str
+        source_position : Union[{x: float, y: float}, NoneType]
+            Clicks on the source element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
+        target_position : Union[{x: float, y: float}, NoneType]
+            Drops on the target element at this point relative to the top-left corner of the element's padding box. If not
+            specified, some visible point of the element is used.
         force : Union[bool, NoneType]
             Whether to bypass the [actionability](./actionability.md) checks. Defaults to `false`.
         no_wait_after : Union[bool, NoneType]
@@ -7576,6 +7594,8 @@ def drag_and_drop(
                 self._impl_obj.drag_and_drop(
                     source=source,
                     target=target,
+                    source_position=source_position,
+                    target_position=target_position,
                     force=force,
                     noWaitAfter=no_wait_after,
                     timeout=timeout,
@@ -7677,7 +7697,7 @@ def input_value(
     ) -> str:
         """Page.input_value
 
-        Returns `input.value` for the selected `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for the selected `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------
@@ -11300,7 +11320,7 @@ def inner_text(self, *, timeout: float = None) -> str:
     def input_value(self, *, timeout: float = None) -> str:
         """Locator.input_value
 
-        Returns `input.value` for `<input>` or `<textarea>` element. Throws for non-input elements.
+        Returns `input.value` for `<input>` or `<textarea>` or `<select>` element. Throws for non-input elements.
 
         Parameters
         ----------

setup.py

@@ -28,7 +28,7 @@
     InWheel = None
 from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand
 
-driver_version = "1.14.0-next-1627933604000"
+driver_version = "1.14.0-next-1628399336000"
 
 
 def extractall(zip: zipfile.ZipFile, path: str) -> None:

tests/async/test_console.py

@@ -17,14 +17,18 @@
 from playwright.async_api import ConsoleMessage, Page
 
 
-async def test_console_should_work(page: Page, server):
+async def test_console_should_work(page: Page, browser_name):
     messages: List[ConsoleMessage] = []
     page.once("console", lambda m: messages.append(m))
     async with page.expect_console_message() as message_info:
         await page.evaluate('() => console.log("hello", 5, {foo: "bar"})')
     message = await message_info.value
-    assert message.text == "hello 5 JSHandle@object"
-    assert str(message) == "hello 5 JSHandle@object"
+    if browser_name != "firefox":
+        assert message.text == "hello 5 {foo: bar}"
+        assert str(message) == "hello 5 {foo: bar}"
+    else:
+        assert message.text == "hello 5 JSHandle@object"
+        assert str(message) == "hello 5 JSHandle@object"
     assert message.type == "log"
     assert await message.args[0].json_value() == "hello"
     assert await message.args[1].json_value() == 5
@@ -77,15 +81,18 @@ async def test_console_should_work_for_different_console_api_calls(page, server)
         "calling console.dir",
         "calling console.warn",
         "calling console.error",
-        "JSHandle@promise",
+        "Promise",
     ]
 
 
-async def test_console_should_not_fail_for_window_object(page):
+async def test_console_should_not_fail_for_window_object(page, browser_name):
     async with page.expect_console_message() as message_info:
         await page.evaluate("console.error(window)")
     message = await message_info.value
-    assert message.text == "JSHandle@object"
+    if browser_name != "firefox":
+        assert message.text == "Window"
+    else:
+        assert message.text == "JSHandle@object"
 
 
 async def test_console_should_trigger_correct_log(page, server):

tests/async/test_jshandle.py

@@ -202,17 +202,20 @@ async def test_jshandle_as_element_return_none_for_non_elements(page):
 
 async def test_jshandle_to_string_work_for_primitives(page):
     number_handle = await page.evaluate_handle("2")
-    assert str(number_handle) == "JSHandle@2"
+    assert str(number_handle) == "2"
     string_handle = await page.evaluate_handle('"a"')
-    assert str(string_handle) == "JSHandle@a"
+    assert str(string_handle) == "a"
 
 
-async def test_jshandle_to_string_work_for_complicated_objects(page):
+async def test_jshandle_to_string_work_for_complicated_objects(page, browser_name):
     handle = await page.evaluate_handle("window")
-    assert str(handle) == "JSHandle@object"
+    if browser_name != "firefox":
+        assert str(handle) == "Window"
+    else:
+        assert str(handle) == "JSHandle@object"
 
 
 async def test_jshandle_to_string_work_for_promises(page):
     handle = await page.evaluate_handle("({b: Promise.resolve(123)})")
     b_handle = await handle.get_property("b")
-    assert str(b_handle) == "JSHandle@promise"
+    assert str(b_handle) == "Promise"

tests/async/test_worker.py

@@ -63,14 +63,17 @@ async def test_workers_should_report_console_logs(page):
     assert message.text == "1"
 
 
-async def test_workers_should_have_JSHandles_for_console_logs(page):
+async def test_workers_should_have_JSHandles_for_console_logs(page, browser_name):
     log_promise = asyncio.Future()
     page.on("console", lambda m: log_promise.set_result(m))
     await page.evaluate(
         "() => new Worker(URL.createObjectURL(new Blob(['console.log(1,2,3,this)'], {type: 'application/javascript'})))"
     )
     log = await log_promise
-    assert log.text == "1 2 3 JSHandle@object"
+    if browser_name != "firefox":
+        assert log.text == "1 2 3 DedicatedWorkerGlobalScope"
+    else:
+        assert log.text == "1 2 3 JSHandle@object"
     assert len(log.args) == 4
     assert await (await log.args[3].get_property("origin")).json_value() == "null"
 

tests/sync/test_console.py

@@ -17,15 +17,19 @@
 from playwright.sync_api import ConsoleMessage, Page
 
 
-def test_console_should_work(page: Page, server):
+def test_console_should_work(page: Page, browser_name):
     messages: List[ConsoleMessage] = []
     page.once("console", lambda m: messages.append(m))
     with page.expect_console_message():
         page.evaluate('() => console.log("hello", 5, {foo: "bar"})'),
     assert len(messages) == 1
     message = messages[0]
-    assert message.text == "hello 5 JSHandle@object"
-    assert str(message) == "hello 5 JSHandle@object"
+    if browser_name != "firefox":
+        assert message.text == "hello 5 {foo: bar}"
+        assert str(message) == "hello 5 {foo: bar}"
+    else:
+        assert message.text == "hello 5 JSHandle@object"
+        assert str(message) == "hello 5 JSHandle@object"
     assert message.type == "log"
     assert message.args[0].json_value() == "hello"
     assert message.args[1].json_value() == 5
@@ -78,17 +82,20 @@ def test_console_should_work_for_different_console_api_calls(page, server):
         "calling console.dir",
         "calling console.warn",
         "calling console.error",
-        "JSHandle@promise",
+        "Promise",
     ]
 
 
-def test_console_should_not_fail_for_window_object(page: Page, server):
+def test_console_should_not_fail_for_window_object(page: Page, browser_name):
     messages = []
     page.once("console", lambda m: messages.append(m))
     with page.expect_console_message():
         page.evaluate("() => console.error(window)")
     assert len(messages) == 1
-    assert messages[0].text == "JSHandle@object"
+    if browser_name != "firefox":
+        assert messages[0].text == "Window"
+    else:
+        assert messages[0].text == "JSHandle@object"
 
 
 def test_console_should_trigger_correct_Log(page, server):