Run continuation asynchronously in context of events #3256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make Playwright events waiter more friendly with sync-over-async pattern.
Issue
This piece of code demonstrates deadlock. Real code, you can run it (I ran it in NUnit).
Here
GetAwaiter().GetResult()is blocked. We understand that it is anti-pattern,sync-over-async. To fix it we can addawait Task.Yield(). But what if Playwright can be more friendly for dummy users like me?Solution?
This PR allows tasks continuations asynchronously. Now the code above just works.