Addr. comments

Author: chapman73

onnxscript/utils/model_proto_to_function_proto.py

@@ -39,16 +39,14 @@ def _initializers_to_constants(model: onnx.ModelProto) -> onnx.ModelProto:
 
 
 def convert_model_proto_to_function_proto(
-    model: onnx.ModelProto, domain, name
+    model: onnx.ModelProto, domain: str, name: str
 ) -> onnx.FunctionProto:
     """Converts an arbitrary ModelProto to a FunctionProto.
 
     Since function protos don't support initializers (or rather it does not make sense in the context of a function)
     we need to convert them to constants first.
     """
-    model = _initializers_to_constants(
-        model
-    )  # theres some work to do here...maybe contribute to open source?
+    model = _initializers_to_constants(model)
     model_ir = onnx_ir.serde.deserialize_model(model)
     function_ir = onnx_ir.Function(
         domain=domain, name=name, graph=model_ir.graph, attributes={}

tests/utils/model_proto_to_function_proto_test.py

@@ -30,17 +30,12 @@ def diff_square(x, y):
         def sum_func(z):
             return op.ReduceSum(z, keepdims=1)
 
-        @script()
-        def l2norm(x: FLOAT["N"], y: FLOAT["N"]) -> FLOAT[1]:  # noqa: F821
-            return op.Sqrt(sum_func(diff_square(x, y)))
-
         @script()
         def l2norm_with_functions(x: FLOAT["N"], y: FLOAT["N"]) -> FLOAT[1]:  # noqa: F821
             return op.Sqrt(sum_func(diff_square(x, y)))
 
         self.diff_square = diff_square
         self.sum_func = sum_func
-        self.l2norm = l2norm
         self.l2norm_with_functions = l2norm_with_functions
 
     def test_multiple_functions_in_model_proto(self):