Fix Issue #2 ArgumentOutOfRangeException

mdrafiqulrabin · mdrafiqulrabin · commit 5a8981842089 · 2020-03-20T23:44:05.000-05:00
- Median calculation crashes when duplicationFactors.Count==2
- Adding a special case for midpoint calculation would fix this problem
diff --git a/DuplicateCodeDetector/CloneGroups.cs b/DuplicateCodeDetector/CloneGroups.cs
@@ -41,7 +41,7 @@ public CloneGroups(IEnumerable<(string File1, string File2)> clonePairs)
                 Console.WriteLine($"Avg Duplication Factor: {duplicationFactors.Average()}");
                 duplicationFactors.Sort();
                 double median;
-                int midpoint = duplicationFactors.Count / 2;
+                int midpoint = duplicationFactors.Count > 2 ? duplicationFactors.Count / 2 : 0;
                 if (duplicationFactors.Count % 2 == 0)
                 {
                     median = (duplicationFactors[midpoint] + duplicationFactors[midpoint + 1]) / 2;

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public CloneGroups(IEnumerable<(string File1, string File2)> clonePairs)`
`41`	`41`	`Console.WriteLine($"Avg Duplication Factor: {duplicationFactors.Average()}");`
`42`	`42`	`duplicationFactors.Sort();`
`43`	`43`	`double median;`
`44`		`- int midpoint = duplicationFactors.Count / 2;`
	`44`	`+ int midpoint = duplicationFactors.Count > 2 ? duplicationFactors.Count / 2 : 0;`
`45`	`45`	`if (duplicationFactors.Count % 2 == 0)`
`46`	`46`	`{`
`47`	`47`	`median = (duplicationFactors[midpoint] + duplicationFactors[midpoint + 1]) / 2;`