From 3669d45815e8484d29083aeecf5bbabc23e4a2ec Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Wed, 17 Sep 2025 13:22:17 +0200
Subject: [PATCH 1/9] SplitButton needs label

---
 COVERAGE.md                                   |  2 +-
 docs/rules/splitButton-needs-labelling.md     | 41 +++++++++++++++++++
 .../buttons/splitButton-needs-labelling.ts    | 25 +++++++++++
 lib/rules/index.ts                            |  1 +
 .../splitButton-needs-labelling.test.ts       | 39 ++++++++++++++++++
 5 files changed, 107 insertions(+), 1 deletion(-)
 create mode 100644 docs/rules/splitButton-needs-labelling.md
 create mode 100644 lib/rules/buttons/splitButton-needs-labelling.ts
 create mode 100644 tests/lib/rules/buttons/splitButton-needs-labelling.test.ts

diff --git a/COVERAGE.md b/COVERAGE.md
index d65a83b..89b7f91 100644
--- a/COVERAGE.md
+++ b/COVERAGE.md
@@ -15,7 +15,7 @@ We currently cover the following components:
         -   [X] CompoundButton
         -   [] MenuButton
         -   [X] MenuItem
-        -   [] SplitButton
+        -   [x] SplitButton
         -   [x] ToggleButton
         -   [] ToolbarToggleButton
     -   [] Card
diff --git a/docs/rules/splitButton-needs-labelling.md b/docs/rules/splitButton-needs-labelling.md
new file mode 100644
index 0000000..c345421
--- /dev/null
+++ b/docs/rules/splitButton-needs-labelling.md
@@ -0,0 +1,41 @@
+# Accessibility: SplitButton must have an accessible label (`@microsoft/fluentui-jsx-a11y/splitButton-needs-labelling`)
+
+💼 This rule is enabled in the ✅ `recommended` config.
+
+<!-- end auto-generated rule header -->
+
+SplitButton without a label or accessible labeling lack an accessible name for assistive technology users.
+
+SplitButton components need a visual label.
+
+Please add label, or aria-labelledby.
+
+<https://www.w3.org/WAI/standards-guidelines/act/rules/97a4e1/>
+
+## Rule Details
+
+This rule aims to...
+
+Examples of **incorrect** code for this rule:
+
+```jsx
+<SplitButton />
+```
+
+```jsx
+<SplitButton disabled/>
+```
+
+Examples of **correct** code for this rule:
+
+```jsx
+   <SplitButton> Example</SplitButton>
+```
+
+```jsx
+   <SplitButton aria-label="My button"/>
+```
+
+```jsx
+<SplitButton disabled>Disabled State</SplitButton>
+```
\ No newline at end of file
diff --git a/lib/rules/buttons/splitButton-needs-labelling.ts b/lib/rules/buttons/splitButton-needs-labelling.ts
new file mode 100644
index 0000000..10bcda0
--- /dev/null
+++ b/lib/rules/buttons/splitButton-needs-labelling.ts
@@ -0,0 +1,25 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { ESLintUtils } from "@typescript-eslint/utils";
+import { makeLabeledControlRule } from "../../util/ruleFactory";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+export default ESLintUtils.RuleCreator.withoutDocs(
+    makeLabeledControlRule({
+        component: "SplitButton",
+        messageId: "noUnlabeledSplitButton",
+        description: "Accessibility: SplitButton must have an accessible name via title, aria-label",
+        labelProps: ["aria-label"],
+        allowFieldParent: true,
+        allowHtmlFor: false,
+        allowLabelledBy: true,
+        allowWrappingLabel: false,
+        allowTooltipParent: false,
+        allowDescribedBy: false,
+        allowLabeledChild: false
+    })
+);
diff --git a/lib/rules/index.ts b/lib/rules/index.ts
index bfdbe7b..114fa86 100644
--- a/lib/rules/index.ts
+++ b/lib/rules/index.ts
@@ -20,6 +20,7 @@ export { default as inputComponentsRequireAccessibleName } from "./input-compone
 export { default as linkMissingLabelling } from "./link-missing-labelling";
 export { default as menuItemNeedsLabelling } from "./menu-item-needs-labelling";
 export { default as noEmptyButtons } from "./buttons/no-empty-buttons";
+export { default as splitButtonNeedsLabelling } from "./buttons/splitButton-needs-labelling";
 export { default as noEmptyComponents } from "./no-empty-components";
 export { default as preferAriaOverTitleAttribute } from "./prefer-aria-over-title-attribute";
 export { default as progressbarNeedsLabelling } from "./progressbar-needs-labelling";
diff --git a/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts b/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
new file mode 100644
index 0000000..482076e
--- /dev/null
+++ b/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
@@ -0,0 +1,39 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { Rule } from "eslint";
+import ruleTester from "../helper/ruleTester";
+import rule from "../../../../lib/rules/buttons/splitButton-needs-labelling";
+// -----------------------------------------------------------------------------
+// Tests
+// -----------------------------------------------------------------------------
+
+ruleTester.run("splitButton-needs-labelling", rule as unknown as Rule.RuleModule, {
+    valid: [
+        // 1) aria-label on the SplitButton
+
+        `<SplitButton aria-label="Example">Example</SplitButton>
+      `,
+        // 2) Field wrapper with label prop
+        `
+        <SplitButton aria-label="Example" disabled> Disabled State </SplitButton>
+      `
+    ],
+
+    invalid: [
+        // Unlabeled SwatchPicker (children present, but no accessible name)
+        {
+            code: `
+                <SplitButton>Example</SplitButton>
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        {
+            // 7) Native <label> wrapping (implicit label)
+            code: `
+                <SplitButton disabled>Example</SplitButton>
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        }
+    ]
+});

From 1c2091da5445875cd367d7894afb2abc3ad1d6ad Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Wed, 17 Sep 2025 13:41:05 +0200
Subject: [PATCH 2/9] Adding more test

---
 docs/rules/splitButton-needs-labelling.md     | 13 +++----
 .../splitButton-needs-labelling.test.ts       | 34 ++++++++++++++++---
 2 files changed, 35 insertions(+), 12 deletions(-)

diff --git a/docs/rules/splitButton-needs-labelling.md b/docs/rules/splitButton-needs-labelling.md
index c345421..2ed5d60 100644
--- a/docs/rules/splitButton-needs-labelling.md
+++ b/docs/rules/splitButton-needs-labelling.md
@@ -19,23 +19,20 @@ This rule aims to...
 Examples of **incorrect** code for this rule:
 
 ```jsx
-<SplitButton />
+   <SplitButton> Example</SplitButton>
 ```
 
 ```jsx
-<SplitButton disabled/>
+   <SplitButton disabled> Example</SplitButton>
 ```
 
-Examples of **correct** code for this rule:
 
-```jsx
-   <SplitButton> Example</SplitButton>
-```
+Examples of **correct** code for this rule:
 
 ```jsx
-   <SplitButton aria-label="My button"/>
+   <SplitButton aria-label="My button">Example</SplitButton>
 ```
 
 ```jsx
-<SplitButton disabled>Disabled State</SplitButton>
+<SplitButton disabled aria-label="My button">Disabled State</SplitButton>
 ```
\ No newline at end of file
diff --git a/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts b/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
index 482076e..5b478eb 100644
--- a/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
+++ b/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
@@ -14,26 +14,52 @@ ruleTester.run("splitButton-needs-labelling", rule as unknown as Rule.RuleModule
 
         `<SplitButton aria-label="Example">Example</SplitButton>
       `,
-        // 2) Field wrapper with label prop
+        // 2) disabled SplitButton with aria-label
         `
         <SplitButton aria-label="Example" disabled> Disabled State </SplitButton>
-      `
+      `,
+        `<>
+          <span id="splitButton">Choose Values</span>
+          <SplitButton aria-labelledby="splitButton"> Example
+          </SplitButton>
+        </>`
     ],
 
     invalid: [
-        // Unlabeled SwatchPicker (children present, but no accessible name)
+        // Unlabeled SplitButton
         {
             code: `
                 <SplitButton>Example</SplitButton>
             `,
             errors: [{ messageId: "noUnlabeledSplitButton" }]
         },
+        // disabled SplitButton without aria-label
         {
-            // 7) Native <label> wrapping (implicit label)
             code: `
                 <SplitButton disabled>Example</SplitButton>
             `,
             errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton with empty aria-label
+        {
+            code: `
+                <SplitButton aria-label="">Example</SplitButton>
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton with aria-label undefined
+        {
+            code: `
+                <SplitButton aria-label={undefined}>Example</SplitButton>
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton with aria-label null
+        {
+            code: `
+                <SplitButton aria-label={null}>Example</SplitButton>
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
         }
     ]
 });

From d854b46aea1b2395c89efe1bb386bf2be5600b39 Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Wed, 17 Sep 2025 13:46:41 +0200
Subject: [PATCH 3/9] Updating README.md

---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 29e74b0..0ef05aa 100644
--- a/README.md
+++ b/README.md
@@ -137,6 +137,7 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [spin-button-needs-labelling](docs/rules/spin-button-needs-labelling.md)                                               | Accessibility: SpinButtons must have an accessible label                                                                                               | ✅  |    |    |
 | [spin-button-unrecommended-labelling](docs/rules/spin-button-unrecommended-labelling.md)                               | Accessibility: Unrecommended accessibility labelling - SpinButton                                                                                      | ✅  |    |    |
 | [spinner-needs-labelling](docs/rules/spinner-needs-labelling.md)                                                       | Accessibility: Spinner must have either aria-label or label, aria-live and aria-busy attributes                                                        | ✅  |    |    |
+| [splitButton-needs-labelling](docs/rules/splitButton-needs-labelling.md)                                               | Accessibility: SplitButton must have either aria-label or aria-labelledby                                                                              | ✅  |    |    |
 | [swatchpicker-needs-labelling](docs/rules/swatchpicker-needs-labelling.md)                                             | Accessibility: SwatchPicker must have an accessible name via aria-label, aria-labelledby, Field component, etc..                                       | ✅  |    |    |
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                                         | Accessibility: Switch must have an accessible label                                                                                                    | ✅  |    |    |
 | [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                         | ✅  |    |    |

From 527712f80b15307d63f3ec17a340c878be1ac6ad Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 10:52:46 +0200
Subject: [PATCH 4/9] Updating rule

---
 README.md                                                     | 1 -
 lib/index.ts                                                  | 1 +
 lib/rules/index.ts                                            | 2 +-
 lib/rules/{buttons => }/splitButton-needs-labelling.ts        | 2 +-
 ...-labelling.test.ts => splitButton-needs-labelling-test.ts} | 4 ++--
 5 files changed, 5 insertions(+), 5 deletions(-)
 rename lib/rules/{buttons => }/splitButton-needs-labelling.ts (92%)
 rename tests/lib/rules/{buttons/splitButton-needs-labelling.test.ts => splitButton-needs-labelling-test.ts} (94%)

diff --git a/README.md b/README.md
index 0ef05aa..29e74b0 100644
--- a/README.md
+++ b/README.md
@@ -137,7 +137,6 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [spin-button-needs-labelling](docs/rules/spin-button-needs-labelling.md)                                               | Accessibility: SpinButtons must have an accessible label                                                                                               | ✅  |    |    |
 | [spin-button-unrecommended-labelling](docs/rules/spin-button-unrecommended-labelling.md)                               | Accessibility: Unrecommended accessibility labelling - SpinButton                                                                                      | ✅  |    |    |
 | [spinner-needs-labelling](docs/rules/spinner-needs-labelling.md)                                                       | Accessibility: Spinner must have either aria-label or label, aria-live and aria-busy attributes                                                        | ✅  |    |    |
-| [splitButton-needs-labelling](docs/rules/splitButton-needs-labelling.md)                                               | Accessibility: SplitButton must have either aria-label or aria-labelledby                                                                              | ✅  |    |    |
 | [swatchpicker-needs-labelling](docs/rules/swatchpicker-needs-labelling.md)                                             | Accessibility: SwatchPicker must have an accessible name via aria-label, aria-labelledby, Field component, etc..                                       | ✅  |    |    |
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                                         | Accessibility: Switch must have an accessible label                                                                                                    | ✅  |    |    |
 | [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                         | ✅  |    |    |
diff --git a/lib/index.ts b/lib/index.ts
index bbf4bfc..c97b82c 100644
--- a/lib/index.ts
+++ b/lib/index.ts
@@ -44,6 +44,7 @@ module.exports = {
                 "@microsoft/fluentui-jsx-a11y/spin-button-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/spin-button-unrecommended-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/spinner-needs-labelling": "error",
+                "@microsoft/fluentui-jsx-a11y/splitButton-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/swatchpicker-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/switch-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/tablist-and-tabs-need-labelling": "error",
diff --git a/lib/rules/index.ts b/lib/rules/index.ts
index 114fa86..48cb8e4 100644
--- a/lib/rules/index.ts
+++ b/lib/rules/index.ts
@@ -20,7 +20,6 @@ export { default as inputComponentsRequireAccessibleName } from "./input-compone
 export { default as linkMissingLabelling } from "./link-missing-labelling";
 export { default as menuItemNeedsLabelling } from "./menu-item-needs-labelling";
 export { default as noEmptyButtons } from "./buttons/no-empty-buttons";
-export { default as splitButtonNeedsLabelling } from "./buttons/splitButton-needs-labelling";
 export { default as noEmptyComponents } from "./no-empty-components";
 export { default as preferAriaOverTitleAttribute } from "./prefer-aria-over-title-attribute";
 export { default as progressbarNeedsLabelling } from "./progressbar-needs-labelling";
@@ -30,6 +29,7 @@ export { default as ratingNeedsName } from "./rating-needs-name";
 export { default as spinButtonNeedsLabelling } from "./spin-button-needs-labelling";
 export { default as spinButtonUnrecommendedLabelling } from "./spin-button-unrecommended-labelling";
 export { default as spinnerNeedsLabelling } from "./spinner-needs-labelling";
+export { default as splitButtonNeedsLabelling } from "./splitButton-needs-labelling";
 export { default as swatchpickerNeedsLabelling } from "./swatchpicker-needs-labelling";
 export { default as switchNeedsLabelling } from "./switch-needs-labelling";
 export { default as tablistAndTabsNeedLabelling } from "./tablist-and-tabs-need-labelling";
diff --git a/lib/rules/buttons/splitButton-needs-labelling.ts b/lib/rules/splitButton-needs-labelling.ts
similarity index 92%
rename from lib/rules/buttons/splitButton-needs-labelling.ts
rename to lib/rules/splitButton-needs-labelling.ts
index 10bcda0..ee41b78 100644
--- a/lib/rules/buttons/splitButton-needs-labelling.ts
+++ b/lib/rules/splitButton-needs-labelling.ts
@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import { ESLintUtils } from "@typescript-eslint/utils";
-import { makeLabeledControlRule } from "../../util/ruleFactory";
+import { makeLabeledControlRule } from "../util/ruleFactory";
 
 //------------------------------------------------------------------------------
 // Rule Definition
diff --git a/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts b/tests/lib/rules/splitButton-needs-labelling-test.ts
similarity index 94%
rename from tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
rename to tests/lib/rules/splitButton-needs-labelling-test.ts
index 5b478eb..e498a33 100644
--- a/tests/lib/rules/buttons/splitButton-needs-labelling.test.ts
+++ b/tests/lib/rules/splitButton-needs-labelling-test.ts
@@ -2,8 +2,8 @@
 // Licensed under the MIT License.
 
 import { Rule } from "eslint";
-import ruleTester from "../helper/ruleTester";
-import rule from "../../../../lib/rules/buttons/splitButton-needs-labelling";
+import ruleTester from "./helper/ruleTester";
+import rule from "../../../lib/rules/splitButton-needs-labelling";
 // -----------------------------------------------------------------------------
 // Tests
 // -----------------------------------------------------------------------------

From 721fe66db5bc908813487a681aee5c3c6aebc3dd Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 11:08:20 +0200
Subject: [PATCH 5/9] Updating rule name to kebab case

---
 ...ton-needs-labelling.md => split-button-needs-labelling.md} | 2 +-
 lib/index.ts                                                  | 3 ++-
 lib/rules/index.ts                                            | 2 +-
 ...ton-needs-labelling.ts => split-button-needs-labelling.ts} | 0
 ...labelling-test.ts => split-button-needs-labelling-test.ts} | 4 ++--
 5 files changed, 6 insertions(+), 5 deletions(-)
 rename docs/rules/{splitButton-needs-labelling.md => split-button-needs-labelling.md} (93%)
 rename lib/rules/{splitButton-needs-labelling.ts => split-button-needs-labelling.ts} (100%)
 rename tests/lib/rules/{splitButton-needs-labelling-test.ts => split-button-needs-labelling-test.ts} (92%)

diff --git a/docs/rules/splitButton-needs-labelling.md b/docs/rules/split-button-needs-labelling.md
similarity index 93%
rename from docs/rules/splitButton-needs-labelling.md
rename to docs/rules/split-button-needs-labelling.md
index 2ed5d60..aeb4571 100644
--- a/docs/rules/splitButton-needs-labelling.md
+++ b/docs/rules/split-button-needs-labelling.md
@@ -1,4 +1,4 @@
-# Accessibility: SplitButton must have an accessible label (`@microsoft/fluentui-jsx-a11y/splitButton-needs-labelling`)
+# Accessibility: SplitButton must have an accessible label (`@microsoft/fluentui-jsx-a11y/split-button-needs-labelling`)
 
 💼 This rule is enabled in the ✅ `recommended` config.
 
diff --git a/lib/index.ts b/lib/index.ts
index c97b82c..8e5c08b 100644
--- a/lib/index.ts
+++ b/lib/index.ts
@@ -44,7 +44,7 @@ module.exports = {
                 "@microsoft/fluentui-jsx-a11y/spin-button-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/spin-button-unrecommended-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/spinner-needs-labelling": "error",
-                "@microsoft/fluentui-jsx-a11y/splitButton-needs-labelling": "error",
+                "@microsoft/fluentui-jsx-a11y/split-button-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/swatchpicker-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/switch-needs-labelling": "error",
                 "@microsoft/fluentui-jsx-a11y/tablist-and-tabs-need-labelling": "error",
@@ -83,6 +83,7 @@ module.exports = {
         "spin-button-needs-labelling": rules.spinButtonNeedsLabelling,
         "spin-button-unrecommended-labelling": rules.spinButtonUnrecommendedLabelling,
         "spinner-needs-labelling": rules.spinnerNeedsLabelling,
+        "split-button-needs-labelling": rules.splitButtonNeedsLabelling,
         "swatchpicker-needs-labelling": rules.swatchpickerNeedsLabelling,
         "switch-needs-labelling": rules.switchNeedsLabelling,
         "tablist-and-tabs-need-labelling": rules.tablistAndTabsNeedLabelling,
diff --git a/lib/rules/index.ts b/lib/rules/index.ts
index 48cb8e4..5d491e7 100644
--- a/lib/rules/index.ts
+++ b/lib/rules/index.ts
@@ -29,7 +29,7 @@ export { default as ratingNeedsName } from "./rating-needs-name";
 export { default as spinButtonNeedsLabelling } from "./spin-button-needs-labelling";
 export { default as spinButtonUnrecommendedLabelling } from "./spin-button-unrecommended-labelling";
 export { default as spinnerNeedsLabelling } from "./spinner-needs-labelling";
-export { default as splitButtonNeedsLabelling } from "./splitButton-needs-labelling";
+export { default as splitButtonNeedsLabelling } from "./split-button-needs-labelling";
 export { default as swatchpickerNeedsLabelling } from "./swatchpicker-needs-labelling";
 export { default as switchNeedsLabelling } from "./switch-needs-labelling";
 export { default as tablistAndTabsNeedLabelling } from "./tablist-and-tabs-need-labelling";
diff --git a/lib/rules/splitButton-needs-labelling.ts b/lib/rules/split-button-needs-labelling.ts
similarity index 100%
rename from lib/rules/splitButton-needs-labelling.ts
rename to lib/rules/split-button-needs-labelling.ts
diff --git a/tests/lib/rules/splitButton-needs-labelling-test.ts b/tests/lib/rules/split-button-needs-labelling-test.ts
similarity index 92%
rename from tests/lib/rules/splitButton-needs-labelling-test.ts
rename to tests/lib/rules/split-button-needs-labelling-test.ts
index e498a33..5723185 100644
--- a/tests/lib/rules/splitButton-needs-labelling-test.ts
+++ b/tests/lib/rules/split-button-needs-labelling-test.ts
@@ -3,12 +3,12 @@
 
 import { Rule } from "eslint";
 import ruleTester from "./helper/ruleTester";
-import rule from "../../../lib/rules/splitButton-needs-labelling";
+import rule from "../../../lib/rules/split-button-needs-labelling";
 // -----------------------------------------------------------------------------
 // Tests
 // -----------------------------------------------------------------------------
 
-ruleTester.run("splitButton-needs-labelling", rule as unknown as Rule.RuleModule, {
+ruleTester.run("split-button-needs-labelling", rule as unknown as Rule.RuleModule, {
     valid: [
         // 1) aria-label on the SplitButton
 

From 3d440ace451f7eef8f08f79b3b90071cc61b20ec Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 11:10:26 +0200
Subject: [PATCH 6/9] Updating README.md

---
 README.md                                  | 1 +
 docs/rules/split-button-needs-labelling.md | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 29e74b0..63dc647 100644
--- a/README.md
+++ b/README.md
@@ -137,6 +137,7 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [spin-button-needs-labelling](docs/rules/spin-button-needs-labelling.md)                                               | Accessibility: SpinButtons must have an accessible label                                                                                               | ✅  |    |    |
 | [spin-button-unrecommended-labelling](docs/rules/spin-button-unrecommended-labelling.md)                               | Accessibility: Unrecommended accessibility labelling - SpinButton                                                                                      | ✅  |    |    |
 | [spinner-needs-labelling](docs/rules/spinner-needs-labelling.md)                                                       | Accessibility: Spinner must have either aria-label or label, aria-live and aria-busy attributes                                                        | ✅  |    |    |
+| [split-button-needs-labelling](docs/rules/split-button-needs-labelling.md)                                             | Accessibility: SplitButton must have an accessible name via title, aria-label                                                                          | ✅  |    |    |
 | [swatchpicker-needs-labelling](docs/rules/swatchpicker-needs-labelling.md)                                             | Accessibility: SwatchPicker must have an accessible name via aria-label, aria-labelledby, Field component, etc..                                       | ✅  |    |    |
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                                         | Accessibility: Switch must have an accessible label                                                                                                    | ✅  |    |    |
 | [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                         | ✅  |    |    |
diff --git a/docs/rules/split-button-needs-labelling.md b/docs/rules/split-button-needs-labelling.md
index aeb4571..df29500 100644
--- a/docs/rules/split-button-needs-labelling.md
+++ b/docs/rules/split-button-needs-labelling.md
@@ -1,4 +1,4 @@
-# Accessibility: SplitButton must have an accessible label (`@microsoft/fluentui-jsx-a11y/split-button-needs-labelling`)
+# Accessibility: SplitButton must have an accessible name via title, aria-label (`@microsoft/fluentui-jsx-a11y/split-button-needs-labelling`)
 
 💼 This rule is enabled in the ✅ `recommended` config.
 

From cd6d8503ad1f030c1ec05c7f0fa7ade86808bc53 Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 14:55:26 +0200
Subject: [PATCH 7/9] Updating rule

---
 docs/rules/split-button-needs-labelling.md    | 28 ++++--
 lib/rules/split-button-needs-labelling.ts     | 80 ++++++++++++-----
 .../split-button-needs-labelling-test.ts      | 65 --------------
 .../split-button-needs-labelling.test.ts      | 86 +++++++++++++++++++
 4 files changed, 165 insertions(+), 94 deletions(-)
 delete mode 100644 tests/lib/rules/split-button-needs-labelling-test.ts
 create mode 100644 tests/lib/rules/split-button-needs-labelling.test.ts

diff --git a/docs/rules/split-button-needs-labelling.md b/docs/rules/split-button-needs-labelling.md
index df29500..899f410 100644
--- a/docs/rules/split-button-needs-labelling.md
+++ b/docs/rules/split-button-needs-labelling.md
@@ -16,23 +16,33 @@ Please add label, or aria-labelledby.
 
 This rule aims to...
 
-Examples of **incorrect** code for this rule:
+Example of **incorrect** code for this rule:
 
 ```jsx
-   <SplitButton> Example</SplitButton>
+   <SplitButton
+      menuButton={triggerProps}
+      primaryActionButton={primaryActionButtonProps}
+   />
 ```
 
-```jsx
-   <SplitButton disabled> Example</SplitButton>
-```
-
-
 Examples of **correct** code for this rule:
 
 ```jsx
-   <SplitButton aria-label="My button">Example</SplitButton>
+   <SplitButton
+      menuButton={triggerProps}
+      primaryActionButton={primaryActionButtonProps}
+   >
+      Example
+   </SplitButton>
 ```
 
 ```jsx
-<SplitButton disabled aria-label="My button">Disabled State</SplitButton>
+<SplitButton
+   menuButton={triggerProps}
+   primaryActionButton={{
+      ref: setPrimaryActionButtonRef,
+      "aria-label": "With calendar icon only",
+   }}
+   icon={<CalendarMonthRegular />}
+   />
 ```
\ No newline at end of file
diff --git a/lib/rules/split-button-needs-labelling.ts b/lib/rules/split-button-needs-labelling.ts
index ee41b78..ad9a2ff 100644
--- a/lib/rules/split-button-needs-labelling.ts
+++ b/lib/rules/split-button-needs-labelling.ts
@@ -1,25 +1,65 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-import { ESLintUtils } from "@typescript-eslint/utils";
-import { makeLabeledControlRule } from "../util/ruleFactory";
+import { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
+import { elementType } from "jsx-ast-utils";
+import { JSXOpeningElement } from "estree-jsx";
 
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
+export default ESLintUtils.RuleCreator.withoutDocs({
+    meta: {
+        type: "problem",
+        docs: {
+            description: "Accessibility: SplitButton must have text content or accessible name on primaryActionButton prop.",
+            recommended: "strict",
+            url: "https://www.w3.org/WAI/standards-guidelines/act/rules/97a4e1/"
+        },
+        messages: {
+            noUnlabeledSplitButton:
+                "SplitButton must have text content, or an accessible name on the primaryActionButton prop (e.g., aria-label). Labeling the SplitButton itself is not valid."
+        },
+        schema: []
+    },
+    defaultOptions: [],
+    create(context) {
+        return {
+            JSXElement(node: TSESTree.JSXElement) {
+                const opening = node.openingElement;
+                const name = elementType(opening as unknown as JSXOpeningElement);
+                if (name !== "SplitButton") return;
 
-export default ESLintUtils.RuleCreator.withoutDocs(
-    makeLabeledControlRule({
-        component: "SplitButton",
-        messageId: "noUnlabeledSplitButton",
-        description: "Accessibility: SplitButton must have an accessible name via title, aria-label",
-        labelProps: ["aria-label"],
-        allowFieldParent: true,
-        allowHtmlFor: false,
-        allowLabelledBy: true,
-        allowWrappingLabel: false,
-        allowTooltipParent: false,
-        allowDescribedBy: false,
-        allowLabeledChild: false
-    })
-);
+                // 1. Check for any non-empty text child
+                const hasTextContent = node.children.some(child => child.type === "JSXText" && child.value.trim().length > 0);
+                if (hasTextContent) return;
+
+                // 2. Check for primaryActionButton prop with aria-label
+                const primaryActionButtonProp = opening.attributes.find(
+                    attr => attr.type === "JSXAttribute" && attr.name.name === "primaryActionButton"
+                );
+                if (
+                    primaryActionButtonProp &&
+                    primaryActionButtonProp.type === "JSXAttribute" &&
+                    primaryActionButtonProp.value &&
+                    primaryActionButtonProp.value.type === "JSXExpressionContainer"
+                ) {
+                    const expr = primaryActionButtonProp.value.expression;
+                    // Only handle object literals
+                    if (expr.type === "ObjectExpression") {
+                        const hasAriaLabel = expr.properties.some(
+                            prop =>
+                                prop.type === "Property" &&
+                                ((prop.key.type === "Identifier" && prop.key.name === "aria-label") ||
+                                    (prop.key.type === "Literal" && prop.key.value === "aria-label")) &&
+                                prop.value.type === "Literal" &&
+                                typeof prop.value.value === "string" &&
+                                prop.value.value.trim().length > 0
+                        );
+                        if (hasAriaLabel) return;
+                    }
+                }
+
+                // 3. Otherwise, report error
+                context.report({ node: opening, messageId: "noUnlabeledSplitButton" });
+            }
+        };
+    }
+});
diff --git a/tests/lib/rules/split-button-needs-labelling-test.ts b/tests/lib/rules/split-button-needs-labelling-test.ts
deleted file mode 100644
index 5723185..0000000
--- a/tests/lib/rules/split-button-needs-labelling-test.ts
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-
-import { Rule } from "eslint";
-import ruleTester from "./helper/ruleTester";
-import rule from "../../../lib/rules/split-button-needs-labelling";
-// -----------------------------------------------------------------------------
-// Tests
-// -----------------------------------------------------------------------------
-
-ruleTester.run("split-button-needs-labelling", rule as unknown as Rule.RuleModule, {
-    valid: [
-        // 1) aria-label on the SplitButton
-
-        `<SplitButton aria-label="Example">Example</SplitButton>
-      `,
-        // 2) disabled SplitButton with aria-label
-        `
-        <SplitButton aria-label="Example" disabled> Disabled State </SplitButton>
-      `,
-        `<>
-          <span id="splitButton">Choose Values</span>
-          <SplitButton aria-labelledby="splitButton"> Example
-          </SplitButton>
-        </>`
-    ],
-
-    invalid: [
-        // Unlabeled SplitButton
-        {
-            code: `
-                <SplitButton>Example</SplitButton>
-            `,
-            errors: [{ messageId: "noUnlabeledSplitButton" }]
-        },
-        // disabled SplitButton without aria-label
-        {
-            code: `
-                <SplitButton disabled>Example</SplitButton>
-            `,
-            errors: [{ messageId: "noUnlabeledSplitButton" }]
-        },
-        // SplitButton with empty aria-label
-        {
-            code: `
-                <SplitButton aria-label="">Example</SplitButton>
-            `,
-            errors: [{ messageId: "noUnlabeledSplitButton" }]
-        },
-        // SplitButton with aria-label undefined
-        {
-            code: `
-                <SplitButton aria-label={undefined}>Example</SplitButton>
-            `,
-            errors: [{ messageId: "noUnlabeledSplitButton" }]
-        },
-        // SplitButton with aria-label null
-        {
-            code: `
-                <SplitButton aria-label={null}>Example</SplitButton>
-            `,
-            errors: [{ messageId: "noUnlabeledSplitButton" }]
-        }
-    ]
-});
diff --git a/tests/lib/rules/split-button-needs-labelling.test.ts b/tests/lib/rules/split-button-needs-labelling.test.ts
new file mode 100644
index 0000000..a5e38ab
--- /dev/null
+++ b/tests/lib/rules/split-button-needs-labelling.test.ts
@@ -0,0 +1,86 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { Rule } from "eslint";
+import ruleTester from "./helper/ruleTester";
+import rule from "../../../lib/rules/split-button-needs-labelling";
+// -----------------------------------------------------------------------------
+// Tests
+// -----------------------------------------------------------------------------
+
+ruleTester.run("split-button-needs-labelling", rule as unknown as Rule.RuleModule, {
+    valid: [
+        // 1) aria-label on the SplitButton
+
+        `<SplitButton
+          menuButton={triggerProps}
+          primaryActionButton={primaryActionButtonProps}
+        >
+          Example
+        </SplitButton>
+      `,
+        // 2) with primaryActionButton prop having aria-label
+        `
+        <SplitButton
+         menuButton={triggerProps}
+         primaryActionButton={{
+           ref: setPrimaryActionButtonRef,
+           "aria-label": "With calendar icon only",
+         }}
+         icon={<CalendarMonthRegular />}
+       />
+      `
+    ],
+
+    invalid: [
+        // Unlabeled SplitButton
+        {
+            code: `
+                <SplitButton
+                menuButton={triggerProps}
+                primaryActionButton={primaryActionButtonProps}
+                 />
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton empty aria-label
+        {
+            code: `
+               <SplitButton
+                menuButton={triggerProps}
+                primaryActionButton={{
+                    ref: setPrimaryActionButtonRef,
+                    "aria-label": "",
+                }}
+                 />
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton with aria-label null
+        {
+            code: `
+                <SplitButton
+                menuButton={triggerProps}
+                primaryActionButton={{
+                    ref: setPrimaryActionButtonRef,
+                    "aria-label": null,
+                }}
+                 />
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        },
+        // SplitButton with aria-label undefined
+        {
+            code: `
+               <SplitButton
+                menuButton={triggerProps}
+                primaryActionButton={{
+                    ref: setPrimaryActionButtonRef,
+                    "aria-label": undefined,
+                }}
+                 />
+            `,
+            errors: [{ messageId: "noUnlabeledSplitButton" }]
+        }
+    ]
+});

From 8b1e6073cf3627c152518a311f9da201ca7cf5d8 Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 14:57:29 +0200
Subject: [PATCH 8/9] Updating doc

---
 README.md                                  | 2 +-
 docs/rules/split-button-needs-labelling.md | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 0533f8f..2d0739b 100644
--- a/README.md
+++ b/README.md
@@ -140,7 +140,7 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [spin-button-needs-labelling](docs/rules/spin-button-needs-labelling.md)                                               | Accessibility: SpinButtons must have an accessible label                                                                                               | ✅  |    |    |
 | [spin-button-unrecommended-labelling](docs/rules/spin-button-unrecommended-labelling.md)                               | Accessibility: Unrecommended accessibility labelling - SpinButton                                                                                      | ✅  |    |    |
 | [spinner-needs-labelling](docs/rules/spinner-needs-labelling.md)                                                       | Accessibility: Spinner must have either aria-label or label, aria-live and aria-busy attributes                                                        | ✅  |    |    |
-| [split-button-needs-labelling](docs/rules/split-button-needs-labelling.md)                                             | Accessibility: SplitButton must have an accessible name via title, aria-label                                                                          | ✅  |    |    |
+| [split-button-needs-labelling](docs/rules/split-button-needs-labelling.md)                                             | Accessibility: SplitButton must have text content or accessible name on primaryActionButton prop.                                                      | ✅  |    |    |
 | [swatchpicker-needs-labelling](docs/rules/swatchpicker-needs-labelling.md)                                             | Accessibility: SwatchPicker must have an accessible name via aria-label, aria-labelledby, Field component, etc..                                       | ✅  |    |    |
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                                         | Accessibility: Switch must have an accessible label                                                                                                    | ✅  |    |    |
 | [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                         | ✅  |    |    |
diff --git a/docs/rules/split-button-needs-labelling.md b/docs/rules/split-button-needs-labelling.md
index 899f410..ce42685 100644
--- a/docs/rules/split-button-needs-labelling.md
+++ b/docs/rules/split-button-needs-labelling.md
@@ -1,4 +1,4 @@
-# Accessibility: SplitButton must have an accessible name via title, aria-label (`@microsoft/fluentui-jsx-a11y/split-button-needs-labelling`)
+# Accessibility: SplitButton must have text content or accessible name on primaryActionButton prop (`@microsoft/fluentui-jsx-a11y/split-button-needs-labelling`)
 
 💼 This rule is enabled in the ✅ `recommended` config.
 
@@ -22,6 +22,7 @@ Example of **incorrect** code for this rule:
    <SplitButton
       menuButton={triggerProps}
       primaryActionButton={primaryActionButtonProps}
+      icon={<CalendarMonthRegular />}
    />
 ```
 

From 46cb3f30d50ee895af63470ebd194e09c7d42599 Mon Sep 17 00:00:00 2001
From: Aditi Ojha <aditiojha@microsoft.com>
Date: Thu, 18 Sep 2025 15:31:30 +0200
Subject: [PATCH 9/9] Updating rule to use with factory function

---
 lib/rules/split-button-needs-labelling.ts | 110 +++++++++++-----------
 lib/util/ruleFactory.ts                   |  11 ++-
 2 files changed, 63 insertions(+), 58 deletions(-)

diff --git a/lib/rules/split-button-needs-labelling.ts b/lib/rules/split-button-needs-labelling.ts
index ad9a2ff..139bb35 100644
--- a/lib/rules/split-button-needs-labelling.ts
+++ b/lib/rules/split-button-needs-labelling.ts
@@ -2,64 +2,64 @@
 // Licensed under the MIT License.
 
 import { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
-import { elementType } from "jsx-ast-utils";
-import { JSXOpeningElement } from "estree-jsx";
+import { makeLabeledControlRule } from "../util/ruleFactory";
 
-export default ESLintUtils.RuleCreator.withoutDocs({
-    meta: {
-        type: "problem",
-        docs: {
+export default ESLintUtils.RuleCreator.withoutDocs(
+    makeLabeledControlRule(
+        {
+            component: "SplitButton",
+            messageId: "noUnlabeledSplitButton",
             description: "Accessibility: SplitButton must have text content or accessible name on primaryActionButton prop.",
-            recommended: "strict",
-            url: "https://www.w3.org/WAI/standards-guidelines/act/rules/97a4e1/"
+            labelProps: [],
+            allowFieldParent: false,
+            allowHtmlFor: false,
+            allowLabelledBy: false,
+            allowWrappingLabel: false,
+            allowTooltipParent: false,
+            allowDescribedBy: false,
+            allowLabeledChild: false,
+            allowTextContentChild: false
         },
-        messages: {
-            noUnlabeledSplitButton:
-                "SplitButton must have text content, or an accessible name on the primaryActionButton prop (e.g., aria-label). Labeling the SplitButton itself is not valid."
-        },
-        schema: []
-    },
-    defaultOptions: [],
-    create(context) {
-        return {
-            JSXElement(node: TSESTree.JSXElement) {
-                const opening = node.openingElement;
-                const name = elementType(opening as unknown as JSXOpeningElement);
-                if (name !== "SplitButton") return;
-
-                // 1. Check for any non-empty text child
-                const hasTextContent = node.children.some(child => child.type === "JSXText" && child.value.trim().length > 0);
-                if (hasTextContent) return;
+        isSplitButtonAccessiblyLabeled
+    )
+);
 
-                // 2. Check for primaryActionButton prop with aria-label
-                const primaryActionButtonProp = opening.attributes.find(
-                    attr => attr.type === "JSXAttribute" && attr.name.name === "primaryActionButton"
-                );
-                if (
-                    primaryActionButtonProp &&
-                    primaryActionButtonProp.type === "JSXAttribute" &&
-                    primaryActionButtonProp.value &&
-                    primaryActionButtonProp.value.type === "JSXExpressionContainer"
-                ) {
-                    const expr = primaryActionButtonProp.value.expression;
-                    // Only handle object literals
-                    if (expr.type === "ObjectExpression") {
-                        const hasAriaLabel = expr.properties.some(
-                            prop =>
-                                prop.type === "Property" &&
-                                ((prop.key.type === "Identifier" && prop.key.name === "aria-label") ||
-                                    (prop.key.type === "Literal" && prop.key.value === "aria-label")) &&
-                                prop.value.type === "Literal" &&
-                                typeof prop.value.value === "string" &&
-                                prop.value.value.trim().length > 0
-                        );
-                        if (hasAriaLabel) return;
-                    }
-                }
+/**
+ * Custom accessibility checker for SplitButton:
+ * 1. Accessible if it has any non-empty text child.
+ * 2. If not, must have primaryActionButton prop with aria-label.
+ * 3. All other labeling strategies are invalid.
+ */
+export function isSplitButtonAccessiblyLabeled(node: TSESTree.JSXElement): boolean {
+    // 1. Check for any non-empty text child
+    const hasTextContent = node.children.some(child => child.type === "JSXText" && child.value.trim().length > 0);
+    if (hasTextContent) return true;
 
-                // 3. Otherwise, report error
-                context.report({ node: opening, messageId: "noUnlabeledSplitButton" });
-            }
-        };
+    // 2. Check for primaryActionButton prop with aria-label
+    const opening = node.openingElement;
+    const primaryActionButtonProp = opening.attributes.find(
+        attr => attr.type === "JSXAttribute" && attr.name.name === "primaryActionButton"
+    );
+    if (
+        primaryActionButtonProp &&
+        primaryActionButtonProp.type === "JSXAttribute" &&
+        primaryActionButtonProp.value &&
+        primaryActionButtonProp.value.type === "JSXExpressionContainer"
+    ) {
+        const expr = primaryActionButtonProp.value.expression;
+        // Only handle object literals
+        if (expr.type === "ObjectExpression") {
+            const hasAriaLabel = expr.properties.some(
+                prop =>
+                    prop.type === "Property" &&
+                    ((prop.key.type === "Identifier" && prop.key.name === "aria-label") ||
+                        (prop.key.type === "Literal" && prop.key.value === "aria-label")) &&
+                    prop.value.type === "Literal" &&
+                    typeof prop.value.value === "string" &&
+                    prop.value.value.trim().length > 0
+            );
+            if (hasAriaLabel) return true;
+        }
     }
-});
+    return false;
+}
diff --git a/lib/util/ruleFactory.ts b/lib/util/ruleFactory.ts
index 17352ce..dfa863d 100644
--- a/lib/util/ruleFactory.ts
+++ b/lib/util/ruleFactory.ts
@@ -82,7 +82,11 @@ export function hasAccessibleLabel(
  * Factory for a minimal, strongly-configurable ESLint rule that enforces
  * accessible labeling on a specific JSX element/component.
  */
-export function makeLabeledControlRule(config: LabeledControlConfig): TSESLint.RuleModule<string, []> {
+
+// eslint-disable-next-line no-unused-vars
+type CustomChecker = (node: TSESTree.JSXElement, context: TSESLint.RuleContext<string, []>) => boolean;
+
+export function makeLabeledControlRule(config: LabeledControlConfig, customChecker?: CustomChecker): TSESLint.RuleModule<string, []> {
     return {
         meta: {
             type: "problem",
@@ -105,8 +109,9 @@ export function makeLabeledControlRule(config: LabeledControlConfig): TSESLint.R
 
                     if (!matches) return;
 
-                    if (!hasAccessibleLabel(opening, node, context, config)) {
-                        // report on the opening tag for better location
+                    const isAccessible = customChecker ? customChecker(node, context) : hasAccessibleLabel(opening, node, context, config);
+
+                    if (!isAccessible) {
                         context.report({ node: opening, messageId: config.messageId });
                     }
                 }