Add unit test for hasValidNestedProp

Author: Iryna Vasylenko

tests/lib/rules/utils/hasValidNestedProp.test.ts

@@ -0,0 +1,45 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+jest.mock("jsx-ast-utils", () => ({
+    getProp: jest.fn(),
+    getPropValue: jest.fn()
+}));
+
+import { getProp, getPropValue } from "jsx-ast-utils";
+import { hasValidNestedProp } from "../../../../lib/util/hasValidNestedProp";
+
+describe("hasValidNestedProp", () => {
+    const opening = { attributes: [] } as any;
+
+    beforeEach(() => {
+        (getProp as jest.Mock).mockReset();
+        (getPropValue as jest.Mock).mockReset();
+    });
+
+    test("returns false when the prop is not present (e.g. <Tag />)", () => {
+        // Example: <Tag />
+        (getProp as jest.Mock).mockReturnValue(undefined);
+        const result = hasValidNestedProp(opening, "dismissIcon", "aria-label");
+        expect(result).toBe(false);
+        expect(getProp).toHaveBeenCalledWith(opening.attributes, "dismissIcon");
+    });
+
+    test("returns false when nested key is missing or empty string", () => {
+        // Example: <Tag dismissIcon={{}} />
+        (getProp as jest.Mock).mockReturnValue({});
+        (getPropValue as jest.Mock).mockReturnValue({});
+        expect(hasValidNestedProp(opening, "dismissIcon", "aria-label")).toBe(false);
+
+        // Example: <Tag dismissIcon={{ "aria-label": "   " }} />
+        (getPropValue as jest.Mock).mockReturnValue({ "aria-label": "   " });
+        expect(hasValidNestedProp(opening, "dismissIcon", "aria-label")).toBe(false);
+    });
+
+    test("returns true when nested key is a non-empty string (e.g. <Tag dismissIcon={{ 'aria-label': 'Dismiss' }} />)", () => {
+        // Example: <Tag dismissIcon={{ "aria-label": "Dismiss" }} />
+        (getProp as jest.Mock).mockReturnValue({});
+        (getPropValue as jest.Mock).mockReturnValue({ "aria-label": "Dismiss" });
+        expect(hasValidNestedProp(opening, "dismissIcon", "aria-label")).toBe(true);
+    });
+});

tests/lib/rules/utils/ruleFactory.test.ts

@@ -107,7 +107,7 @@ describe("hasAccessibleLabel (unit)", () => {
         getSourceCode: jest.fn()
     } as unknown as TSESLint.RuleContext<string, []>;
 
-    const cfg: Required<LabeledControlConfig> = {
+    const cfg: LabeledControlConfig = {
         component: "RadioGroup",
         requiredProps: ["alt"],
         labelProps: ["label", "aria-label"],
@@ -120,9 +120,7 @@ describe("hasAccessibleLabel (unit)", () => {
         messageId: "errorMsg",
         description: "anything",
         allowLabeledChild: true,
-        allowTextContentChild: true,
-        triggerProp: "",
-        customValidator: jest.fn().mockReturnValue(false)
+        allowTextContentChild: true
     };
 
     test("returns false when no heuristics pass", () => {
@@ -294,7 +292,7 @@ describe("hasAccessibleLabel (unit)", () => {
 const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } });
 
 describe("makeLabeledControlRule (RuleTester integration)", () => {
-    const baseCfg: Required<LabeledControlConfig> = {
+    const baseCfg: LabeledControlConfig = {
         component: "RadioGroup",
         requiredProps: ["alt"],
         labelProps: ["label", "aria-label"],
@@ -307,9 +305,7 @@ describe("makeLabeledControlRule (RuleTester integration)", () => {
         messageId: "noUnlabeledRadioGroup",
         description: "Accessibility: RadioGroup must have a programmatic and visual label.",
         allowLabeledChild: true,
-        allowTextContentChild: true,
-        triggerProp: "",
-        customValidator: jest.mock
+        allowTextContentChild: true
     };
 
     // 1) No heuristics -> report