Skip to content

Commit d7dcddd

Browse files
authored
Merge pull request #159 from microsoft/users/aubreyquinn/recomendedPlugins
Users/aubreyquinn/recomended plugins
2 parents bdb6ed2 + 848ef65 commit d7dcddd

File tree

3 files changed

+43
-1
lines changed

3 files changed

+43
-1
lines changed

.vscode/extensions.json

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,10 @@
1-
{ "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"] }
1+
{
2+
"recommendations": [
3+
"dbaeumer.vscode-eslint",
4+
"firsttris.vscode-jest-runner",
5+
"esbenp.prettier-vscode",
6+
"rvest.vs-code-prettier-eslint",
7+
"DavidAnson.vscode-markdownlint",
8+
"streetsidesoftware.code-spell-checker-cspell-bundled-dictionaries"
9+
]
10+
}

CONTRIBUTING.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any addi
2222

2323
- Install [Visual Studio Code](https://code.visualstudio.com/).
2424

25+
- Install the [recommended plugins](#recommended-vs-code-extensions) for [Visual Studio Code](https://code.visualstudio.com/).
26+
2527
- Install [Node.js](https://nodejs.org/en/), with [nvm](https://github.com/nvm-sh/nvm). Please use Node version 16 and npm v 8.
2628

2729
- Install [jscodeshift](https://github.com/facebook/jscodeshift) globally.
@@ -49,6 +51,16 @@ or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any addi
4951

5052
- Make and submit changes following the [pull request submission workflow](#pull-requests)
5153

54+
## Recommended VS Code Extensions
55+
56+
To ensure a consistent and productive development environment, install the following extensions in Visual Studio Code:
57+
58+
- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) — Linting for JavaScript/TypeScript.
59+
- [Jest Runner](https://marketplace.visualstudio.com/items?itemName=firsttris.vscode-jest-runner) — Run or debug Jest tests from context menu.
60+
- [Prettier - Code formatter](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) — Code formatting using Prettier.
61+
- [Prettier ESLint](https://marketplace.visualstudio.com/items?itemName=rvest.vs-code-prettier-eslint) — Format code with Prettier and ESLint integration.
62+
- [markdownlint](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint) — Linting and style checks for Markdown files.
63+
5264
## To create a new ESLint rule
5365

5466
If you want to create a new ESLint rule:

KNOWN_ISSUES.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Known Issues
2+
3+
## No object props deconstruction
4+
5+
We currently do not support object props deconstruction.
6+
7+
e.g.
8+
9+
```tsx
10+
const buttonProps = {
11+
icon: <Calendar />,
12+
aria-label: 'start date'
13+
};
14+
15+
<Button {...buttonProps} />
16+
17+
```
18+
19+
Unfortunately, these will not be picked up by our linter. However, we hope to support this soon 🚀
20+
21+
See [issue #149](https://github.com/microsoft/eslint-plugin-fluentui-jsx-a11y/issues/149) for details.

0 commit comments

Comments
 (0)