Merge pull request #138 from microsoft/users/aubreyquinn/reactStrictModeBug

Fixes #136

Author: aubreyquinn

lib/rules/accordion-item-needs-header-and-panel.ts

@@ -25,9 +25,11 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({
     create(context) {
         return {
             JSXOpeningElement(node: TSESTree.JSXOpeningElement) {
-                if (node.name.type === AST_NODE_TYPES.JSXIdentifier && node.name.name !== "AccordionItem") {
-                    return;
-                }
+                const isAccordionItem =
+                    node.name.type === AST_NODE_TYPES.JSXIdentifier &&
+                    node.name.name === "AccordionItem";
+
+                if (!isAccordionItem) return;
 
                 if (!(node.parent && node.parent.type === AST_NODE_TYPES.JSXElement)) {
                     return;

lib/rules/dialogbody-needs-title-content-and-actions.ts

@@ -25,7 +25,11 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({
     create(context) {
         return {
             JSXOpeningElement(node: TSESTree.JSXOpeningElement) {
-                if (node.name.type === AST_NODE_TYPES.JSXIdentifier && node.name.name !== "DialogBody") {
+                const isDialogBody =
+                    node.name.type === AST_NODE_TYPES.JSXIdentifier &&
+                    node.name.name === "DialogBody";
+
+                if (!isDialogBody) {
                     return;
                 }
 

package-lock.json

@@ -15,7 +15,8 @@ import rule from "../../../lib/rules/accordion-item-needs-header-and-panel";
 
 ruleTester.run("accordion-item-needs-header-and-panel", rule as unknown as Rule.RuleModule, {
     valid: [
-        `<AccordionItem><AccordionHeader>Accordion Header 1</AccordionHeader><AccordionPanel><div>Accordion Panel 1</div></AccordionPanel></AccordionItem>`
+        `<AccordionItem><AccordionHeader>Accordion Header 1</AccordionHeader><AccordionPanel><div>Accordion Panel 1</div></AccordionPanel></AccordionItem>`,
+        `<React.StrictMode><Component /></React.StrictMode>`
     ],
 
     invalid: [

tests/lib/rules/accordion-item-needs-header-and-panel.test.ts

@@ -22,7 +22,8 @@ ruleTester.run("dialogbody-needs-title-content-and-actions", rule as any as Rule
                 <Button>Close</Button>
                 <Button>Do Something</Button>
             </DialogActions>
-        </DialogBody>`
+        </DialogBody>`,
+        `<React.StrictMode><Component /></React.StrictMode>`
     ],
 
     invalid: [