Remove comments

Author: sidhsharma1992

lib/util/hasLabeledChild.ts

@@ -24,38 +24,30 @@ import { hasAssociatedAriaText } from "./labelUtils";
  */
 export const hasLabeledChild = (openingElement: TSESTree.JSXOpeningElement, context: TSESLint.RuleContext<string, unknown[]>): boolean => {
     try {
-        // Find the parent JSX element - it should be the immediate parent of the opening element
         let node: TSESTree.JSXElement | null = null;
 
-        // The openingElement's parent should be the JSXElement
         if (openingElement.parent && openingElement.parent.type === "JSXElement") {
             node = openingElement.parent as TSESTree.JSXElement;
         }
 
-        // If no parent node or no children, return false
         if (!node?.children || node.children.length === 0) {
             return false;
         }
 
-        // Get all child elements (flattened to handle nested structures)
         const allChildren = flattenChildren(node);
 
-        // Check if any child has accessible labeling
         return allChildren.some(child => {
             if (child.type === "JSXElement") {
                 const childOpeningElement = child.openingElement;
                 const childName = childOpeningElement.name;
 
-                // Check if child is an element that can provide accessible names
                 if (childName.type === "JSXIdentifier") {
                     const tagName = childName.name.toLowerCase();
 
-                    // Image elements with alt text
                     if ((tagName === "img" || tagName === "image") && hasNonEmptyProp(childOpeningElement.attributes, "alt")) {
                         return true;
                     }
 
-                    // SVG elements with title or aria-label
                     if (tagName === "svg") {
                         return (
                             hasNonEmptyProp(childOpeningElement.attributes, "title") ||
@@ -64,13 +56,11 @@ export const hasLabeledChild = (openingElement: TSESTree.JSXOpeningElement, cont
                         );
                     }
 
-                    // Elements with role="img" and aria-label (like icons, emojis)
                     if (hasNonEmptyProp(childOpeningElement.attributes, "role")) {
                         const roleProp = childOpeningElement.attributes.find(
                             attr => attr.type === "JSXAttribute" && attr.name?.type === "JSXIdentifier" && attr.name.name === "role"
                         );
 
-                        // Type guard to ensure we have a JSXAttribute with a value
                         if (roleProp?.type === "JSXAttribute" && roleProp.value?.type === "Literal" && roleProp.value.value === "img") {
                             return (
                                 hasNonEmptyProp(childOpeningElement.attributes, "aria-label") ||
@@ -79,7 +69,6 @@ export const hasLabeledChild = (openingElement: TSESTree.JSXOpeningElement, cont
                         }
                     }
 
-                    // FluentUI Icon components or any element with aria-label/title/aria-labelledby
                     if (
                         tagName.toLowerCase().includes("icon") ||
                         hasNonEmptyProp(childOpeningElement.attributes, "aria-label") ||
@@ -94,7 +83,6 @@ export const hasLabeledChild = (openingElement: TSESTree.JSXOpeningElement, cont
             return false;
         });
     } catch (error) {
-        // Fail safely - if we can't determine, assume no labeled children
         return false;
     }
 };

tests/lib/rules/utils/hasLabeledChild.test.ts

@@ -5,7 +5,6 @@ import { AST_NODE_TYPES, TSESTree } from "@typescript-eslint/types";
 import { TSESLint } from "@typescript-eslint/utils";
 import { hasLabeledChild } from "../../../../lib/util/hasLabeledChild";
 
-// Helper for creating mock loc/range objects
 const mockLocRange = () => ({
     loc: {
         start: { line: 0, column: 0 },
@@ -14,7 +13,6 @@ const mockLocRange = () => ({
     range: [0, 0] as [number, number]
 });
 
-// Mock context helper
 const mockContext = (sourceText = ""): TSESLint.RuleContext<string, unknown[]> => {
     return {
         getSourceCode: () => ({
@@ -24,7 +22,6 @@ const mockContext = (sourceText = ""): TSESLint.RuleContext<string, unknown[]> =
     } as unknown as TSESLint.RuleContext<string, unknown[]>;
 };
 
-// Helper to create JSX attributes
 const createJSXAttribute = (name: string, value?: string | number): TSESTree.JSXAttribute => ({
     type: AST_NODE_TYPES.JSXAttribute,
     name: {
@@ -44,7 +41,6 @@ const createJSXAttribute = (name: string, value?: string | number): TSESTree.JSX
     ...mockLocRange()
 });
 
-// Helper to create JSX opening element
 const createJSXOpeningElement = (tagName: string, attributes: TSESTree.JSXAttribute[] = []): TSESTree.JSXOpeningElement => ({
     type: AST_NODE_TYPES.JSXOpeningElement,
     name: {
@@ -57,7 +53,6 @@ const createJSXOpeningElement = (tagName: string, attributes: TSESTree.JSXAttrib
     ...mockLocRange()
 });
 
-// Helper to create JSX element
 const createJSXElement = (
     tagName: string,
     attributes: TSESTree.JSXAttribute[] = [],
@@ -78,7 +73,6 @@ const createJSXElement = (
     ...mockLocRange()
 });
 
-// Helper to create opening element with parent context
 const createOpeningElementWithParent = (tagName: string, children: TSESTree.JSXElement[] = []): TSESTree.JSXOpeningElement => {
     const parentElement = createJSXElement("Container", [], children);
     const openingElement = createJSXOpeningElement(tagName);
@@ -441,11 +435,9 @@ describe("hasLabeledChild", () => {
 
     describe("Integration with rule factory", () => {
         it("integrates correctly with makeLabeledControlRule", () => {
-            // This test ensures the function works as expected when called from the rule factory
             const imgChild = createJSXElement("img", [createJSXAttribute("alt", "Integration test")]);
             const openingElement = createOpeningElementWithParent("Button", [imgChild]);
 
-            // Simulate the call from hasAccessibleLabel in ruleFactory
             expect(hasLabeledChild(openingElement, defaultContext)).toBe(true);
         });
     });

tests/lib/rules/utils/hasLabelledChilImage.test.ts

@@ -158,8 +158,7 @@ describe("hasLabelledChildImage", () => {
 });
 
 describe("hasLabelledChildImage - missing coverage", () => {
-    it("covers line 34 - handles non-JSXElement children", () => {
-        // This test covers the case where children exist but are not JSXElement types
+    it("handles non-JSXElement children", () => {
         const mockTextChild: TSESTree.JSXText = {
             type: AST_NODE_TYPES.JSXText,
             value: "Some text content",
@@ -188,16 +187,14 @@ describe("hasLabelledChildImage - missing coverage", () => {
                 ...createMockLocRange()
             },
             closingElement: null,
-            children: [mockTextChild, mockExpressionChild], // Non-JSXElement children
+            children: [mockTextChild, mockExpressionChild],
             ...createMockLocRange()
         };
 
-        // This should execute line 34 and return false since no JSXElement children are found
         expect(hasLabelledChildImage(node)).toBe(false);
     });
 
-    it("covers line 34 - JSXElement child with non-image component name", () => {
-        // This covers the case where we have JSXElement children but they're not image components
+    it("JSXElement child with non-image component name", () => {
         const mockDivChild: TSESTree.JSXElement = {
             type: AST_NODE_TYPES.JSXElement,
             openingElement: {
@@ -233,14 +230,12 @@ describe("hasLabelledChildImage - missing coverage", () => {
             ...createMockLocRange()
         };
 
-        // This should execute line 34 and return false since child is not an image component
         expect(hasLabelledChildImage(node)).toBe(false);
     });
 });
 
 describe("isImageHidden - missing coverage for aria-label handling", () => {
-    it("covers lines 70-72 - returns false when aria-label has non-empty value", () => {
-        // This covers the case where aria-label is present and has a value (lines 70-72)
+    it("returns false when aria-label has non-empty value", () => {
         const attributes: TSESTree.JSXOpeningElement["attributes"] = [
             {
                 type: AST_NODE_TYPES.JSXAttribute,
@@ -255,12 +250,10 @@ describe("isImageHidden - missing coverage for aria-label handling", () => {
             }
         ];
 
-        // Should return false because aria-label has a value, meaning image is not hidden
         expect(isImageHidden(attributes)).toBe(false);
     });
 
-    it("covers lines 70-72 - returns false when aria-labelledby has non-empty value", () => {
-        // This covers the case where aria-labelledby is present and has a value
+    it("returns false when aria-labelledby has non-empty value", () => {
         const attributes: TSESTree.JSXOpeningElement["attributes"] = [
             {
                 type: AST_NODE_TYPES.JSXAttribute,
@@ -275,12 +268,10 @@ describe("isImageHidden - missing coverage for aria-label handling", () => {
             }
         ];
 
-        // Should return false because aria-labelledby has a value, meaning image is not hidden
         expect(isImageHidden(attributes)).toBe(false);
     });
 
     it("handles case with both aria-label and aria-labelledby present", () => {
-        // Additional test to ensure proper handling when both attributes are present
         const attributes: TSESTree.JSXOpeningElement["attributes"] = [
             {
                 type: AST_NODE_TYPES.JSXAttribute,
@@ -306,7 +297,6 @@ describe("isImageHidden - missing coverage for aria-label handling", () => {
             }
         ];
 
-        // Should return false because aria-label has a value
         expect(isImageHidden(attributes)).toBe(false);
     });
 });